search

SeleniumHQ / docker-selenium

Provides a simple way to run Selenium Grid with Chrome, Firefox, and Edge using Docker, making it easier to perform browser automation
http://www.selenium.dev/docker-selenium/
Other
7.91k stars 2.51k forks source link

[🚀 Feature]: Allow child node containers provisioned in dynamic grid to copy resolv.conf from node-docker container #2098

Closed theswordsmahin closed 5 months ago

theswordsmahin commented 8 months ago

Feature and motivation

If I add 

    dns:
      - "x.x.x.xxx"
    dns_search: testdomain.com

in my docker-compose file, the node-docker container's resol.conf file is updated and the container is able to resolve names using machine shortnames, and FQDN's from the custom DNS server, but any containers that are dynamically created are using the standard resolv.conf file and thus are forced to use IP addresses.

It would be great if the child containers could copy this file, or, an option was provided to allow further customization of the child containers that the node-docker container creates.

Usage example

Would allow usage of dynamic grid and the use of domain names on a custom DNS server, ie local intranet, rather than being forced to use IP addresses

github-actions[bot] commented 8 months ago

@theswordsmahin, thank you for creating this issue. We will troubleshoot it as soon as we can.

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

VietND96 commented 8 months ago

@diemol, I guess this has to be implemented on upstream, right?

diemol commented 8 months ago

Yes. It would be nice to have a generic way to add those things and not add them one by one.

github-actions[bot] commented 8 months ago

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

github-actions[bot] commented 4 months ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.