search

SeleniumHQ / docker-selenium

Provides a simple way to run Selenium Grid with Chrome, Firefox, and Edge using Docker, making it easier to perform browser automation
http://www.selenium.dev/docker-selenium/
Other
8k stars 2.51k forks source link

[🚀 Feature]: Add "--noproxy '*'" to Base/check-grid.sh curl #2431

Closed Zalutskii closed 1 month ago

Zalutskii commented 1 month ago

Feature and motivation

If the docker proxy settings on the host machine include localhost, there might be an issue with the "Base/check-grid.sh" check. This can be avoided by adding "--no proxy '*'" to the curl request line. In this case, the curl request will never go outside the docker container.

Usage example

curl -skSL --noproxy '*' -H "Authorization: Basic ${BASIC_AUTH}" ${SE_SERVER_PROTOCOL:-"http"}://${HOST}:${PORT}/wd/hub/status | jq -r '.value.ready' | grep -q "true" || exit 1

github-actions[bot] commented 1 month ago

@Zalutskii, thank you for creating this issue. We will troubleshoot it as soon as we can.

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

VietND96 commented 1 month ago

Good catch! I already added it

github-actions[bot] commented 1 week ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.