fix: bash avoiding newline when Base64 encoding a long string

[VietND96]

Thanks for contributing to the Docker-Selenium project! A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository. Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fixes #2435

Motivation and Context

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• [x] I have read the contributing document.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have added tests to cover my changes.
• [x] All new and existing tests passed.

[codiumai-pr-agent-pro[bot]]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

**🎫 Ticket compliance analysis ✅** **[2435](https://github.com/SeleniumHQ/docker-selenium/issues/2435) - Fully compliant** Fully compliant requirements: - Add `-w 0` option to base64 to override the max column - Fix the issue with longer passwords and usernames causing problems in the graphql health check

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Potential Compatibility Issue The `-w0` option for base64 might not be supported in all environments. Verify compatibility across different systems. Possible Security Concern Ensure that the `SE_ROUTER_USERNAME` and `SE_ROUTER_PASSWORD` environment variables are properly secured and not exposed in logs or to unauthorized users.

[codiumai-pr-agent-pro[bot]]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Best practice	Use printf instead of echo for more consistent handling of special characters ___ **Consider using printf instead of echo for more consistent behavior across different systems when dealing with special characters or escape sequences.** [Base/check-grid.sh [8]](https://github.com/SeleniumHQ/docker-selenium/pull/2437/files#diff-0707ce4020543798772b1b4661e6a051d454145938ea228c727d1dd37e72331bR8-R8) ```diff -BASIC_AUTH="$(echo -en "${SE_ROUTER_USERNAME}:${SE_ROUTER_PASSWORD}" | base64 -w0)" +BASIC_AUTH="$(printf '%s:%s' "${SE_ROUTER_USERNAME}" "${SE_ROUTER_PASSWORD}" | base64 -w0)" ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 7 Why:	7
Maintainability	Improve code organization by grouping variable declarations together ___ **Move the BASIC_AUTH variable declaration to the beginning of the script, near other variable declarations, to improve code organization and readability.** [Video/video.sh [31-32]](https://github.com/SeleniumHQ/docker-selenium/pull/2437/files#diff-7cd0ffe6390f76d290d88e6e4e3c360e9a797096c0b0fb76874303c5ca319f4bR31-R32) ```diff -/opt/bin/validate_endpoint.sh "${NODE_STATUS_ENDPOINT}" BASIC_AUTH="$(echo -en "${SE_ROUTER_USERNAME}:${SE_ROUTER_PASSWORD}" | base64 -w0)" +/opt/bin/validate_endpoint.sh "${NODE_STATUS_ENDPOINT}" + ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 7 Why:	7
Enhancement	Improve variable scope and reduce potential code duplication ___ **Consider moving the BASIC_AUTH variable declaration outside the if block to avoid potential repetition if the variable is used in multiple places.** [charts/selenium-grid/configs/node/nodeProbe.sh [39-42]](https://github.com/SeleniumHQ/docker-selenium/pull/2437/files#diff-d857ccb50aa21728930ca9f5e0300aeb9fa49db6d34d6664fe2eb221ec50baf3R39-R42) ```diff +BASIC_AUTH="$(echo -en "${SE_ROUTER_USERNAME}:${SE_ROUTER_PASSWORD}" | base64 -w0)" + return_list=($(bash ${NODE_CONFIG_DIRECTORY}/nodeGridUrl.sh)) grid_url=${return_list[0]} grid_check=${return_list[1]} -BASIC_AUTH="$(echo -en "${SE_ROUTER_USERNAME}:${SE_ROUTER_PASSWORD}" | base64 -w0)" ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 7 Why:	7

💡 Need additional feedback ? start a PR chat