SeleniumHQ / selenium-google-code-issue-archive

Archive, please see main selenium repo
https://github.com/seleniumhq/selenium
346 stars 194 forks source link

Selenium IDE PHP Formatter generates non-optimal code #1281

Closed lukeis closed 8 years ago

lukeis commented 8 years ago

Originally reported on Google Code with ID 1281

I have attached two files to this issue. The first one, actual.php, contains code that
was generated by the current Selenium IDE PHP Formatter. The second, expected.php,
shows the code as I would like to see it generated.

Reported by sebastian.bergmann on 2011-02-08 06:51:12


lukeis commented 8 years ago
Hi Sebastian,

Thanks. I will look into this. While I am at it, would you also have any comments on
the optimal code for test suites in PHP?

Cheers,
Samit

Reported by Samit.Badle on 2011-02-08 09:35:43

lukeis commented 8 years ago
No -- and that is because in PHPUnit the best practice is to just put each test case
into a separate PHP sourcecode file and have those in a directory. And then just point
PHPUnit's test runner to that directory.

Reported by sebastian.bergmann on 2011-02-08 10:28:58

lukeis commented 8 years ago
done as 11337

Note that I only did the verifyText and verifyTextPresent ones. Would be more than
happy to hand over the formatter to you to maintain, Sebastian. Either myself or Samit
can show you how to maintain an Se-IDE plugin (not that it is hard).

To get the current formatter, see http://xserve.openqa.org:8085

Reported by adamgoucher on 2011-02-08 12:46:59

lukeis commented 8 years ago

Reported by luke.semerau on 2015-09-17 18:11:56