closes SeleniumHQ#1637 - fixed selenium side runner issue in windows - Githubissues

SeleniumHQ / selenium-ide

Open Source record and playback test automation for the web.

https://selenium.dev/selenium-ide/

Apache License 2.0

2.8k stars 762 forks source link

closes SeleniumHQ#1637 - fixed selenium side runner issue in windows #1649

Closed mrgamedev07 closed 1 year ago

mrgamedev07 commented 1 year ago

Selenium side runner not working in windows machine

Description

Regarding issue #1637 fix is working fine in Windows machine .

Motivation and Context

This change will fix selenium side runner to run in windows machine .

Types of changes

[ x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x ] I have read the contributing document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x ] All new and existing tests passed.

This change does not require a test case as it is a change in the command line.

CLAassistant commented 1 year ago

All committers have signed the CLA.

toddtarsi commented 1 year ago

DUDE=! This is so huge. You rock! I appreciate it this so much. I'm going to approve and merge this, and cycle out a new version of the runner. Thank you!

toddtarsi commented 1 year ago

Oh @mrgamedev07 - Can you try and sign this license stuff? Idk how it works but I'd love to merge this and take it out

mrgamedev07 commented 1 year ago

@toddtarsi , license stuff is done ,one more check is failed because of test cases .some test case is getting failed not sure why .In my windows machine "pnpm run test" itself is not working .I think it is configured to run in mac /linux ?

toddtarsi commented 1 year ago

@mrgamedev07 - I think that's a test that needs to use localhost instead of google because it gets kinda intermittent. I'm going to rerun the job a couple times. If it fails three times in sequence, sure. But this change should either make everything fail or nothing fail I feel like.

toddtarsi commented 1 year ago

If it passes, we'll just merge and I'll dogear those tests to look at another time

toddtarsi commented 1 year ago

Nah I'm merging this thats some don't use google for your e2e test type stuff