SeleniumHQ / selenium-ide

Open Source record and playback test automation for the web.
https://selenium.dev/selenium-ide/
Apache License 2.0
2.74k stars 740 forks source link

Bug 1629 recentfile #1653

Closed mrgamedev07 closed 1 year ago

mrgamedev07 commented 1 year ago

Thanks for contributing to the Selenium IDE! A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines. Avoid large PRs, help reviewers by making them as simple and short as possible.

closes #1629

Description

A warning pop is added to show the user recent file is missing and the file will be removed from recent list

Motivation and Context

To remove the recent file in list if it is not present

Types of changes

Checklist

toddtarsi commented 1 year ago

Hey! I suspected it might be you. Want a review?

toddtarsi commented 1 year ago

@mrgamedev07 - Let me know when you'd like a review! I'd be happy to approve this as is, but I just want to get the a-okay from you.

Also, you probably want to do the following to autogenerate a release of the selenium-ide binary:

  1. Increment the version in the packages you want to release a new version of (packages/selenium-ide)
  2. Increment any dependent packages (none here, but this is kinda obnoxious with side-runtime)
  3. Run pnpm i -r to regen the lockfile and commit as well (ci release action dumps on install step if this gets missed)

Nice work as always! Very smart with that catch. Thank you

mrgamedev07 commented 1 year ago

Yes, I definitely like a review, Yup all your points are noted.

toddtarsi commented 1 year ago

@mrgamedev07 - You're approved. I see the side runner tests complaining. Ugh, it's insane how we talk about test flakiness and how its easy to tame and then we base a whole suite off of the UX at google.com never changing 🙄

toddtarsi commented 1 year ago

@mrgamedev07 - Would you like me to merge or are you able to? Further, want me to increment so a release rolls out with your fixes?

mrgamedev07 commented 1 year ago

I am not able to @toddtarsi , u can merge it .