(fix): emitNewWindowHandling types fix - Githubissues

SeleniumHQ / selenium-ide

Open Source record and playback test automation for the web.

https://selenium.dev/selenium-ide/

Apache License 2.0

2.8k stars 762 forks source link

(fix): emitNewWindowHandling types fix #1667

Closed matewilk closed 1 year ago

matewilk commented 1 year ago

Description

Types fix for https://github.com/SeleniumHQ/selenium-ide/pull/1659

Motivation and Context

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] I have read the contributing document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

matewilk commented 1 year ago

Hey @toddtarsi

When you have a moment, can you please merge?

Thanks!

toddtarsi commented 1 year ago

@matewilk - Absolutely! Sorry, had some doctor shenanigans this morning and forgot 😓