SeleniumHQ / selenium-ide

Open Source record and playback test automation for the web.
https://selenium.dev/selenium-ide/
Apache License 2.0
2.8k stars 762 forks source link

Typo in assert interface #1706

Closed mattonem closed 1 year ago

mattonem commented 1 year ago

Thanks for contributing to the Selenium IDE! A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines. Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

Checklist

mattonem commented 1 year ago

Interface doc: https://nodejs.org/api/assert.html#assertequalactual-expected-message

toddtarsi commented 1 year ago

@mattonem - Can you increment the version of the code-export-javascript-mocha package? That way it publishes a new version to npm so you can use it right away?

mattonem commented 1 year ago

@toddtarsi done. Fun story, I must have introduced this bug myself, but I just realised that my project was not pointing to the good code base. And I had tested another version of the code... Hence, I broke the mocha exporter for everyone months ago without ever being affected by it.

toddtarsi commented 1 year ago

@mattonem - I do it all the time, that's why I'm working on more tests for the ide runtime 😆 😬