search

SeleniumHQ / selenium-ide

Open Source record and playback test automation for the web.
https://selenium.dev/selenium-ide/
Apache License 2.0
2.72k stars 739 forks source link

Add a Window Timeout Field in the Command Editor, for Commands Marked as Opening a Window #1829

Closed AlexGarrity closed 1 month ago

AlexGarrity commented 1 month ago

🚀 Feature Proposal

When a command is marked as opening a window, a text field should be available to specify the timeout for opening the window. I have a sample implementation of the feature on a fork of the repo, available here

Motivation

I use Selenium IDE to test a website which occasionally has quite long page load times. As a consequence of this, the default 2 second timeout on opening a window is too short, and frequently causes tests to fail when they're actually fine. It's possible to change this behaviour by editing the .side file itself, but it's not exactly the cleanest way of doing it.

Example

You have a page that's going to take at least 2 seconds to load due to server-side rendering, and Selenium IDE is failing the test because it's taking too long. You change the timeout to a longer duration, using the window timeout field, and now it passes as expected - without having to manually tweak the .side file.

toddtarsi commented 1 month ago

I would like that very much! Very clean fork btw!

AlexGarrity commented 1 month ago

Thanks for the kind words - I'll drop in a PR now (although the Chinese translation may need some work)

toddtarsi commented 1 month ago

@AlexGarrity - No worries there, a couple of Chinese users are contributors here, so if it's rill bad, they can just fix it.

AlexGarrity commented 1 month ago

There are a couple of bits in the PR template regarding changes to documentation and testing - should I sort those out before putting the PR in?

toddtarsi commented 1 month ago

Nah! I'd need to create documentation for you to edit first 😅 . Your code looks good, if the CI passes I'm happy. I'll work on cutting a release later tonight, although it might take me an extra day or two. I finally realized I wasn't building for M1 Macs, so the build pipeline is kinda broken while I get universal working on Mac OS.

AlexGarrity commented 1 month ago

Alright, no worries then - PR submitted. I remember from my limited experience of doing Mac OS builds that they can be a right pain, so best of luck with it.

github-actions[bot] commented 3 days ago

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.