some qol changes - Githubissues

toddtarsi commented 3 months ago

User description

Adds more variables to commands

PR Type

Enhancement, Tests

Description

Simplified slicing logic in composePreprocessors function.
Added multiple new command preprocessors for various assertions in webdriver.ts.
Updated versions and dependencies across multiple package.json files to 4.0.10.
Enhanced text comparison test with variables in text-comparison.side.
Updated pnpm-lock.yaml to reflect new package versions.

Changes walkthrough 📝

Relevant files

Enhancement

2 files

preprocessors.ts Simplified slicing logic in `composePreprocessors` function. packages/side-runtime/src/preprocessors.ts - Simplified slicing logic in `composePreprocessors` function.	+1/-1
webdriver.ts `Added and updated command preprocessors for assertions.` packages/side-runtime/src/webdriver.ts Added multiple new command preprocessors for various assertions. Updated existing preprocessors to include `targetFallback`.	+54/-2

Dependencies

21 files

package.json `Bumped package version to 4.0.10.` packages/browser-info/package.json - Updated version to `4.0.10`.	+1/-1
package.json `Bumped package and dependencies versions to 4.0.10.` packages/code-export-csharp-commons/package.json - Updated version to `4.0.10`. - Updated dependencies to `4.0.10`.	+3/-3
package.json `Bumped package and dependencies versions to 4.0.10.` packages/code-export-csharp-nunit/package.json - Updated version to `4.0.10`. - Updated dependencies to `4.0.10`.	+3/-3
package.json `Bumped package and dependencies versions to 4.0.10.` packages/code-export-csharp-xunit/package.json - Updated version to `4.0.10`. - Updated dependencies to `4.0.10`.	+4/-4
package.json `Bumped package and dependencies versions to 4.0.10.` packages/code-export-java-junit/package.json - Updated version to `4.0.10`. - Updated dependencies to `4.0.10`.	+3/-3
package.json `Bumped package and dependencies versions to 4.0.10.` packages/code-export-javascript-mocha/package.json - Updated version to `4.0.10`. - Updated dependencies to `4.0.10`.	+3/-3
package.json `Bumped package and dependencies versions to 4.0.10.` packages/code-export-python-pytest/package.json - Updated version to `4.0.10`. - Updated dependencies to `4.0.10`.	+3/-3
package.json `Bumped package and dependencies versions to 4.0.10.` packages/code-export-ruby-rspec/package.json - Updated version to `4.0.10`. - Updated dependencies to `4.0.10`.	+3/-3
package.json `Bumped package version to 4.0.10.` packages/get-driver/package.json - Updated version to `4.0.10`.	+1/-1
package.json `Bumped package and dependencies versions to 4.0.10.` packages/selenium-ide/package.json - Updated version to `4.0.10`. - Updated dependencies to `4.0.10`.	+13/-13
package.json `Bumped package and dependencies versions to 4.0.10.` packages/side-api/package.json - Updated version to `4.0.10`. - Updated dependencies to `4.0.10`.	+5/-5
package.json `Bumped package and dependencies versions to 4.0.10.` packages/side-code-export/package.json - Updated version to `4.0.10`. - Updated dependencies to `4.0.10`.	+3/-3
package.json `Bumped package version to 4.0.10.` packages/side-commons/package.json - Updated version to `4.0.10`.	+1/-1
package.json `Bumped package and dependencies versions to 4.0.10.` packages/side-example-suite/package.json - Updated version to `4.0.10`. - Updated dependencies to `4.0.10`.	+4/-4
package.json `Bumped package version to 4.0.10.` packages/side-migrate/package.json - Updated version to `4.0.10`.	+1/-1
package.json `Bumped package version to 4.0.10.` packages/side-model/package.json - Updated version to `4.0.10`.	+1/-1
package.json `Bumped package and dependencies versions to 4.0.10.` packages/side-runner/package.json - Updated version to `4.0.10`. - Updated dependencies to `4.0.10`.	+3/-3
package.json `Bumped package and dependencies versions to 4.0.10.` packages/side-runtime/package.json - Updated version to `4.0.10`. - Updated dependencies to `4.0.10`.	+6/-6
package.json `Bumped package version to 4.0.10.` packages/side-testkit/package.json - Updated version to `4.0.10`.	+1/-1
package.json `Bumped package and dependencies versions to 4.0.10.` packages/webdriver-testkit/package.json - Updated version to `4.0.10`. - Updated dependencies to `4.0.10`.	+3/-3
pnpm-lock.yaml `Updated lock file with new package versions.` pnpm-lock.yaml - Updated all package versions and dependencies to `4.0.10`.	+46/-46

Tests

1 files

text-comparison.side

Enhanced text comparison test with variables.

tests/examples/text-comparison.side

Added new variables for ID and text values.

Updated commands to use variables.

+83/-50

💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

codiumai-pr-agent-pro[bot] commented 3 months ago

PR Review 🔍

⏱️ Estimated effort to review [1-5]	3, because the PR includes a variety of changes across multiple files, including logic adjustments in function calls, addition of new command preprocessors, and updates to package versions. The changes are not overly complex but are numerous and spread across different aspects of the project, requiring careful review to ensure compatibility and correctness.
🧪 Relevant tests	Yes
⚡ Possible issues	Duplicate Function: The function `WebDriverExecutor.prototype.doAssertNotChecked` is defined twice in `webdriver.ts`. This could lead to unexpected behavior or errors during runtime.
⚡ Possible issues	Version Consistency: The PR updates several package versions to `4.0.10`. It's important to ensure that these updates do not introduce any compatibility issues with other parts of the system.
🔒 Security concerns	No