Closed nir-tal-talkspace closed 1 year ago
@nir-tal-talkspace, thank you for creating this issue. We will troubleshoot it as soon as we can.
Triage this issue by using labels.
If information is missing, add a helpful comment and then I-issue-template
label.
If the issue is a question, add the I-question
label.
If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted
label.
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable G-*
label, and it will provide the correct link and auto-close the
issue.
After troubleshooting the issue, please add the R-awaiting answer
label.
Thank you!
@diemol @pujagani this is the issue we talked about on slack. thanks!
looks like it's related to this commit https://github.com/SeleniumHQ/selenium/commit/c5943bde4c7092f534a73551dad1d3a6d307dee7
Thank you for sharing the details and helping pinpoint that the error occurs when we request to create an explicit DevTools session. The behavior is strange but I am able to reproduce it. Strangely though the error does not occur when using Augmenter and the Grid. I am triaging it now on priority to identify the root cause.
Turns out, we were closing the DevTools connection twice and hence it would time out since commands were issued on the same connection after it was closed. Once in the browser implementation on quit and once again in the RemoteWebDriver. Now that the logic sits in the RemoteWebDriver, I have removed browser-specific calls to close the CDP connections and that sorts this issue out. cc: @diemol @nir-tal-talkspace
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
What happened?
as of version 4.7.1 selenium bindings throws this error:
Process finished with exit code 1
when calling driver.quit() without devtools.close() after creating a devtools session this has worked for many years, this change is undocumented and i would expect calling driver.quit() without devtools.close() should close the devtools session anyway
see repo to reproduce the issue: https://github.com/nir-tal-talkspace/devtoolsbug
executing the same steps with 4.7.0 bindings the result is:
How can we reproduce the issue?
Relevant log output
Operating System
all
Selenium version
4.7.1
What are the browser(s) and version(s) where you see this issue?
chrome
What are the browser driver(s) and version(s) where you see this issue?
Version 108.0.5359.98 (Official Build) (x86_64)
Are you using Selenium Grid?
No response