search

SeleniumHQ / selenium

A browser automation framework and ecosystem.
https://selenium.dev
Apache License 2.0
30.26k stars 8.15k forks source link

Invalid inputs are not cleared properly #1214

Closed MattiSG closed 8 years ago

MattiSG commented 8 years ago

Here is a test case that uses Watai:

(assuming you have a running Selenium Server)

$ git clone https://gist.github.com/0cb11f94237a414c6872.git
$ npm install watai@0.7.0-beta.1
$ node_modules/.bin/watai .

Sorry, I have long forgotten Selenium’s native API.

Reproduced with v2.45 and v2.48.0, on both Firefox and Chrome.

lukeis commented 8 years ago

please provide a reproducible test case for us using "Selenium's native API" we don't have the time to look through the other project for a potential bug in it. Can reopen this bug if a concise reproducible test case is provided.

MattiSG commented 8 years ago

Does a series of JSONwire commands qualify, or do I really need to write Java to contribute bug reports?

lukeis commented 8 years ago

that could be a start... you don't need java... we also have C#, python, ruby, javascript :)

MattiSG commented 8 years ago

Test case updated.

lukeis commented 8 years ago

thanks for the reproducible test case!

lukeis commented 8 years ago

since it was fixed in the atoms, this should be fixed in chromedriver the next time they pull in the atoms and do a release.

will be available in firefox in the next release, or you could always build from source.

MattiSG commented 8 years ago

Great!

Looking at the referenced commit, I'm wondering if you won't get the exact same issue with all the different input types that are expected to give a value of type other than String in JS. WDYT?

Matti Schneider ———— Written on a phone, please excuse the terseness. Rédigé sur un téléphone, veuillez excuser la brièveté.

lukeis commented 8 years ago

I tried with a variety of other input types (from the html 5 spec) and only number exhibited this behavior. If others in the future do too, then we'll have to correct it then.

MattiSG commented 8 years ago

:+1: