search

SeleniumHQ / selenium

A browser automation framework and ecosystem.
https://selenium.dev
Apache License 2.0
30.76k stars 8.2k forks source link

[dotnet] Devide `PointerInputSource` to sub-classes #13406

Open nvborisenko opened 10 months ago

nvborisenko commented 10 months ago

https://github.com/SeleniumHQ/selenium/blob/886cdf5397481ebebe02310b8b3aa07f374695ef/dotnet/src/webdriver/Interactions/PointerInputDevice.cs#L74C5-L74C5

MouseButton enum contains Touch member, it seems really strange.

According spec https://www.w3.org/TR/webdriver2/#pointer-input-source Pointer input source has subtypes, like Mouse or Pen. It seems that PointerInputSource should be abstract class, and derived MouseInputSource and PenInputSource.

Dor-bl commented 10 months ago

I assume there's should be TouchInputSource as well.

titusfortner commented 10 months ago

This enum is for the pointerId item —https://w3c.github.io/webdriver/#pointer-input-source

In this case "touch" is for "pen" input — https://www.w3.org/TR/pointerevents/#the-button-property

The Touch API requires multiple pointer devices simultaneously, and none of the bindings have implemented it. The issue for it is here — https://github.com/SeleniumHQ/selenium/issues/10808

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 280 days with no activity. Remove stale label or comment or this will be closed in 14 days.

Dor-bl commented 1 month ago

@nvborisenko can you please remove the stale label?