[🐛 Bug]: Selenium Manager Should honor full browser version

titusfortner commented 5 months ago

What happened?

If a user specifies a specific patch version of the browser and it is available, Selenium should download it.

How can we reproduce the issue?

"selenium-manager", "--browser", "chrome", "--browser-version", "120.0.6099.71", "--language-binding", "ruby", "--output", "mixed", "--debug"

Relevant log output

DEBUG   chromedriver not found in PATH
DEBUG   chrome detected at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
DEBUG   Running command: /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --version
DEBUG   Output: "Google Chrome 120.0.6099.199 "
DEBUG   Detected browser: chrome 120.0.6099.199
DEBUG   Required driver: chromedriver 120.0.6099.109
DEBUG   Discovering versions from https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json
DEBUG   Downloading chromedriver 120.0.6099.109 from https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/120.0.6099.109/mac-x64/chromedriver-mac-x64.zip
INFO    Driver path: /Users/titusfortner/.cache/selenium/chromedriver/mac-x64/120.0.6099.109/chromedriver
INFO    Browser path: /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

Operating System

Mac

Selenium version

sm_mixed_output branch

What are the browser(s) and version(s) where you see this issue?

n/a

What are the browser driver(s) and version(s) where you see this issue?

n/a

Are you using Selenium Grid?

n/a

github-actions[bot] commented 5 months ago

@titusfortner, thank you for creating this issue. We will troubleshoot it as soon as we can.

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

diemol commented 1 month ago

The decision to implement this was made during the Selenium Dev Summit in May 2024.

SeleniumHQ / selenium