Closed selenium-ci closed 4 months ago
โฑ๏ธ Estimated effort to review [1-5] | 2, because the changes are straightforward and limited to updating URLs and checksums for browser versions. The scope is narrow and the changes are clear, making it relatively easy to review. |
๐งช Relevant tests | No |
โก Possible issues | No |
๐ Security concerns | No |
Category | Suggestion | Score |
Maintainability |
Add a comment to indicate that the
___
**Consider adding a comment above the | 7 |
Best practice |
Add a trailing comma after the
___
**To ensure consistency and avoid potential issues with line endings, consider adding a | 5 |
**Action:** Ruby / Remote Tests (safari, macos) / Remote Tests (safari, macos) |
**Failed stage:** [Run Bazel](https://github.com/SeleniumHQ/selenium/actions/runs/9261718991/job/25477710242) [โ] |
**Failed test name:** Selenium::WebDriver::Window can minimize the window |
**Failure summary:**
The action failed because the test Selenium::WebDriver::Window can minimize the window failed. The test failure was due to a Selenium::WebDriver::Error::TimeoutError :TimeoutError after 10 seconds.return document.hidden; and waiting for the condition to be met. |
Relevant error logs:```yaml 1: ##[group]Operating System 2: macOS ... 775: /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: warning renaming duplicate member name 'map_field.o' from 'bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protoc_lib/0/map_field.o(map_field.o)' and 'bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protoc_lib/1/map_field.o(map_field.o)' 776: /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: warning renaming duplicate member name 'message.o' from 'bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protoc_lib/1/message.o(message.o)' and 'bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protoc_lib/0/message.o(message.o)' 777: /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: warning renaming duplicate member name 'message_field.o' from 'bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protoc_lib/0/message_field.o(message_field.o)' and 'bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protoc_lib/1/message_field.o(message_field.o)' 778: /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: warning renaming duplicate member name 'primitive_field.o' from 'bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protoc_lib/1/primitive_field.o(primitive_field.o)' and 'bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protoc_lib/0/primitive_field.o(primitive_field.o)' 779: /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: warning renaming duplicate member name 'service.o' from 'bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protoc_lib/0/service.o(service.o)' and 'bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protoc_lib/1/service.o(service.o)' 780: /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: warning renaming duplicate member name 'string_field.o' from 'bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protoc_lib/0/string_field.o(string_field.o)' and 'bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protoc_lib/1/string_field.o(string_field.o)' 781: [32m[1,815 / 3,092][0m [Sched] Building java/src/org/openqa/selenium/libcore-lib.jar (139 source files) [for tool]; Downloading external/rules_java~/toolchains/platformclasspath.jar, 23.2 MiB / 120.9 MiB ... (4 actions, 1 running) 782: [32mINFO: [0mFrom Linking external/protobuf~/libprotobuf.a [for tool]: 783: /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: file: bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protobuf/error_listener.o has no symbols ... 815: [32m[2,432 / 3,092][0m Extracting npm package @mui/icons-material@5.15.18_-796748879; 40s darwin-sandbox, disk-cache ... (4 actions, 3 running) 816: [32m[2,573 / 3,092][0m Extracting npm package @mui/icons-material@5.15.18_-796748879; 41s darwin-sandbox, disk-cache ... (4 actions, 3 running) 817: [32m[2,685 / 3,092][0m Extracting npm package @mui/icons-material@5.15.18_-796748879; 42s darwin-sandbox, disk-cache ... (4 actions, 3 running) 818: [32m[2,781 / 3,092][0m Running bundle install (@bundle//:bundle); 11s darwin-sandbox, disk-cache ... (4 actions, 2 running) 819: [32m[2,888 / 3,092][0m Running bundle install (@bundle//:bundle); 12s darwin-sandbox, disk-cache ... (4 actions, 3 running) 820: [32m[2,958 / 3,092][0m Running bundle install (@bundle//:bundle); 13s darwin-sandbox, disk-cache ... (3 actions running) 821: [32m[2,959 / 3,092][0m Running bundle install (@bundle//:bundle); 17s darwin-sandbox, disk-cache ... (3 actions, 2 running) 822: [32mINFO: [0mFrom Building java/src/org/openqa/selenium/remote/libapi-class.jar (66 source files): 823: java/src/org/openqa/selenium/remote/ErrorHandler.java:46: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 824: private final ErrorCodes errorCodes; 825: ^ 826: java/src/org/openqa/selenium/remote/ErrorHandler.java:60: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 827: this.errorCodes = new ErrorCodes(); 828: ^ 829: java/src/org/openqa/selenium/remote/ErrorHandler.java:68: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 830: public ErrorHandler(ErrorCodes codes, boolean includeServerErrors) { 831: ^ 832: java/src/org/openqa/selenium/remote/Response.java:97: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 833: ErrorCodes errorCodes = new ErrorCodes(); 834: ^ 835: java/src/org/openqa/selenium/remote/Response.java:97: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 836: ErrorCodes errorCodes = new ErrorCodes(); 837: ^ 838: java/src/org/openqa/selenium/remote/ProtocolHandshake.java:181: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 839: response.setStatus(ErrorCodes.SUCCESS); 840: ^ 841: java/src/org/openqa/selenium/remote/ProtocolHandshake.java:182: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 842: response.setState(ErrorCodes.SUCCESS_STRING); 843: ^ 844: java/src/org/openqa/selenium/remote/W3CHandshakeResponse.java:53: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 845: new ErrorCodes().toStatus((String) rawError, Optional.of(tuple.getStatusCode()))); 846: ^ 847: java/src/org/openqa/selenium/remote/W3CHandshakeResponse.java:56: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 848: new ErrorCodes().getExceptionType((String) rawError); 849: ^ 850: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:44: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 851: private final ErrorCodes errorCodes = new ErrorCodes(); 852: ^ 853: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:44: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 854: private final ErrorCodes errorCodes = new ErrorCodes(); 855: ^ 856: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:55: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 857: int status = response.getStatus() == ErrorCodes.SUCCESS ? HTTP_OK : HTTP_INTERNAL_ERROR; 858: ^ 859: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:101: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 860: response.setStatus(ErrorCodes.UNKNOWN_COMMAND); 861: ^ 862: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:103: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 863: response.setStatus(ErrorCodes.UNHANDLED_ERROR); 864: ^ 865: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:124: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 866: response.setStatus(ErrorCodes.SUCCESS); 867: ^ 868: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:125: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 869: response.setState(errorCodes.toState(ErrorCodes.SUCCESS)); 870: ^ 871: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:131: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 872: response.setState(errorCodes.toState(ErrorCodes.SUCCESS)); 873: ^ 874: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:70: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 875: private final ErrorCodes errorCodes = new ErrorCodes(); 876: ^ 877: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:70: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 878: private final ErrorCodes errorCodes = new ErrorCodes(); 879: ^ 880: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:93: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 881: response.setStatus(ErrorCodes.UNKNOWN_COMMAND); 882: ^ 883: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:98: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 884: response.setStatus(ErrorCodes.UNHANDLED_ERROR); 885: ^ 886: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:145: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 887: response.setStatus(ErrorCodes.SUCCESS); ... 1023: [32m[3,094 / 3,095][0m 2 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:shadow_root-safari-remote; 0s disk-cache 1024: [32m[3,094 / 3,095][0m 2 / 24 tests;[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:shadow_root-safari-remote 1025: [32m[3,094 / 3,095][0m 2 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:shadow_root-safari-remote; 1s local, disk-cache 1026: [32m[3,094 / 3,095][0m 2 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:shadow_root-safari-remote; 65s local, disk-cache 1027: [32m[3,095 / 3,096][0m 3 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:timeout-safari-remote; 0s disk-cache 1028: [32m[3,095 / 3,096][0m 3 / 24 tests;[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:timeout-safari-remote 1029: [32m[3,095 / 3,096][0m 3 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:timeout-safari-remote; 1s local, disk-cache 1030: [32m[3,095 / 3,096][0m 3 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:timeout-safari-remote; 21s local, disk-cache 1031: [32m[3,096 / 3,097][0m 4 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:error-safari-remote; 1s disk-cache 1032: [32m[3,096 / 3,097][0m 4 / 24 tests;[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:error-safari-remote 1033: [32m[3,096 / 3,097][0m 4 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:error-safari-remote; 1s local, disk-cache 1034: [32m[3,096 / 3,097][0m 4 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:error-safari-remote; 17s local, disk-cache ... 1092: [32m[3,112 / 3,113][0m 20 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:window-safari-remote; 39s local, disk-cache 1093: [31m[1mFAIL: [0m//rb/spec/integration/selenium/webdriver:window-safari-remote (see /Users/runner/.bazel/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/window-safari-remote/test_attempts/attempt_1.log) 1094: [32m[3,112 / 3,113][0m 20 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:window-safari-remote; 40s local, disk-cache 1095: [32m[3,112 / 3,113][0m 20 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:window-safari-remote; 78s local, disk-cache 1096: [31m[1mFAIL: [0m//rb/spec/integration/selenium/webdriver:window-safari-remote (see /Users/runner/.bazel/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/window-safari-remote/test_attempts/attempt_2.log) 1097: [32m[3,112 / 3,113][0m 20 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:window-safari-remote; 79s local, disk-cache 1098: [32m[3,112 / 3,113][0m 20 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:window-safari-remote; 117s local, disk-cache 1099: [31m[1mFAIL: [0m//rb/spec/integration/selenium/webdriver:window-safari-remote (see /Users/runner/.bazel/execroot/_main/bazel-out/darwin_x86_64-fastbuild/testlogs/rb/spec/integration/selenium/webdriver/window-safari-remote/test.log) 1100: [31m[1mFAILED: [0m//rb/spec/integration/selenium/webdriver:window-safari-remote (Summary) ... 1114: gets the size of the current window 1115: sets the size of the current window 1116: gets the position of the current window 1117: sets the position of the current window 1118: gets the rect of the current window 1119: sets the rect of the current window 1120: can maximize the current window 1121: can make window full screen 1122: can minimize the window (FAILED - 1) 1123: Failures: 1124: 1) Selenium::WebDriver::Window can minimize the window 1125: Failure/Error: 1126: expect { 1127: wait.until { driver.execute_script('return document.hidden;') } 1128: }.not_to raise_error 1129: expected no Exception, got # |
User description
This is an automated pull request to update pinned browsers and drivers
Merge after verify the new browser versions properly passing the tests and no bugs need to be filed
PR Type
enhancement, configuration changes
Description
Changes walkthrough ๐
repositories.bzl
Update pinned Firefox beta versions for Linux and Mac
common/repositories.bzl
127.0b6 to 127.0b7.
127.0b6 to 127.0b7.