Closed selenium-ci closed 1 month ago
โฑ๏ธ Estimated effort to review [1-5] | 2, because the changes are straightforward and limited to updating URLs and checksums for browser versions. The complexity is low and the changes are clearly defined. |
๐งช Relevant tests | No |
โก Possible issues | Possible Regression: Ensure that the new browser versions do not introduce regressions or compatibility issues with existing tests and functionalities. |
๐ Security concerns | No |
Category | Suggestion | Score |
Security |
Ensure the
___
**Verify that the | 8 |
Best practice |
Add a comment explaining the reason for the Firefox version update and the source of the new
___
**Consider adding a comment explaining the reason for updating the Firefox version and the | 7 |
Possible issue |
Verify the URLs for the Firefox downloads to ensure they are correct and accessible___ **Ensure that the URLs for the Firefox downloads are correct and accessible. Broken URLs cancause build failures.** [common/repositories.bzl [36]](https://github.com/SeleniumHQ/selenium/pull/14046/files#diff-25d82cd18102fed27d3202000e1f1b3a56a85ad2848236d91989cd30a3952401R36-R36) ```diff -url = "https://ftp.mozilla.org/pub/firefox/releases/126.0.1/mac/en-US/Firefox%20126.0.1.dmg", +url = "https://ftp.mozilla.org/pub/firefox/releases/126.0.1/mac/en-US/Firefox%20126.0.1.dmg", # Verify this URL ``` Suggestion importance[1-10]: 7Why: Ensuring URL correctness is important to prevent build failures due to inaccessible resources, thus this suggestion is quite relevant. | 7 |
Maintainability |
Use a variable for the Firefox version number to avoid repetition and simplify future updates___ **Consider using a variable for the Firefox version number to avoid repetition and makefuture updates easier.** [common/repositories.bzl [14]](https://github.com/SeleniumHQ/selenium/pull/14046/files#diff-25d82cd18102fed27d3202000e1f1b3a56a85ad2848236d91989cd30a3952401R14-R14) ```diff -url = "https://ftp.mozilla.org/pub/firefox/releases/126.0.1/linux-x86_64/en-US/firefox-126.0.1.tar.bz2", +FIREFOX_VERSION = "126.0.1" +url = f"https://ftp.mozilla.org/pub/firefox/releases/{FIREFOX_VERSION}/linux-x86_64/en-US/firefox-{FIREFOX_VERSION}.tar.bz2", ``` Suggestion importance[1-10]: 6Why: Using a variable for the version number improves code maintainability and reduces the risk of errors during updates, though it's a relatively minor enhancement. | 6 |
**Action:** Ruby / Remote Tests (safari, macos) / Remote Tests (safari, macos) |
**Failed stage:** [Run Bazel](https://github.com/SeleniumHQ/selenium/actions/runs/9278263028/job/25529177298) [โ] |
**Failed test name:** Selenium::WebDriver::ActionBuilder#scroll_from scrolls by given amount with offset |
**Failure summary:**
The action failed due to multiple test failures in the Selenium WebDriver integration tests for Safari remote. Specific issues include: Selenium::WebDriver::ActionBuilder#scroll_from scrolls by given amount with offset failed due to a Selenium::WebDriver::Error::TimeoutError .Navigation navigates back and forward failed because the title did not change as expected.Navigation refreshes the page failed due to a navigation error.Selenium::WebDriver::ActionBuilder#send_keys sends keys to the active element failed due to a Selenium::WebDriver::Error::TimeoutError .Selenium::WebDriver::ActionBuilder multiple key presses sends keys with shift pressed failed due to a mismatch in expected key events. Selenium::WebDriver::ActionBuilder#release_actions releases pressed buttons failed because the expected value was "Clicked" but got "Hello". Selenium::WebDriver::ActionBuilder#double_click presses pointer twice and Selenium::WebDriver::ActionBuilder#double_click executes with equivalent pointer methods failed because the expected value was "DoubleClicked" but got "Clicked". Selenium::WebDriver::ActionBuilder pen stylus sets pointer event properties failed due to a Selenium::WebDriver::Error::NoSuchElementError .Selenium::WebDriver::ActionBuilder#scroll_to scrolls to element failed due to a Selenium::WebDriver::Error::MoveTargetOutOfBoundsError .Selenium::WebDriver::ActionBuilder#scroll_from scrolls from element by given amount and Selenium::WebDriver::ActionBuilder#scroll_from scrolls from element by given amount with offset failed due to a Selenium::WebDriver::Error::MoveTargetOutOfBoundsError .Selenium::WebDriver::ActionBuilder#scroll_from raises MoveTargetOutOfBoundsError when origin offset is out of viewport failed because the expected error was not raised. |
Relevant error logs:```yaml 1: ##[group]Operating System 2: macOS ... 720: [32m[1 / 1][0m checking cached actions 721: [32mAnalyzing:[0m 24 targets (685 packages loaded, 27228 targets configured) 722: [32m[1 / 1][0m checking cached actions 723: [32mAnalyzing:[0m 24 targets (686 packages loaded, 27675 targets configured) 724: [32m[1 / 1][0m checking cached actions 725: [32mAnalyzing:[0m 24 targets (688 packages loaded, 28340 targets configured) 726: [32m[1 / 1][0m checking cached actions 727: [32mAnalyzing:[0m 24 targets (688 packages loaded, 28803 targets configured) 728: [32m[1 / 25][0m [Prepa] Writing repo mapping manifest for //rb/spec/integration/selenium/webdriver:error-safari-remote ... 752: inline void* Offset(void* base, uint32_t offset) { 753: [0;1;32m ^ 754: [0m1 warning generated. 755: [32mINFO: [0mFrom Linking external/protobuf~/libprotobuf_lite.a [for tool]: 756: /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: file: bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protobuf_lite/io_win32.o has no symbols 757: [32m[1,564 / 3,092][0m Compiling src/google/protobuf/compiler/python/pyi_generator.cc [for tool]; 0s disk-cache ... (3 actions, 0 running) 758: [32m[1,697 / 3,092][0m Compiling src/google/protobuf/empty.pb.cc [for tool]; 0s disk-cache ... (2 actions, 0 running) 759: [32mINFO: [0mFrom Linking external/protobuf~/libprotobuf.a [for tool]: 760: /Applications/Xcode_15.0.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: file: bazel-out/darwin_x86_64-opt-exec-ST-13d3ddad9198/bin/external/protobuf~/_objs/protobuf/error_listener.o has no symbols ... 849: [32mINFO: [0mFrom PackageZip javascript/grid-ui/react-zip.jar: 850: /Users/runner/.bazel/execroot/_main/external/rules_python~~python~python_3_8_x86_64-apple-darwin/lib/python3.8/zipfile.py:1517: UserWarning: Duplicate name: 'grid-ui/' 851: return self._open_to_write(zinfo, force_zip64=force_zip64) 852: [32m[2,958 / 3,092][0m Running bundle install (@bundle//:bundle); 59s darwin-sandbox, disk-cache ... (3 actions, 2 running) 853: [32m[2,961 / 3,092][0m Running bundle install (@bundle//:bundle); 61s darwin-sandbox, disk-cache ... (2 actions, 1 running) 854: [32m[2,961 / 3,092][0m Running bundle install (@bundle//:bundle); 62s darwin-sandbox, disk-cache ... (2 actions running) 855: [32m[2,962 / 3,092][0m Running bundle install (@bundle//:bundle); 64s darwin-sandbox, disk-cache ... (2 actions, 1 running) 856: [32mINFO: [0mFrom Building java/src/org/openqa/selenium/remote/libapi-class.jar (66 source files): 857: java/src/org/openqa/selenium/remote/ErrorHandler.java:46: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 858: private final ErrorCodes errorCodes; 859: ^ 860: java/src/org/openqa/selenium/remote/ErrorHandler.java:60: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 861: this.errorCodes = new ErrorCodes(); 862: ^ 863: java/src/org/openqa/selenium/remote/ErrorHandler.java:68: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 864: public ErrorHandler(ErrorCodes codes, boolean includeServerErrors) { 865: ^ 866: java/src/org/openqa/selenium/remote/Response.java:97: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 867: ErrorCodes errorCodes = new ErrorCodes(); 868: ^ 869: java/src/org/openqa/selenium/remote/Response.java:97: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 870: ErrorCodes errorCodes = new ErrorCodes(); 871: ^ 872: java/src/org/openqa/selenium/remote/ProtocolHandshake.java:181: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 873: response.setStatus(ErrorCodes.SUCCESS); 874: ^ 875: java/src/org/openqa/selenium/remote/ProtocolHandshake.java:182: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 876: response.setState(ErrorCodes.SUCCESS_STRING); 877: ^ 878: java/src/org/openqa/selenium/remote/W3CHandshakeResponse.java:53: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 879: new ErrorCodes().toStatus((String) rawError, Optional.of(tuple.getStatusCode()))); 880: ^ 881: java/src/org/openqa/selenium/remote/W3CHandshakeResponse.java:56: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 882: new ErrorCodes().getExceptionType((String) rawError); 883: ^ 884: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:44: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 885: private final ErrorCodes errorCodes = new ErrorCodes(); 886: ^ 887: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:44: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 888: private final ErrorCodes errorCodes = new ErrorCodes(); 889: ^ 890: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:55: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 891: int status = response.getStatus() == ErrorCodes.SUCCESS ? HTTP_OK : HTTP_INTERNAL_ERROR; 892: ^ 893: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:101: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 894: response.setStatus(ErrorCodes.UNKNOWN_COMMAND); 895: ^ 896: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:103: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 897: response.setStatus(ErrorCodes.UNHANDLED_ERROR); 898: ^ 899: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:124: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 900: response.setStatus(ErrorCodes.SUCCESS); 901: ^ 902: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:125: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 903: response.setState(errorCodes.toState(ErrorCodes.SUCCESS)); 904: ^ 905: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:131: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 906: response.setState(errorCodes.toState(ErrorCodes.SUCCESS)); 907: ^ 908: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:70: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 909: private final ErrorCodes errorCodes = new ErrorCodes(); 910: ^ 911: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:70: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 912: private final ErrorCodes errorCodes = new ErrorCodes(); 913: ^ 914: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:93: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 915: response.setStatus(ErrorCodes.UNKNOWN_COMMAND); 916: ^ 917: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:98: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 918: response.setStatus(ErrorCodes.UNHANDLED_ERROR); 919: ^ 920: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:145: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 921: response.setStatus(ErrorCodes.SUCCESS); ... 1043: [32m[3,093 / 3,094][0m 1 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:driver-safari-remote; 1s local, disk-cache 1044: [32m[3,093 / 3,094][0m 1 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:driver-safari-remote; 48s local, disk-cache 1045: [32m[3,094 / 3,095][0m 2 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:shadow_root-safari-remote; 1s disk-cache 1046: [32m[3,094 / 3,095][0m 2 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:shadow_root-safari-remote; 0s local, disk-cache 1047: [32m[3,094 / 3,095][0m 2 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:shadow_root-safari-remote; 63s local, disk-cache 1048: [32m[3,095 / 3,096][0m 3 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:timeout-safari-remote; 1s disk-cache 1049: [32m[3,095 / 3,096][0m 3 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:timeout-safari-remote; 0s local, disk-cache 1050: [32m[3,095 / 3,096][0m 3 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:timeout-safari-remote; 22s local, disk-cache 1051: [32m[3,096 / 3,097][0m 4 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:error-safari-remote; 0s disk-cache 1052: [32m[3,096 / 3,097][0m 4 / 24 tests;[0m [Sched] Testing //rb/spec/integration/selenium/webdriver:error-safari-remote 1053: [32m[3,096 / 3,097][0m 4 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:error-safari-remote; 1s local, disk-cache 1054: [32m[3,096 / 3,097][0m 4 / 24 tests;[0m Testing //rb/spec/integration/selenium/webdriver:error-safari-remote; 17s local, disk-cache ... 1112: moves pointer to specified coordinates 1113: pen stylus 1114: sets pointer event properties (PENDING: Test guarded; Some issues with resolution?) 1115: #scroll_to 1116: scrolls to element (PENDING: Test guarded; no reason given) 1117: #scroll_by 1118: scrolls by given amount 1119: #scroll_from 1120: scrolls from element by given amount (PENDING: Test guarded; incorrect MoveTargetOutOfBoundsError) 1121: scrolls from element by given amount with offset (PENDING: Test guarded; incorrect MoveTargetOutOfBoundsError) 1122: raises MoveTargetOutOfBoundsError when origin offset from element is out of viewport 1123: scrolls by given amount with offset (FAILED - 1) 1124: raises MoveTargetOutOfBoundsError when origin offset is out of viewport (PENDING: Test guarded; no reason given) 1125: Pending: (Failures listed here are expected and do not affect your suite's status) 1126: 1) Selenium::WebDriver::ActionBuilder#send_keys sends keys to the active element 1127: # Test guarded; no reason given 1128: Failure/Error: wait.until { keylogger.text.split.length == 2 } 1129: Selenium::WebDriver::Error::TimeoutError: 1130: timed out after 10 seconds 1131: # ./rb/lib/selenium/webdriver/common/wait.rb:73:in `until' 1132: # ./rb/spec/integration/selenium/webdriver/action_builder_spec.rb:35:in `block (3 levels) in |
User description
This is an automated pull request to update pinned browsers and drivers
Merge after verify the new browser versions properly passing the tests and no bugs need to be filed
PR Type
Enhancement, Configuration changes
Description
Changes walkthrough ๐
repositories.bzl
Update pinned Firefox browser versions for Linux and Mac
common/repositories.bzl
version 126.0.1.
version 126.0.1.