Closed selenium-ci closed 3 weeks ago
⏱️ Estimated effort to review [1-5] | 2, because the changes are straightforward and involve only updating URLs and checksums for browser versions. The scope is limited and the modifications are clear, making it relatively easy to review. |
🧪 Relevant tests | No |
⚡ Possible issues | Possible Dependency Issue: If the new browser versions (127.0b8) have compatibility issues with existing tests or dependencies, it could lead to failures in automated testing environments. This should be verified by running all relevant tests. |
🔒 Security concerns | No |
Category | Suggestion | Score |
Enhancement |
Use a variable for the version number to avoid hardcoding it in multiple places___ **Consider using a variable for the version number to avoid hardcoding it in multipleplaces. This will make future updates easier and reduce the risk of inconsistencies.** [common/repositories.bzl [53-54]](https://github.com/SeleniumHQ/selenium/pull/14053/files#diff-25d82cd18102fed27d3202000e1f1b3a56a85ad2848236d91989cd30a3952401R53-R54) ```diff -url = "https://ftp.mozilla.org/pub/firefox/releases/127.0b8/linux-x86_64/en-US/firefox-127.0b8.tar.bz2", +version = "127.0b8" +url = f"https://ftp.mozilla.org/pub/firefox/releases/{version}/linux-x86_64/en-US/firefox-{version}.tar.bz2", sha256 = "240e4da514f8052a5d61a1a2c217c813e55831b8b05bbabdc4494df8979c0ee6", ``` Suggestion importance[1-10]: 8Why: Using a variable for the version number is a significant improvement for maintainability and reduces the risk of errors during updates. This suggestion directly impacts the ease of future modifications. | 8 |
Maintainability |
Add comments to explain the purpose of specific URLs and SHA256 hashes___ **Consider adding a comment above thehttp_archive and dmg_archive definitions to indicate the purpose of these specific URLs and SHA256 hashes. This will help future maintainers understand why these specific versions are being used.** [common/repositories.bzl [51-55]](https://github.com/SeleniumHQ/selenium/pull/14053/files#diff-25d82cd18102fed27d3202000e1f1b3a56a85ad2848236d91989cd30a3952401R51-R55) ```diff +# Firefox Beta version 127.0b8 for Linux http_archive( name = "linux_beta_firefox", url = "https://ftp.mozilla.org/pub/firefox/releases/127.0b8/linux-x86_64/en-US/firefox-127.0b8.tar.bz2", sha256 = "240e4da514f8052a5d61a1a2c217c813e55831b8b05bbabdc4494df8979c0ee6", build_file_content = """ ``` Suggestion importance[1-10]: 7Why: Adding comments for clarity and maintainability is a good practice, especially for version-specific URLs and hashes that might change or be updated frequently. | 7 |
Possible issue |
Verify that the
___
**Ensure that the | 6 |
Best practice |
Ensure the URLs and SHA256 hashes are correct and correspond to the intended files___ **Verify that the new URLs and SHA256 hashes are correct and correspond to the intendedfiles. This ensures that the correct versions are being downloaded and used.** [common/repositories.bzl [53-54]](https://github.com/SeleniumHQ/selenium/pull/14053/files#diff-25d82cd18102fed27d3202000e1f1b3a56a85ad2848236d91989cd30a3952401R53-R54) ```diff url = "https://ftp.mozilla.org/pub/firefox/releases/127.0b8/linux-x86_64/en-US/firefox-127.0b8.tar.bz2", -sha256 = "240e4da514f8052a5d61a1a2c217c813e55831b8b05bbabdc4494df8979c0ee6", +sha256 = "240e4da514f8052a5d61a1a2c217c813e55831b8b05bbabdc4494df8979c0ee6", # Verify this hash ``` Suggestion importance[1-10]: 5Why: While the suggestion to verify URLs and hashes is valid, it is more of a procedural check rather than a code improvement. It doesn't directly impact the code's functionality or maintainability. | 5 |
**Action:** Test / All RBE tests |
**Failed stage:** [Run Bazel](https://github.com/SeleniumHQ/selenium/actions/runs/9508744447/job/26210593729) [❌] |
**Failure summary:**
The action failed due to multiple test failures. The specific reasons for the failures are:test_pen_pointer_properties in py/test/selenium/webdriver/common/w3c_interaction_tests.py failed because the expected event type was pointermove , but pointerenter was received.one element raises if invalid locator in rb/spec/integration/selenium/webdriver/driver_spec.rb failed because the expected InvalidSelectorError was not raised; instead, a JavascriptError was encountered. can set single permissions in rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb failed due to an UnknownError related to a bad inspector message.install and uninstall xpi file and other related tests in rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb failed due to ERROR_CORRUPT_FILE , indicating the file appears to be corrupt. testSelectionSelectBySymbol and testSelectionSelectByWord in java/test/org/openqa/selenium/bidi/input/DefaultKeyboardTest.java failed due to assertion errors where the expected text did not match the actual text. shouldAllowRemoteWebDriverBuilderToUseHasExtensions in java/test/org/openqa/selenium/firefox/RemoteFirefoxDriverTest.java failed due to ERROR_CORRUPT_FILE when attempting to install an add-on. canSetViewportWithDevicePixelRatio in java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextTest.java failed due to an exception indicating the test is marked as not yet implemented but already works. |
Relevant error logs:```yaml 1: ##[group]Operating System 2: Ubuntu ... 975: Package 'php-symfony-debug-bundle' is not installed, so not removed 976: Package 'php-symfony-dependency-injection' is not installed, so not removed 977: Package 'php-symfony-deprecation-contracts' is not installed, so not removed 978: Package 'php-symfony-discord-notifier' is not installed, so not removed 979: Package 'php-symfony-doctrine-bridge' is not installed, so not removed 980: Package 'php-symfony-doctrine-messenger' is not installed, so not removed 981: Package 'php-symfony-dom-crawler' is not installed, so not removed 982: Package 'php-symfony-dotenv' is not installed, so not removed 983: Package 'php-symfony-error-handler' is not installed, so not removed ... 1726: warning: [options] To suppress warnings about obsolete options, use -Xlint:-options. 1727: (00:44:31) [32mINFO: [0mFrom Building external/protobuf~/java/core/liblite_runtime_only.jar (91 source files) [for tool]: 1728: external/protobuf~/java/core/src/main/java/com/google/protobuf/UnsafeUtil.java:293: warning: [removal] AccessController in java.security has been deprecated and marked for removal 1729: AccessController.doPrivileged( 1730: ^ 1731: (00:44:32) [32mAnalyzing:[0m 1692 targets (1268 packages loaded, 50963 targets configured) 1732: [32m[2,965 / 3,987][0m 35 / 195 tests;[0m Copying files; 0s local ... (39 actions, 15 running) 1733: (00:44:33) [32mINFO: [0mFrom Building java/src/org/openqa/selenium/remote/libapi-class.jar (66 source files): 1734: java/src/org/openqa/selenium/remote/ErrorHandler.java:46: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1735: private final ErrorCodes errorCodes; 1736: ^ 1737: java/src/org/openqa/selenium/remote/ErrorHandler.java:60: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1738: this.errorCodes = new ErrorCodes(); 1739: ^ 1740: java/src/org/openqa/selenium/remote/ErrorHandler.java:68: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1741: public ErrorHandler(ErrorCodes codes, boolean includeServerErrors) { 1742: ^ 1743: java/src/org/openqa/selenium/remote/Response.java:97: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1744: ErrorCodes errorCodes = new ErrorCodes(); 1745: ^ 1746: java/src/org/openqa/selenium/remote/Response.java:97: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1747: ErrorCodes errorCodes = new ErrorCodes(); 1748: ^ 1749: java/src/org/openqa/selenium/remote/ProtocolHandshake.java:181: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1750: response.setStatus(ErrorCodes.SUCCESS); 1751: ^ 1752: java/src/org/openqa/selenium/remote/ProtocolHandshake.java:182: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1753: response.setState(ErrorCodes.SUCCESS_STRING); 1754: ^ 1755: java/src/org/openqa/selenium/remote/W3CHandshakeResponse.java:53: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1756: new ErrorCodes().toStatus((String) rawError, Optional.of(tuple.getStatusCode()))); 1757: ^ 1758: java/src/org/openqa/selenium/remote/W3CHandshakeResponse.java:56: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1759: new ErrorCodes().getExceptionType((String) rawError); 1760: ^ 1761: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:44: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1762: private final ErrorCodes errorCodes = new ErrorCodes(); 1763: ^ 1764: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:44: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1765: private final ErrorCodes errorCodes = new ErrorCodes(); 1766: ^ 1767: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:55: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1768: int status = response.getStatus() == ErrorCodes.SUCCESS ? HTTP_OK : HTTP_INTERNAL_ERROR; 1769: ^ 1770: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:101: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1771: response.setStatus(ErrorCodes.UNKNOWN_COMMAND); 1772: ^ 1773: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:103: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1774: response.setStatus(ErrorCodes.UNHANDLED_ERROR); 1775: ^ 1776: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:124: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1777: response.setStatus(ErrorCodes.SUCCESS); 1778: ^ 1779: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:125: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1780: response.setState(errorCodes.toState(ErrorCodes.SUCCESS)); 1781: ^ 1782: java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java:131: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1783: response.setState(errorCodes.toState(ErrorCodes.SUCCESS)); 1784: ^ 1785: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:70: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1786: private final ErrorCodes errorCodes = new ErrorCodes(); 1787: ^ 1788: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:70: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1789: private final ErrorCodes errorCodes = new ErrorCodes(); 1790: ^ 1791: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:93: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1792: response.setStatus(ErrorCodes.UNKNOWN_COMMAND); 1793: ^ 1794: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:98: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1795: response.setStatus(ErrorCodes.UNHANDLED_ERROR); 1796: ^ 1797: java/src/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodec.java:145: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 1798: response.setStatus(ErrorCodes.SUCCESS); ... 1804: (00:44:33) [35mWARNING: [0m/home/runner/work/selenium/selenium/javascript/atoms/BUILD.bazel:351:19: runfiles symlink javascript/atoms/test/click_submit_test.html -> javascript/atoms/test/click_submit_test.html obscured by javascript/atoms/test -> bazel-out/k8-fastbuild/bin/javascript/atoms/test 1805: (00:44:33) [35mWARNING: [0m/home/runner/work/selenium/selenium/javascript/atoms/BUILD.bazel:351:19: runfiles symlink javascript/atoms/test/click_test.html -> javascript/atoms/test/click_test.html obscured by javascript/atoms/test -> bazel-out/k8-fastbuild/bin/javascript/atoms/test 1806: (00:44:33) [35mWARNING: [0m/home/runner/work/selenium/selenium/javascript/atoms/BUILD.bazel:351:19: runfiles symlink javascript/atoms/test/clientrect_test.html -> javascript/atoms/test/clientrect_test.html obscured by javascript/atoms/test -> bazel-out/k8-fastbuild/bin/javascript/atoms/test 1807: (00:44:33) [35mWARNING: [0m/home/runner/work/selenium/selenium/javascript/atoms/BUILD.bazel:351:19: runfiles symlink javascript/atoms/test/color_test.html -> javascript/atoms/test/color_test.html obscured by javascript/atoms/test -> bazel-out/k8-fastbuild/bin/javascript/atoms/test 1808: (00:44:33) [35mWARNING: [0m/home/runner/work/selenium/selenium/javascript/atoms/BUILD.bazel:351:19: runfiles symlink javascript/atoms/test/dom_test.html -> javascript/atoms/test/dom_test.html obscured by javascript/atoms/test -> bazel-out/k8-fastbuild/bin/javascript/atoms/test 1809: (00:44:33) [35mWARNING: [0m/home/runner/work/selenium/selenium/javascript/atoms/BUILD.bazel:351:19: runfiles symlink javascript/atoms/test/drag_test.html -> javascript/atoms/test/drag_test.html obscured by javascript/atoms/test -> bazel-out/k8-fastbuild/bin/javascript/atoms/test 1810: (00:44:33) [35mWARNING: [0m/home/runner/work/selenium/selenium/javascript/atoms/BUILD.bazel:351:19: runfiles symlink javascript/atoms/test/enabled_test.html -> javascript/atoms/test/enabled_test.html obscured by javascript/atoms/test -> bazel-out/k8-fastbuild/bin/javascript/atoms/test 1811: (00:44:33) [35mWARNING: [0m/home/runner/work/selenium/selenium/javascript/atoms/BUILD.bazel:351:19: runfiles symlink javascript/atoms/test/enter_submit_test.html -> javascript/atoms/test/enter_submit_test.html obscured by javascript/atoms/test -> bazel-out/k8-fastbuild/bin/javascript/atoms/test 1812: (00:44:33) [35mWARNING: [0m/home/runner/work/selenium/selenium/javascript/atoms/BUILD.bazel:351:19: runfiles symlink javascript/atoms/test/error_test.html -> javascript/atoms/test/error_test.html obscured by javascript/atoms/test -> bazel-out/k8-fastbuild/bin/javascript/atoms/test ... 1978: See https://github.com/rubyzip/rubyzip for details. The Changelog also 1979: lists other enhancements and bugfixes that have been implemented since 1980: version 2.3.0. 1981: (00:44:37) [32mAnalyzing:[0m 1692 targets (1268 packages loaded, 51450 targets configured) 1982: [32m[5,349 / 6,298][0m 74 / 602 tests;[0m Extracting npm package @graphql-typed-document-node/core@3.1.1_graphql_16.8.1; 0s remote, remote-cache ... (50 actions, 3 running) 1983: (00:44:42) [32mAnalyzing:[0m 1692 targets (1268 packages loaded, 51836 targets configured) 1984: [32m[7,227 / 8,001][0m 75 / 913 tests;[0m Extracting npm package @mui/icons-material@5.15.18_-796748879; 5s remote, remote-cache ... (36 actions, 4 running) 1985: (00:44:48) [32mAnalyzing:[0m 1692 targets (1268 packages loaded, 52015 targets configured) 1986: [32m[7,399 / 8,169][0m 75 / 939 tests;[0m Testing //rb/spec/integration/selenium/webdriver:error-chrome-bidi; 4s remote, remote-cache ... (49 actions, 0 running) 1987: (00:44:54) [32mAnalyzing:[0m 1692 targets (1268 packages loaded, 52292 targets configured) 1988: [32m[7,401 / 8,456][0m 75 / 1045 tests;[0m Testing //rb/spec/integration/selenium/webdriver:error-chrome-bidi; 10s remote, remote-cache ... (50 actions, 0 running) 1989: (00:44:59) [32mAnalyzing:[0m 1692 targets (1268 packages loaded, 52463 targets configured) 1990: [32m[7,401 / 9,032][0m 75 / 1347 tests;[0m Testing //rb/spec/integration/selenium/webdriver:error-chrome-bidi; 15s remote, remote-cache ... (50 actions, 0 running) 1991: (00:45:08) [32mINFO: [0mAnalyzed 1692 targets (1268 packages loaded, 52704 targets configured). 1992: (00:45:09) [32m[7,401 / 9,497][0m 75 / 1692 tests;[0m Testing //rb/spec/integration/selenium/webdriver:error-chrome-bidi; 25s remote, remote-cache ... (50 actions, 0 running) ... 2003: (00:46:12) [32m[7,792 / 9,634][0m 76 / 1692 tests;[0m Testing //rb/spec/integration/selenium/webdriver:select-chrome-bidi; 59s remote, remote-cache ... (50 actions, 8 running) 2004: (00:46:17) [32m[7,818 / 9,642][0m 76 / 1692 tests;[0m Testing //rb/spec/integration/selenium/webdriver:select-chrome-bidi; 64s remote, remote-cache ... (50 actions, 8 running) 2005: (00:46:23) [32m[7,844 / 9,648][0m 76 / 1692 tests;[0m Testing //rb/spec/integration/selenium/webdriver:select-chrome-bidi; 69s remote, remote-cache ... (50 actions, 8 running) 2006: (00:46:28) [32m[7,869 / 9,648][0m 76 / 1692 tests;[0m Testing //rb/spec/integration/selenium/webdriver:select-chrome-bidi; 74s remote, remote-cache ... (50 actions, 10 running) 2007: (00:46:33) [32m[7,895 / 9,648][0m 76 / 1692 tests;[0m Testing //rb/spec/integration/selenium/webdriver:select-chrome-bidi; 79s remote, remote-cache ... (50 actions, 11 running) 2008: (00:46:38) [32m[7,921 / 9,648][0m 76 / 1692 tests;[0m Testing //rb/spec/integration/selenium/webdriver:select-chrome-bidi; 84s remote, remote-cache ... (50 actions, 11 running) 2009: (00:46:43) [32m[7,948 / 9,654][0m 76 / 1692 tests;[0m Testing //rb/spec/integration/selenium/webdriver:select-chrome-bidi; 89s remote, remote-cache ... (50 actions, 11 running) 2010: (00:46:48) [32m[7,967 / 9,680][0m 76 / 1692 tests;[0m Testing //rb/spec/integration/selenium/webdriver:select-chrome-bidi; 94s remote, remote-cache ... (50 actions, 15 running) 2011: (00:46:52) [32mINFO: [0mFrom Building java/test/org/openqa/selenium/remote/ErrorHandlerTest.jar (1 source file) and running annotation processors (AutoServiceProcessor): 2012: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:79: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2013: handler.throwIfResponseFailed(createResponse(ErrorCodes.SUCCESS), 100); 2014: ^ 2015: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:85: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2016: assertThrowsCorrectExceptionType(ErrorCodes.NO_SUCH_WINDOW, NoSuchWindowException.class); 2017: ^ 2018: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:86: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2019: assertThrowsCorrectExceptionType(ErrorCodes.NO_SUCH_FRAME, NoSuchFrameException.class); 2020: ^ 2021: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:87: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2022: assertThrowsCorrectExceptionType(ErrorCodes.NO_SUCH_ELEMENT, NoSuchElementException.class); 2023: ^ 2024: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:88: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2025: assertThrowsCorrectExceptionType(ErrorCodes.UNKNOWN_COMMAND, UnsupportedCommandException.class); 2026: ^ 2027: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:90: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2028: ErrorCodes.METHOD_NOT_ALLOWED, UnsupportedCommandException.class); 2029: ^ 2030: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:92: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2031: ErrorCodes.STALE_ELEMENT_REFERENCE, StaleElementReferenceException.class); 2032: ^ 2033: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:94: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2034: ErrorCodes.INVALID_ELEMENT_STATE, InvalidElementStateException.class); 2035: ^ 2036: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:95: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2037: assertThrowsCorrectExceptionType(ErrorCodes.XPATH_LOOKUP_ERROR, InvalidSelectorException.class); 2038: ^ 2039: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:107: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2040: Response response = createResponse(ErrorCodes.UNHANDLED_ERROR); 2041: ^ 2042: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:120: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2043: createResponse(ErrorCodes.UNHANDLED_ERROR, "boom"), 123)) 2044: ^ 2045: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:133: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2046: createResponse(ErrorCodes.UNHANDLED_ERROR, ImmutableMap.of("message", "boom")), 2047: ^ 2048: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:147: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2049: ErrorCodes.UNHANDLED_ERROR, 2050: ^ 2051: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:167: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2052: ErrorCodes.UNHANDLED_ERROR, 2053: ^ 2054: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:193: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2055: createResponse(ErrorCodes.UNHANDLED_ERROR, toMap(serverError)), 123)) 2056: ^ 2057: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:214: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2058: createResponse(ErrorCodes.UNHANDLED_ERROR, data), 123)) 2059: ^ 2060: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:248: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2061: createResponse(ErrorCodes.UNHANDLED_ERROR, data), 123)) 2062: ^ 2063: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:280: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2064: createResponse(ErrorCodes.UNHANDLED_ERROR, data), 123)) 2065: ^ 2066: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:308: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2067: createResponse(ErrorCodes.UNHANDLED_ERROR, data), 123)) 2068: ^ 2069: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:327: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2070: createResponse(ErrorCodes.UNHANDLED_ERROR, data), 123)) 2071: ^ 2072: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:355: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2073: createResponse(ErrorCodes.UNHANDLED_ERROR, data), 123)) 2074: ^ 2075: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:394: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2076: createResponse(ErrorCodes.UNHANDLED_ERROR, data), 123)) 2077: ^ 2078: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:426: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2079: createResponse(ErrorCodes.UNHANDLED_ERROR, toMap(serverError)), 123)) 2080: ^ 2081: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:435: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2082: exceptions.put(ErrorCodes.NO_SUCH_SESSION, NoSuchSessionException.class); 2083: ^ 2084: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:436: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2085: exceptions.put(ErrorCodes.NO_SUCH_ELEMENT, NoSuchElementException.class); 2086: ^ 2087: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:437: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2088: exceptions.put(ErrorCodes.NO_SUCH_FRAME, NoSuchFrameException.class); 2089: ^ 2090: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:438: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2091: exceptions.put(ErrorCodes.UNKNOWN_COMMAND, UnsupportedCommandException.class); 2092: ^ 2093: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:439: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2094: exceptions.put(ErrorCodes.STALE_ELEMENT_REFERENCE, StaleElementReferenceException.class); 2095: ^ 2096: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:440: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2097: exceptions.put(ErrorCodes.INVALID_ELEMENT_STATE, InvalidElementStateException.class); 2098: ^ 2099: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:441: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2100: exceptions.put(ErrorCodes.UNHANDLED_ERROR, WebDriverException.class); 2101: ^ 2102: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:442: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2103: exceptions.put(ErrorCodes.JAVASCRIPT_ERROR, JavascriptException.class); 2104: ^ 2105: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:443: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2106: exceptions.put(ErrorCodes.XPATH_LOOKUP_ERROR, InvalidSelectorException.class); 2107: ^ 2108: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:444: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2109: exceptions.put(ErrorCodes.TIMEOUT, TimeoutException.class); 2110: ^ 2111: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:445: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2112: exceptions.put(ErrorCodes.NO_SUCH_WINDOW, NoSuchWindowException.class); 2113: ^ 2114: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:446: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2115: exceptions.put(ErrorCodes.INVALID_COOKIE_DOMAIN, InvalidCookieDomainException.class); 2116: ^ 2117: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:447: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2118: exceptions.put(ErrorCodes.UNABLE_TO_SET_COOKIE, UnableToSetCookieException.class); 2119: ^ 2120: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:448: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2121: exceptions.put(ErrorCodes.UNEXPECTED_ALERT_PRESENT, UnhandledAlertException.class); 2122: ^ 2123: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:449: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2124: exceptions.put(ErrorCodes.NO_ALERT_PRESENT, NoAlertPresentException.class); 2125: ^ 2126: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:450: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2127: exceptions.put(ErrorCodes.ASYNC_SCRIPT_TIMEOUT, ScriptTimeoutException.class); 2128: ^ 2129: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:451: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2130: exceptions.put(ErrorCodes.INVALID_SELECTOR_ERROR, InvalidSelectorException.class); 2131: ^ 2132: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:452: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2133: exceptions.put(ErrorCodes.SESSION_NOT_CREATED, SessionNotCreatedException.class); 2134: ^ 2135: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:453: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2136: exceptions.put(ErrorCodes.MOVE_TARGET_OUT_OF_BOUNDS, MoveTargetOutOfBoundsException.class); 2137: ^ 2138: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:454: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2139: exceptions.put(ErrorCodes.INVALID_XPATH_SELECTOR, InvalidSelectorException.class); 2140: ^ 2141: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:455: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2142: exceptions.put(ErrorCodes.INVALID_XPATH_SELECTOR_RETURN_TYPER, InvalidSelectorException.class); 2143: ^ 2144: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:469: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2145: ? ErrorCodes.INVALID_SELECTOR_ERROR 2146: ^ 2147: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:471: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2148: assertThat(new ErrorCodes().toStatusCode(e)).isEqualTo(expected); 2149: ^ 2150: java/test/org/openqa/selenium/remote/ErrorHandlerTest.java:483: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2151: response.setState(new ErrorCodes().toState(status)); 2152: ^ 2153: (00:46:53) [32mINFO: [0mFrom Building java/test/org/openqa/selenium/remote/RemotableByTest.jar (1 source file) and running annotation processors (AutoServiceProcessor): 2154: java/test/org/openqa/selenium/remote/RemotableByTest.java:23: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2155: import static org.openqa.selenium.remote.ErrorCodes.SUCCESS_STRING; 2156: ^ 2157: java/test/org/openqa/selenium/remote/RemotableByTest.java:23: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2158: import static org.openqa.selenium.remote.ErrorCodes.SUCCESS_STRING; 2159: ^ 2160: java/test/org/openqa/selenium/remote/RemotableByTest.java:23: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2161: import static org.openqa.selenium.remote.ErrorCodes.SUCCESS_STRING; 2162: ^ 2163: java/test/org/openqa/selenium/remote/RemotableByTest.java:45: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2164: private final ErrorCodes errorCodes = new ErrorCodes(); 2165: ^ 2166: java/test/org/openqa/selenium/remote/RemotableByTest.java:45: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2167: private final ErrorCodes errorCodes = new ErrorCodes(); 2168: ^ 2169: java/test/org/openqa/selenium/remote/RemotableByTest.java:45: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2170: private final ErrorCodes errorCodes = new ErrorCodes(); 2171: ^ 2172: java/test/org/openqa/selenium/remote/RemotableByTest.java:45: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2173: private final ErrorCodes errorCodes = new ErrorCodes(); 2174: ^ 2175: (00:46:53) [32m[7,986 / 9,708][0m 76 / 1692 tests;[0m Testing //rb/spec/integration/selenium/webdriver:select-chrome-bidi; 99s remote, remote-cache ... (50 actions, 17 running) 2176: (00:46:58) [32mINFO: [0mFrom Building java/test/org/openqa/selenium/remote/libsmall-tests-test-lib.jar (5 source files) and running annotation processors (AutoServiceProcessor): 2177: java/test/org/openqa/selenium/remote/WebDriverFixture.java:170: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2178: response.setStatus(new ErrorCodes().toStatus(state, Optional.of(400))); 2179: ^ 2180: (00:46:58) [32m[8,005 / 9,752][0m 76 / 1692 tests;[0m Testing //rb/spec/integration/selenium/webdriver:select-chrome-bidi; 104s remote, remote-cache ... (50 actions, 24 running) 2181: (00:47:00) [32mINFO: [0mFrom Building java/test/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodecTest.jar (1 source file): 2182: java/test/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodecTest.java:26: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2183: import static org.openqa.selenium.remote.ErrorCodes.METHOD_NOT_ALLOWED; 2184: ^ 2185: java/test/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodecTest.java:55: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2186: assertThat(decoded.getStatus().intValue()).isEqualTo(ErrorCodes.SUCCESS); 2187: ^ 2188: java/test/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodecTest.java:81: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2189: assertThat(decoded.getStatus()).isEqualTo(ErrorCodes.UNHANDLED_ERROR); 2190: ^ 2191: java/test/org/openqa/selenium/remote/codec/w3c/W3CHttpResponseCodecTest.java:107: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 2192: assertThat(decoded.getStatus()).isEqualTo(ErrorCodes.UNHANDLED_ERROR); 2193: ^ 2194: (00:47:03) [32m[8,021 / 9,997][0m 79 / 1692 tests;[0m Testing //rb/spec/integration/selenium/webdriver:select-chrome-bidi; 109s remote, remote-cache ... (50 actions, 36 running) 2195: (00:47:08) [32m[8,039 / 10,031][0m 80 / 1692 tests;[0m Testing //rb/spec/integration/selenium/webdriver:error-chrome-bidi; 114s remote, remote-cache ... (50 actions, 40 running) ... 2214: ^ 2215: java/test/org/openqa/selenium/remote/http/FormEncodedDataTest.java:102: warning: [removal] FormEncodedData in org.openqa.selenium.remote.http has been deprecated and marked for removal 2216: Optional |
merging because v126 fixes issues on trunk
This is an automated pull request to update pinned browsers and drivers
Merge after verify the new browser versions properly passing the tests and no bugs need to be filed