SeleniumHQ / selenium

A browser automation framework and ecosystem.
https://selenium.dev
Apache License 2.0
29.77k stars 8.02k forks source link

[rb] Add `logger` gem as a runtime dependency #14082

Closed Earlopain closed 4 weeks ago

Earlopain commented 4 weeks ago

User description

This is getting the same treatment as the base64 gem, starting with Ruby 3.4. Also see #13454

Closes #14081

I've chosen ~>1.4 as the constraint since that was the minor version available when Ruby 3.0 released (the currently minimum supported ruby version)

Types of changes

Checklist


PR Type

Bug fix, Enhancement


Description


Changes walkthrough 📝

Relevant files
Dependencies
selenium-webdriver.gemspec
Add `logger` gem as a runtime dependency                                 

rb/selenium-webdriver.gemspec
  • Added logger gem as a runtime dependency with version constraint ~>
    1.4.
  • +1/-0     

    💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    codiumai-pr-agent-pro[bot] commented 4 weeks ago

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5] 1, because the PR involves a simple addition of a runtime dependency with a clear version constraint. The change is straightforward and limited to a single line in the gemspec file.
    🧪 Relevant tests No
    ⚡ Possible issues No
    🔒 Security concerns No
    codiumai-pr-agent-pro[bot] commented 4 weeks ago

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Verify compatibility of the new dependency with existing dependencies ___ **Ensure that the logger gem is compatible with the other dependencies in the project by
    running a dependency check or using a tool like bundler-audit to avoid potential
    conflicts.** [rb/selenium-webdriver.gemspec [51]](https://github.com/SeleniumHQ/selenium/pull/14082/files#diff-f7c3979ae889cfb6e1b2386569a8bcd4f45e9a7e03d8c13bad52eb502a240aadR51-R51) ```diff +s.add_runtime_dependency 'logger', ['~> 1.4'] - ```
    Suggestion importance[1-10]: 7 Why: The suggestion to verify compatibility of the new `logger` dependency is important to ensure no conflicts with existing dependencies, which is a good practice in dependency management. However, it does not address any critical or security-related issues directly.
    7
    titusfortner commented 4 weeks ago

    Thanks!