Closed bgermann closed 3 weeks ago
โฑ๏ธ Estimated effort to review [1-5] | 2, because the changes are limited to a specific functionality within a single file and involve a straightforward condition addition. The logic is simple and the impact is localized. |
๐งช Relevant tests | No |
โก Possible issues | Possible Bug: The code does not handle cases other than ARM64 and default x86_64 for nightly builds. If there are other architectures supported in the future, they will default to 'linux-x86_64', which might not be correct. |
๐ Security concerns | No |
Category | Suggestion | Score |
Maintainability |
Use a match statement to improve readability and maintainability when setting the
___
**Consider using a match statement for better readability and maintainability when checking | 7 |
Enhancement |
Add a log statement to provide more visibility into the platform label being set___ **Add a log statement to provide more visibility into which platform label is being set,which can help in debugging.** [rust/src/firefox.rs [569-579]](https://github.com/SeleniumHQ/selenium/pull/14099/files#diff-a223ca8815bf06c61bd96d36c5ebae1789d76dbc4d91ae6aa82d47f6d087f611R569-R579) ```diff if X32.is(arch) { platform_label = "linux-i686"; } else if self.is_nightly(browser_version) { if ARM64.is(arch) { platform_label = "linux64-aarch64"; } else { platform_label = "linux64"; } } else { platform_label = "linux-x86_64"; } +log::info!("Platform label set to: {}", platform_label); ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 5Why: Adding a log statement is a good practice for debugging, but it's a minor enhancement and not critical to the functionality of the code. | 5 |
Looks like this is related to #13793
Looks like this is related to #13793
- How does Selenium manager run on arm64 when it is only compiled for x86?
I compile it myself on for arm64. Generally it runs.
- We need to also be able to get the arm64 driver for it to matter that we are getting the arm64 browser
That is already the case.
I do not think that the failing test (Windows-only: fatal error LNK1181: cannot open input file 'windows.0.52.0.lib') is related to this change as this codepath is not relevant on Windows.
No, that error is not related. In theory, that should be fixed in the trunk branch.
Description
Mozilla provides nightly Firefox releases for ARM64 Linux now. Make selenium-manager aware of them.
Motivation and Context
On ARM64 Linux, selenium-manager downloads binaries for x86_64 even though there are releases for ARM64.
Types of changes
Checklist
PR Type
Enhancement
Description
Changes walkthrough ๐
firefox.rs
Add ARM64 support for nightly Firefox on Linux
rust/src/firefox.rs