Open kool79 opened 2 weeks ago
โฑ๏ธ Estimated effort to review [1-5] | 2 |
๐งช Relevant tests | No |
๐ Security concerns | No |
โก Key issues to review |
Possible Bug: The removal of the workaround for "--remote-allow-origins" assumes that all users will be on Chrome 111 or later. This might not be the case, and could lead to unexpected behavior if older versions of Chrome are used. |
Category | Suggestion | Score |
Possible issue |
Add a null check for the
___
**Consider adding a null check for the | 8 |
Add a check to ensure that the
___
**Consider adding a check to ensure that the | 7 | |
Best practice |
Use
___
**To improve readability and maintainability, consider using | 7 |
Performance |
Automatically filter out any null elements from the
___
**To enhance performance, consider using | 6 |
User description
Workaround was made as part of the fix (3f7f57cf) the bug #11750 which was specific for netty client only. Since #12843 the netty client was removed.
PR Type
enhancement
Description
--remote-allow-origins
argument inChromiumOptions.java
.addArguments
method.Changes walkthrough ๐
ChromiumOptions.java
Remove deprecated workaround and fix Javadoc typo
java/src/org/openqa/selenium/chromium/ChromiumOptions.java
--remote-allow-origins
argument.