Closed selenium-ci closed 2 weeks ago
⏱️ Estimated effort to review [1-5] | 2 |
🧪 Relevant tests | No |
🔒 Security concerns | No |
⚡ Key issues to review | None |
Category | Suggestion | Score |
Maintainability |
Define the version number as a variable and reuse it in the URLs for better maintainability___ **To improve maintainability, consider defining the version number as a variable and reusingit in the URLs. This will make future updates easier and less error-prone.** [common/repositories.bzl [53-76]](https://github.com/SeleniumHQ/selenium/pull/14139/files#diff-25d82cd18102fed27d3202000e1f1b3a56a85ad2848236d91989cd30a3952401R53-R76) ```diff -url = "https://ftp.mozilla.org/pub/firefox/releases/128.0b3/linux-x86_64/en-US/firefox-128.0b3.tar.bz2", -url = "https://ftp.mozilla.org/pub/firefox/releases/128.0b3/mac/en-US/Firefox%20128.0b3.dmg", +version = "128.0b3" +url = f"https://ftp.mozilla.org/pub/firefox/releases/{version}/linux-x86_64/en-US/firefox-{version}.tar.bz2", +url = f"https://ftp.mozilla.org/pub/firefox/releases/{version}/mac/en-US/Firefox%20{version}.dmg", ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 8Why: Using a variable for the version number would significantly simplify future updates and reduce the risk of errors during manual updates. This is a practical improvement for maintainability. | 8 |
Security |
Add a comment or mechanism to verify the integrity of URLs and SHA256 checksums___ **Consider adding a comment or a mechanism to verify the integrity of the new URLs andSHA256 checksums. This will help ensure that the URLs are correct and the files have not been tampered with.** [common/repositories.bzl [53-54]](https://github.com/SeleniumHQ/selenium/pull/14139/files#diff-25d82cd18102fed27d3202000e1f1b3a56a85ad2848236d91989cd30a3952401R53-R54) ```diff +# Ensure the URL and SHA256 checksum are correct and verified url = "https://ftp.mozilla.org/pub/firefox/releases/128.0b3/linux-x86_64/en-US/firefox-128.0b3.tar.bz2", sha256 = "a44bd8e6c0cbdf28e270190f5dcaab0b803103509f556619047990551b7bea2d", ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 7Why: Adding verification for URLs and checksums enhances security, ensuring the integrity and authenticity of the downloaded files. This is a valuable suggestion but not critical as the checksum itself provides a basic level of integrity check. | 7 |
Enhancement |
Add a mechanism to automatically update URLs and SHA256 checksums to reduce manual errors___ **Consider adding a mechanism to automatically update these URLs and SHA256 checksums, suchas a script or a CI/CD pipeline step, to reduce manual errors and streamline the update process.** [common/repositories.bzl [53-76]](https://github.com/SeleniumHQ/selenium/pull/14139/files#diff-25d82cd18102fed27d3202000e1f1b3a56a85ad2848236d91989cd30a3952401R53-R76) ```diff +# Consider automating the update of these URLs and checksums url = "https://ftp.mozilla.org/pub/firefox/releases/128.0b3/linux-x86_64/en-US/firefox-128.0b3.tar.bz2", sha256 = "a44bd8e6c0cbdf28e270190f5dcaab0b803103509f556619047990551b7bea2d", url = "https://ftp.mozilla.org/pub/firefox/releases/128.0b3/mac/en-US/Firefox%20128.0b3.dmg", sha256 = "8941d09bfc01cf0bae0ebd82c93b0a03eeceea374152c4c1d448fd45911311bb", ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 7Why: Automating the update process for URLs and checksums can help minimize manual errors and streamline updates, which is a beneficial enhancement for maintaining the codebase. | 7 |
**Action:** Java / Browser Tests (windows) / Browser Tests (chrome, windows) |
**Failed stage:** [Run Bazel](https://github.com/SeleniumHQ/selenium/actions/runs/9549032217/job/26317825841) [❌] |
**Failed test name:** FederatedCredentialManagementTest |
**Failure summary:**
The action failed because the test FederatedCredentialManagementTest failed. The test failed due to the following reasons: the GetShortPathNameW function. |
Relevant error logs:```yaml 1: ##[group]Operating System 2: Microsoft Windows Server 2022 ... 627: [32m[1,499 / 2,875][0m Copying files; 1s local ... (4 actions, 1 running) 628: [32m[1,940 / 3,168][0m Copying files; 0s local ... (4 actions, 1 running) 629: [32m[2,115 / 3,168][0m Copying files; 1s local ... (4 actions, 1 running) 630: [32mINFO: [0mFrom Building external/contrib_rules_jvm~/java/src/com/github/bazel_contrib/contrib_rules_jvm/junit5/libjunit5-compile-class.jar (19 source files): 631: warning: [options] source value 8 is obsolete and will be removed in a future release 632: warning: [options] target value 8 is obsolete and will be removed in a future release 633: warning: [options] To suppress warnings about obsolete options, use -Xlint:-options. 634: [32mINFO: [0mFrom Building java/src/org/openqa/selenium/remote/libapi-class.jar (66 source files): 635: java\src\org\openqa\selenium\remote\ErrorHandler.java:46: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 636: private final ErrorCodes errorCodes; 637: ^ 638: java\src\org\openqa\selenium\remote\ErrorHandler.java:60: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 639: this.errorCodes = new ErrorCodes(); 640: ^ 641: java\src\org\openqa\selenium\remote\ErrorHandler.java:68: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 642: public ErrorHandler(ErrorCodes codes, boolean includeServerErrors) { 643: ^ 644: java\src\org\openqa\selenium\remote\Response.java:97: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 645: ErrorCodes errorCodes = new ErrorCodes(); 646: ^ 647: java\src\org\openqa\selenium\remote\Response.java:97: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 648: ErrorCodes errorCodes = new ErrorCodes(); 649: ^ 650: java\src\org\openqa\selenium\remote\ProtocolHandshake.java:181: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 651: response.setStatus(ErrorCodes.SUCCESS); 652: ^ 653: java\src\org\openqa\selenium\remote\ProtocolHandshake.java:182: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 654: response.setState(ErrorCodes.SUCCESS_STRING); 655: ^ 656: java\src\org\openqa\selenium\remote\W3CHandshakeResponse.java:53: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 657: new ErrorCodes().toStatus((String) rawError, Optional.of(tuple.getStatusCode()))); 658: ^ 659: java\src\org\openqa\selenium\remote\W3CHandshakeResponse.java:56: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 660: new ErrorCodes().getExceptionType((String) rawError); 661: ^ 662: java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:44: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 663: private final ErrorCodes errorCodes = new ErrorCodes(); 664: ^ 665: java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:44: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 666: private final ErrorCodes errorCodes = new ErrorCodes(); 667: ^ 668: java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:55: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 669: int status = response.getStatus() == ErrorCodes.SUCCESS ? HTTP_OK : HTTP_INTERNAL_ERROR; 670: ^ 671: java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:101: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 672: response.setStatus(ErrorCodes.UNKNOWN_COMMAND); 673: ^ 674: java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:103: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 675: response.setStatus(ErrorCodes.UNHANDLED_ERROR); 676: ^ 677: java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:124: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 678: response.setStatus(ErrorCodes.SUCCESS); 679: ^ 680: java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:125: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 681: response.setState(errorCodes.toState(ErrorCodes.SUCCESS)); 682: ^ 683: java\src\org\openqa\selenium\remote\codec\AbstractHttpResponseCodec.java:131: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 684: response.setState(errorCodes.toState(ErrorCodes.SUCCESS)); 685: ^ 686: java\src\org\openqa\selenium\remote\codec\w3c\W3CHttpResponseCodec.java:70: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 687: private final ErrorCodes errorCodes = new ErrorCodes(); 688: ^ 689: java\src\org\openqa\selenium\remote\codec\w3c\W3CHttpResponseCodec.java:70: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 690: private final ErrorCodes errorCodes = new ErrorCodes(); 691: ^ 692: java\src\org\openqa\selenium\remote\codec\w3c\W3CHttpResponseCodec.java:93: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 693: response.setStatus(ErrorCodes.UNKNOWN_COMMAND); 694: ^ 695: java\src\org\openqa\selenium\remote\codec\w3c\W3CHttpResponseCodec.java:98: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 696: response.setStatus(ErrorCodes.UNHANDLED_ERROR); 697: ^ 698: java\src\org\openqa\selenium\remote\codec\w3c\W3CHttpResponseCodec.java:145: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 699: response.setStatus(ErrorCodes.SUCCESS); 700: ^ 701: [32m[2,381 / 3,168][0m Extracting npm package @mui/icons-material@5.15.18_-796748879; 1s disk-cache ... (4 actions, 1 running) 702: [32m[2,615 / 3,168][0m Extracting npm package @mui/icons-material@5.15.18_-796748879; 2s disk-cache ... (4 actions, 1 running) 703: [32m[2,781 / 3,168][0m Extracting npm package @mui/icons-material@5.15.18_-796748879; 3s disk-cache ... (4 actions, 1 running) 704: [32m[2,925 / 3,168][0m Extracting npm package @apollo/client@3.10.4_-445209715; 0s disk-cache ... (4 actions, 0 running) 705: [32mINFO: [0mFrom Building java/test/org/openqa/selenium/remote/libsmall-tests-test-lib.jar (5 source files) and running annotation processors (AutoServiceProcessor): 706: java\test\org\openqa\selenium\remote\WebDriverFixture.java:170: warning: [removal] ErrorCodes in org.openqa.selenium.remote has been deprecated and marked for removal 707: response.setStatus(new ErrorCodes().toStatus(state, Optional.of(400))); ... 712: C:\Users\RUNNER~1\AppData\Local\Temp\Bazel.runfiles_aurf6b9m\runfiles\rules_python~~python~python_3_8_x86_64-pc-windows-msvc\lib\zipfile.py:1525: UserWarning: Duplicate name: 'grid-ui/' 713: return self._open_to_write(zinfo, force_zip64=force_zip64) 714: [32m[3,168 / 3,173][0m Testing //java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest; 1s disk-cache ... (4 actions, 1 running) 715: [32m[3,168 / 3,173][0m Testing //java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest; 3s disk-cache ... (4 actions, 1 running) 716: [31m[1mFAIL: [0m//java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest (see D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest/test_attempts/attempt_1.log) 717: [31m[1mFAIL: [0m//java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest (see D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest/test_attempts/attempt_2.log) 718: [31m[1mFAIL: [0m//java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest (see D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest/test.log) 719: ==================== Test output for //java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest: 720: ERROR(tools/test/windows/tw.cc:1302) ERROR: src/main/native/windows/process.cc(95): WaitableProcess::Create(D:\_bazel\execroot\_main\bazel-out\x64_windows-fastbuild\bin\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe.runfiles\_main\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe): ERROR: src/main/native/windows/util.cc(292): AsExecutablePathForCreateProcess(D:\_bazel\execroot\_main\bazel-out\x64_windows-fastbuild\bin\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe.runfiles\_main\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe): ERROR: src/main/native/windows/util.cc(262): GetShortPathNameW(\\?\D:\_bazel\execroot\_main\bazel-out\x64_windows-fastbuild\bin\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe.runfiles\_main\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe): cannot shorten the path enough 721: [31m[1mFAILED: [0m//java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest (Summary) 722: ERROR(tools/test/windows/tw.cc:1479) Failed to start test process (arg: D:\_bazel\execroot\_main\bazel-out\x64_windows-fastbuild\bin\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe.runfiles\_main\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe) 723: D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest/test.log 724: ================================================================================ 725: D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest/test_attempts/attempt_1.log 726: ==================== Test output for //java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest: 727: D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest/test_attempts/attempt_2.log 728: [32mINFO: [0mFrom Testing //java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest: 729: ERROR(tools/test/windows/tw.cc:1302) ERROR: src/main/native/windows/process.cc(95): WaitableProcess::Create(D:\_bazel\execroot\_main\bazel-out\x64_windows-fastbuild\bin\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe.runfiles\_main\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe): ERROR: src/main/native/windows/util.cc(292): AsExecutablePathForCreateProcess(D:\_bazel\execroot\_main\bazel-out\x64_windows-fastbuild\bin\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe.runfiles\_main\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe): ERROR: src/main/native/windows/util.cc(262): GetShortPathNameW(\\?\D:\_bazel\execroot\_main\bazel-out\x64_windows-fastbuild\bin\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe.runfiles\_main\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe): cannot shorten the path enough 730: ERROR(tools/test/windows/tw.cc:1479) Failed to start test process (arg: D:\_bazel\execroot\_main\bazel-out\x64_windows-fastbuild\bin\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe.runfiles\_main\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe) 731: ================================================================================ 732: ==================== Test output for //java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest: 733: ERROR(tools/test/windows/tw.cc:1302) ERROR: src/main/native/windows/process.cc(95): WaitableProcess::Create(D:\_bazel\execroot\_main\bazel-out\x64_windows-fastbuild\bin\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe.runfiles\_main\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe): ERROR: src/main/native/windows/util.cc(292): AsExecutablePathForCreateProcess(D:\_bazel\execroot\_main\bazel-out\x64_windows-fastbuild\bin\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe.runfiles\_main\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe): ERROR: src/main/native/windows/util.cc(262): GetShortPathNameW(\\?\D:\_bazel\execroot\_main\bazel-out\x64_windows-fastbuild\bin\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe.runfiles\_main\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe): cannot shorten the path enough 734: ERROR(tools/test/windows/tw.cc:1479) Failed to start test process (arg: D:\_bazel\execroot\_main\bazel-out\x64_windows-fastbuild\bin\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe.runfiles\_main\java\test\org\openqa\selenium\federatedcredentialmanagement\FederatedCredentialManagementTest.exe) 735: ================================================================================ 736: [32m[3,169 / 3,173][0m 1 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/remote:RemoteWebDriverBuilderTest; 4s local, disk-cache ... (4 actions, 3 running) 737: [32m[3,169 / 3,173][0m 1 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/remote:RemoteWebDriverBuilderTest; 7s local, disk-cache ... (4 actions, 3 running) 738: [32m[3,169 / 3,173][0m 1 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/remote:RemoteWebDriverBuilderTest; 8s local, disk-cache ... (4 actions running) 739: [32m[3,169 / 3,173][0m 1 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/remote:RemoteWebDriverBuilderTest; 16s local, disk-cache ... (4 actions running) 740: [32m[3,169 / 3,173][0m 2 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/remote:RemoteWebDriverBuilderTest; 18s local, disk-cache ... (4 actions running) 741: [32m[3,170 / 3,173][0m 2 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest; 16s local, disk-cache ... (3 actions running) 742: [32m[3,170 / 3,173][0m 2 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest; 25s local, disk-cache ... (3 actions running) 743: [32m[3,170 / 3,173][0m 2 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest; 55s local, disk-cache ... (3 actions running) 744: [32m[3,170 / 3,173][0m 3 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest; 87s local, disk-cache ... (3 actions running) 745: [32m[3,171 / 3,173][0m 3 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest; 88s local, disk-cache ... (2 actions running) 746: [32m[3,172 / 3,173][0m 4 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest; 86s local, disk-cache 747: [32m[3,172 / 3,173][0m 4 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest; 98s local, disk-cache 748: [32m[3,172 / 3,173][0m 4 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest; 128s local, disk-cache 749: [32m[3,172 / 3,173][0m 4 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest; 189s local, disk-cache 750: [32m[3,172 / 3,173][0m 4 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest; 249s local, disk-cache 751: [31m[1mFAIL: [0m//java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest (see D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/grid/router/RemoteWebDriverDownloadTest/test_attempts/attempt_1.log) 752: [32m[3,172 / 3,173][0m 4 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest; 300s local, disk-cache 753: [32m[3,172 / 3,173][0m 4 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest; 302s local, disk-cache 754: [32m[3,172 / 3,173][0m 4 / 5 tests, [31m[1m1 failed[0m;[0m Testing //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest; 309s local, disk-cache ... 756: D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/grid/router/RemoteWebDriverDownloadTest/test_attempts/attempt_1.log 757: [32mINFO: [0mFrom Testing //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest: 758: ==================== Test output for //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest: 759: Jun 17, 2024 2:04:28 PM org.openqa.selenium.remote.tracing.opentelemetry.OpenTelemetryTracer createTracer 760: INFO: Using OpenTelemetry for tracing 761: Jun 17, 2024 2:04:28 PM org.openqa.selenium.grid.node.config.NodeOptions getSessionFactories 762: INFO: Detected 4 available processors 763: Jun 17, 2024 2:04:31 PM org.openqa.selenium.manager.SeleniumManager lambda$runCommand$1 764: WARNING: There was an error managing msedgedriver (The process cannot access the file because it is being used by another process. (os error 32)); using driver found in the cache ... 891: at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:591) 892: at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:595) 893: at org.openqa.selenium.remote.RemoteWebDriver.quit(RemoteWebDriver.java:433) 894: at org.openqa.selenium.grid.router.RemoteWebDriverDownloadTest.canDownloadFiles(RemoteWebDriverDownloadTest.java:145) 895: Jun 17, 2024 2:09:14 PM org.openqa.selenium.grid.node.local.LocalNode stopAllSessions 896: INFO: Trying to stop all running sessions before shutting down... 897: ================================================================================ 898: [32mINFO: [0mFound 5 test targets... 899: [32m[3,173 / 3,173][0m 5 / 5 tests, [31m[1m1 failed[0m;[0m checking cached actions 900: [32mINFO: [0mElapsed time: 456.131s, Critical Path: 373.14s 901: [32mINFO: [0m2935 processes: 1770 disk cache hit, 1139 internal, 26 local. 902: [32mINFO: [0mBuild completed, 1 test FAILED, 2935 total actions 903: //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest [0m[32mPASSED[0m in 89.2s 904: //java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest [0m[32mPASSED[0m in 87.9s 905: //java/test/org/openqa/selenium/remote:RemoteWebDriverBuilderTest [0m[32mPASSED[0m in 18.0s 906: //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest [0m[35mFLAKY[0m, failed in 1 out of 2 in 300.4s 907: Stats over 2 runs: max = 300.4s, min = 64.0s, avg = 182.2s, dev = 118.2s 908: D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/grid/router/RemoteWebDriverDownloadTest/test_attempts/attempt_1.log 909: //java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest [0m[31m[1mFAILED[0m in 3 out of 3 in 0.1s 910: Stats over 3 runs: max = 0.1s, min = 0.0s, avg = 0.1s, dev = 0.0s 911: D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest/test.log 912: D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest/test_attempts/attempt_1.log 913: D:/_bazel/execroot/_main/bazel-out/x64_windows-fastbuild/testlogs/java/test/org/openqa/selenium/federatedcredentialmanagement/FederatedCredentialManagementTest/test_attempts/attempt_2.log 914: Executed 5 out of 5 tests: 4 tests pass and [0m[31m[1m1 fails locally[0m. 915: There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are. 916: [0m 917: ##[error]Process completed with exit code 1. ``` |
That Ruby test isn't failing in trunk... rebased and rerunning
This is an automated pull request to update pinned browsers and drivers
Merge after verify the new browser versions properly passing the tests and no bugs need to be filed