Closed selenium-ci closed 1 week ago
โฑ๏ธ Estimated effort to review [1-5] | 2 |
๐งช Relevant tests | No |
๐ Security concerns | No |
โก Key issues to review |
Version Validation: Ensure that the updated versions of Chrome and ChromeDriver are correct and compatible with the existing system. |
Checksum Accuracy: Verify that the provided SHA256 checksums are accurate for the new browser and driver archives. |
Category | Suggestion | Score |
Maintainability |
Use variables for version numbers and URLs to simplify future updates and maintain consistency___ **Consider using variables for the version numbers and URLs to avoid repetition and makefuture updates easier. This will also help in maintaining consistency across different platforms.** [common/repositories.bzl [202-203]](https://github.com/SeleniumHQ/selenium/pull/14155/files#diff-25d82cd18102fed27d3202000e1f1b3a56a85ad2848236d91989cd30a3952401R202-R203) ```diff -url = "https://storage.googleapis.com/chrome-for-testing-public/126.0.6478.62/linux64/chrome-linux64.zip", -sha256 = "6f42045c9134bdd3cfcea03fb54876ad061da998cabd624c92a25ac6811cd737", +version = "126.0.6478.62" +linux_url = f"https://storage.googleapis.com/chrome-for-testing-public/{version}/linux64/chrome-linux64.zip" +sha256 = "6f42045c9134bdd3cfcea03fb54876ad061da998cabd624c92a25ac6811cd737" +url = linux_url, ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 8Why: Using variables for version numbers and URLs would significantly improve maintainability and consistency across multiple entries, which is crucial for large-scale projects. | 8 |
Best practice |
Validate the new URLs and SHA256 hashes to ensure correctness and file integrity___ **Validate the new URLs and SHA256 hashes to ensure they are correct and the files are notcorrupted. This can be done by downloading the files and comparing the hashes.** [common/repositories.bzl [224-225]](https://github.com/SeleniumHQ/selenium/pull/14155/files#diff-25d82cd18102fed27d3202000e1f1b3a56a85ad2848236d91989cd30a3952401R224-R225) ```diff url = "https://storage.googleapis.com/chrome-for-testing-public/126.0.6478.62/mac-x64/chrome-mac-x64.zip", sha256 = "be21f6b9387c6e52c318b60379291959693889e27c3e64111e95135ecffa82ad", +# Ensure the URL and SHA256 hash are correct by validating the downloaded file. ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 7Why: Validating URLs and hashes is a best practice to ensure the integrity and correctness of dependencies, although it's not a direct code change suggestion. | 7 |
Verify that the
___
**Ensure that the | 5 | |
Enhancement |
Add comments to explain the purpose of specific fields for better readability___ **Add a comment explaining the purpose of thestrip_prefix and patch_cmds fields for better code readability and maintainability.** [common/repositories.bzl [226-228]](https://github.com/SeleniumHQ/selenium/pull/14155/files#diff-25d82cd18102fed27d3202000e1f1b3a56a85ad2848236d91989cd30a3952401R226-R228) ```diff +# The strip_prefix field removes the specified prefix from the extracted files. strip_prefix = "chrome-mac-x64", +# The patch_cmds field contains commands to be run after extraction. patch_cmds = [ "mv 'Google Chrome for Testing.app' Chrome.app", ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 6Why: Adding comments improves code readability and maintainability, especially for fields like `strip_prefix` and `patch_cmds` that might not be immediately clear to new developers. | 6 |
**Action:** JavaScript / Browser Tests (firefox) / Browser Tests (firefox) |
**Failed stage:** [Run Bazel](https://github.com/SeleniumHQ/selenium/actions/runs/9574192159/job/26397074677) [โ] |
**Failed test name:** test-bidi-input-test.js-firefox |
**Failure summary:**
The action failed due to multiple test failures, primarily caused by connection issues and unexpected server responses: ECONNREFUSED errors, indicating that the connection to 127.0.0.1:9222 was refused. Unexpected server response: 404 errors, suggesting that the server returned a 404 Not Found status. TimeoutError , indicating that the tests were waiting for elements that were not found within the specified time. |
Relevant error logs:```yaml 1: ##[group]Operating System 2: Ubuntu ... 973: Package 'php-symfony-debug-bundle' is not installed, so not removed 974: Package 'php-symfony-dependency-injection' is not installed, so not removed 975: Package 'php-symfony-deprecation-contracts' is not installed, so not removed 976: Package 'php-symfony-discord-notifier' is not installed, so not removed 977: Package 'php-symfony-doctrine-bridge' is not installed, so not removed 978: Package 'php-symfony-doctrine-messenger' is not installed, so not removed 979: Package 'php-symfony-dom-crawler' is not installed, so not removed 980: Package 'php-symfony-dotenv' is not installed, so not removed 981: Package 'php-symfony-error-handler' is not installed, so not removed ... 1921: Setting up fonts-terminus-otb (4.48-3.1) ... 1922: Processing triggers for install-info (6.8-4build1) ... 1923: Processing triggers for mailcap (3.70+nmu1ubuntu1) ... 1924: Processing triggers for fontconfig (2.13.1-4.2ubuntu5) ... 1925: Processing triggers for hicolor-icon-theme (0.17-2) ... 1926: Processing triggers for libc-bin (2.35-0ubuntu3.7) ... 1927: Processing triggers for man-db (2.10.2-1) ... 1928: Processing triggers for menu (2.1.47ubuntu4) ... 1929: /usr/share/menu/monodoc-http: 1: Syntax error: word unexpected (expecting ")") 1930: /usr/share/menu/procps: 1: Syntax error: word unexpected (expecting ")") 1931: /usr/share/menu/google-chrome.menu: 1: Syntax error: word unexpected (expecting ")") 1932: /usr/share/menu/dash: 1: Syntax error: word unexpected (expecting ")") 1933: /usr/share/menu/tcl8.6: 1: Syntax error: word unexpected (expecting ")") 1934: /usr/share/menu/microsoft-edge.menu: 1: Syntax error: word unexpected (expecting ")") 1935: /usr/share/menu/telnet: 1: Syntax error: word unexpected (expecting ")") 1936: /usr/share/menu/psmisc: 1: Syntax error: word unexpected (expecting ")") 1937: /usr/share/menu/bash: 1: Syntax error: word unexpected (expecting ")") 1938: /usr/share/menu/tk8.6: 1: Syntax error: word unexpected (expecting ")") 1939: /usr/share/menu/bc: 1: Syntax error: word unexpected (expecting ")") 1940: NEEDRESTART-VER: 3.5 1941: NEEDRESTART-KCUR: 6.5.0-1021-azure 1942: NEEDRESTART-KEXP: 6.5.0-1021-azure 1943: NEEDRESTART-KSTA: 1 1944: Warning: Failed to open file(/usr/share/fluxbox/nls/C.UTF-8/fluxbox.cat) ... 2043: [31m[1mFAIL: [0m//javascript/node/selenium-webdriver:test-bidi-input-test.js-firefox (see /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/test-bidi-input-test.js-firefox/test_attempts/attempt_1.log) 2044: [32m[3,860 / 3,909][0m 6 / 55 tests;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 111s disk-cache, local ... (4 actions running) 2045: [32m[3,860 / 3,909][0m 6 / 55 tests;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 124s disk-cache, local ... (4 actions running) 2046: [31m[1mFAIL: [0m//javascript/node/selenium-webdriver:test-bidi-storage-test.js-firefox (see /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/test-bidi-storage-test.js-firefox/test.log) 2047: ==================== Test output for //javascript/node/selenium-webdriver:test-bidi-storage-test.js-firefox: 2048: [INFO] Running tests against [firefox] 2049: [firefox] 2050: BiDi Storage 2051: [31m[1mFAILED: [0m//javascript/node/selenium-webdriver:test-bidi-storage-test.js-firefox (Summary) ... 2057: [32mINFO: [0mFrom Testing //javascript/node/selenium-webdriver:test-bidi-storage-test.js-firefox: 2058: 1) can add cookie 2059: 2) can add and get cookie with all parameters 2060: 3) can get all cookies 2061: - can delete all cookies 2062: - can delete cookie by name 2063: 1 passing (49s) 2064: 3 pending 2065: 3 failing 2066: 1) [firefox] 2067: BiDi Storage 2068: can add cookie: 2069: Uncaught Error: Unexpected server response: 404 ... 2075: at Socket.emit (node:events:514:28) 2076: at addChunk (node:internal/streams/readable:324:12) 2077: at readableAddChunk (node:internal/streams/readable:297:9) 2078: at Readable.push (node:internal/streams/readable:234:10) 2079: at TCP.onStreamRead (node:internal/stream_base_commons:190:23) 2080: 2) [firefox] 2081: BiDi Storage 2082: can add and get cookie with all parameters: 2083: Uncaught Error: Unexpected server response: 404 ... 2089: at Socket.emit (node:events:514:28) 2090: at addChunk (node:internal/streams/readable:324:12) 2091: at readableAddChunk (node:internal/streams/readable:297:9) 2092: at Readable.push (node:internal/streams/readable:234:10) 2093: at TCP.onStreamRead (node:internal/stream_base_commons:190:23) 2094: 3) [firefox] 2095: BiDi Storage 2096: can get all cookies: 2097: Uncaught Error: connect ECONNREFUSED 127.0.0.1:9222 ... 2105: - can get cookie in default user context 2106: 2) can add cookie 2107: 3) can add and get cookie with all parameters 2108: โ can get all cookies (218ms) 2109: - can delete all cookies 2110: - can delete cookie by name 2111: 1 passing (34s) 2112: 3 pending 2113: 3 failing 2114: 1) [firefox] 2115: BiDi Storage 2116: can get cookie by name: 2117: Uncaught Error: Unexpected server response: 404 ... 2123: at Socket.emit (node:events:514:28) 2124: at addChunk (node:internal/streams/readable:324:12) 2125: at readableAddChunk (node:internal/streams/readable:297:9) 2126: at Readable.push (node:internal/streams/readable:234:10) 2127: at TCP.onStreamRead (node:internal/stream_base_commons:190:23) 2128: 2) [firefox] 2129: BiDi Storage 2130: can add cookie: 2131: Uncaught Error: Unexpected server response: 404 ... 2137: at Socket.emit (node:events:514:28) 2138: at addChunk (node:internal/streams/readable:324:12) 2139: at readableAddChunk (node:internal/streams/readable:297:9) 2140: at Readable.push (node:internal/streams/readable:234:10) 2141: at TCP.onStreamRead (node:internal/stream_base_commons:190:23) 2142: 3) [firefox] 2143: BiDi Storage 2144: can add and get cookie with all parameters: 2145: Uncaught Error: Unexpected server response: 404 ... 2162: - can get cookie in default user context 2163: 2) can add cookie 2164: 3) can add and get cookie with all parameters 2165: 4) can get all cookies 2166: - can delete all cookies 2167: - can delete cookie by name 2168: 0 passing (39s) 2169: 3 pending 2170: 4 failing 2171: 1) [firefox] 2172: BiDi Storage 2173: can get cookie by name: 2174: Uncaught Error: connect ECONNREFUSED 127.0.0.1:9222 2175: at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1495:16) 2176: 2) [firefox] 2177: BiDi Storage 2178: can add cookie: 2179: Uncaught Error: connect ECONNREFUSED 127.0.0.1:9222 2180: at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1495:16) 2181: 3) [firefox] 2182: BiDi Storage 2183: can add and get cookie with all parameters: 2184: Uncaught Error: Unexpected server response: 404 ... 2190: at Socket.emit (node:events:514:28) 2191: at addChunk (node:internal/streams/readable:324:12) 2192: at readableAddChunk (node:internal/streams/readable:297:9) 2193: at Readable.push (node:internal/streams/readable:234:10) 2194: at TCP.onStreamRead (node:internal/stream_base_commons:190:23) 2195: 4) [firefox] 2196: BiDi Storage 2197: can get all cookies: 2198: Uncaught Error: connect ECONNREFUSED 127.0.0.1:9222 2199: at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1495:16) 2200: ================================================================================ 2201: [32m[3,871 / 3,909][0m 17 / 55 tests, [31m[1m1 failed[0m;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 126s disk-cache, local ... (4 actions running) 2202: [32m[3,871 / 3,909][0m 17 / 55 tests, [31m[1m1 failed[0m;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 136s disk-cache, local ... (4 actions running) 2203: [32m[3,871 / 3,909][0m 17 / 55 tests, [31m[1m1 failed[0m;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 147s disk-cache, local ... (4 actions running) 2204: [31m[1mFAIL: [0m//javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox (see /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/test-firefox-options-test.js-firefox/test_attempts/attempt_1.log) 2205: [32m[3,871 / 3,909][0m 17 / 55 tests, [31m[1m1 failed[0m;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 148s disk-cache, local ... (4 actions running) 2206: [32m[3,871 / 3,909][0m 17 / 55 tests, [31m[1m1 failed[0m;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 166s disk-cache, local ... (4 actions running) 2207: [32m[3,871 / 3,909][0m 17 / 55 tests, [31m[1m1 failed[0m;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 185s disk-cache, local ... (4 actions running) 2208: [31m[1mFAIL: [0m//javascript/node/selenium-webdriver:test-bidi-locate-nodes-test.js-firefox (see /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/test-bidi-locate-nodes-test.js-firefox/test_attempts/attempt_1.log) 2209: [32m[3,871 / 3,909][0m 17 / 55 tests, [31m[1m1 failed[0m;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 186s disk-cache, local ... (4 actions running) 2210: [32m[3,871 / 3,909][0m 17 / 55 tests, [31m[1m1 failed[0m;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 220s disk-cache, local ... (4 actions running) 2211: [31m[1mFAIL: [0m//javascript/node/selenium-webdriver:test-bidi-script-test.js-firefox (see /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/test-bidi-script-test.js-firefox/test_attempts/attempt_1.log) 2212: [32m[3,871 / 3,909][0m 17 / 55 tests, [31m[1m1 failed[0m;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 221s disk-cache, local ... (4 actions running) 2213: [32m[3,871 / 3,909][0m 17 / 55 tests, [31m[1m1 failed[0m;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 226s disk-cache, local ... (4 actions running) 2214: [32m[3,871 / 3,909][0m 17 / 55 tests, [31m[1m1 failed[0m;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 235s disk-cache, local ... (4 actions running) 2215: [31m[1mFAIL: [0m//javascript/node/selenium-webdriver:test-bidi-input-test.js-firefox (see /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/test-bidi-input-test.js-firefox/test_attempts/attempt_2.log) 2216: [32m[3,871 / 3,909][0m 17 / 55 tests, [31m[1m1 failed[0m;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 236s disk-cache, local ... (4 actions running) 2217: [32m[3,871 / 3,909][0m 17 / 55 tests, [31m[1m1 failed[0m;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 239s disk-cache, local ... (4 actions running) 2218: [31m[1mFAIL: [0m//javascript/node/selenium-webdriver:test-bidi-locate-nodes-test.js-firefox (see /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/test-bidi-locate-nodes-test.js-firefox/test_attempts/attempt_2.log) 2219: [32m[3,871 / 3,909][0m 17 / 55 tests, [31m[1m1 failed[0m;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 240s disk-cache, local ... (4 actions running) 2220: [32m[3,871 / 3,909][0m 17 / 55 tests, [31m[1m1 failed[0m;[0m Testing //javascript/node/selenium-webdriver:test-firefox-options-test.js-firefox; 274s disk-cache, local ... (4 actions running) 2221: [31m[1mFAIL: [0m//javascript/node/selenium-webdriver:test-bidi-locate-nodes-test.js-firefox (see /home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/testlogs/javascript/node/selenium-webdriver/test-bidi-locate-nodes-test.js-firefox/test.log) 2222: [31m[1mFAILED: [0m//javascript/node/selenium-webdriver:test-bidi-locate-nodes-test.js-firefox (Summary) ... 2234: - can locate node with inner test locator 2235: - can locate node with max node count 2236: - can locate node with given start nodes 2237: 4) can locate nodes in a given sandbox 2238: 5) can find element 2239: 6) can find elements 2240: 0 passing (59s) 2241: 4 pending 2242: 6 failing 2243: 1) [firefox] 2244: Locate Nodes 2245: can locate nodes: 2246: Uncaught Error: connect ECONNREFUSED 127.0.0.1:9222 2247: at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1495:16) 2248: 2) [firefox] 2249: Locate Nodes 2250: can locate node: 2251: Uncaught Error: Unexpected server response: 404 ... 2257: at Socket.emit (node:events:514:28) 2258: at addChunk (node:internal/streams/readable:324:12) 2259: at readableAddChunk (node:internal/streams/readable:297:9) 2260: at Readable.push (node:internal/streams/readable:234:10) 2261: at TCP.onStreamRead (node:internal/stream_base_commons:190:23) 2262: 3) [firefox] 2263: Locate Nodes 2264: can locate node with css locator: 2265: Uncaught Error: connect ECONNREFUSED 127.0.0.1:9222 2266: at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1495:16) 2267: 4) [firefox] 2268: Locate Nodes 2269: can locate nodes in a given sandbox: 2270: Uncaught Error: Unexpected server response: 404 ... 2276: at Socket.emit (node:events:514:28) 2277: at addChunk (node:internal/streams/readable:324:12) 2278: at readableAddChunk (node:internal/streams/readable:297:9) 2279: at Readable.push (node:internal/streams/readable:234:10) 2280: at TCP.onStreamRead (node:internal/stream_base_commons:190:23) 2281: 5) [firefox] 2282: Locate Nodes 2283: can find element: 2284: Uncaught Error: Unexpected server response: 404 ... 2290: at Socket.emit (node:events:514:28) 2291: at addChunk (node:internal/streams/readable:324:12) 2292: at readableAddChunk (node:internal/streams/readable:297:9) 2293: at Readable.push (node:internal/streams/readable:234:10) 2294: at TCP.onStreamRead (node:internal/stream_base_commons:190:23) 2295: 6) [firefox] 2296: Locate Nodes 2297: can find elements: 2298: Uncaught Error: Unexpected server response: 404 ... 2318: - can locate node with inner test locator 2319: - can locate node with max node count 2320: - can locate node with given start nodes 2321: 4) can locate nodes in a given sandbox 2322: 5) can find element 2323: โ can find elements (552ms) 2324: 1 passing (53s) 2325: 4 pending 2326: 5 failing 2327: 1) [firefox] 2328: Locate Nodes 2329: can locate nodes: 2330: Uncaught Error: Unexpected server response: 404 ... 2336: at Socket.emit (node:events:514:28) 2337: at addChunk (node:internal/streams/readable:324:12) 2338: at readableAddChunk (node:internal/streams/readable:297:9) 2339: at Readable.push (node:internal/streams/readable:234:10) 2340: at TCP.onStreamRead (node:internal/stream_base_commons:190:23) 2341: 2) [firefox] 2342: Locate Nodes 2343: can locate node: 2344: Uncaught Error: Unexpected server response: 404 ... 2350: at Socket.emit (node:events:514:28) 2351: at addChunk (node:internal/streams/readable:324:12) 2352: at readableAddChunk (node:internal/streams/readable:297:9) 2353: at Readable.push (node:internal/streams/readable:234:10) 2354: at TCP.onStreamRead (node:internal/stream_base_commons:190:23) 2355: 3) [firefox] 2356: Locate Nodes 2357: can locate node with css locator: 2358: Uncaught Error: Unexpected server response: 404 ... 2364: at Socket.emit (node:events:514:28) 2365: at addChunk (node:internal/streams/readable:324:12) 2366: at readableAddChunk (node:internal/streams/readable:297:9) 2367: at Readable.push (node:internal/streams/readable:234:10) 2368: at TCP.onStreamRead (node:internal/stream_base_commons:190:23) 2369: 4) [firefox] 2370: Locate Nodes 2371: can locate nodes in a given sandbox: 2372: Error: Pass in SerializationOptions object. Received: sandbox 2373: at BrowsingContext.locateNodes (/home/runner/.bazel/execroot/_main/bazel-out/k8-fastbuild/bin/javascript/node/selenium-webdriver/bidi/browsingContext.js:524:13) 2374: at Context. |
User description
This is an automated pull request to update pinned browsers and drivers
Merge after verify the new browser versions properly passing the tests and no bugs need to be filed
PR Type
enhancement
Description
common/repositories.bzl
file.Changes walkthrough ๐
repositories.bzl
Update Chrome and ChromeDriver versions and checksums
common/repositories.bzl
Mac.