Update announcement-banner.html

digitalvoice-nz commented 3 months ago

User description

Change banner to reflect registrations now that CFP has closed

Thanks for contributing to the Selenium site and documentation! A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines. Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Updated banner now that CFP is closed and registrations are open for Selenium Conf

Motivation and Context

CFP is no longer relevant for the conference

Types of changes

[ x ] Change to the site (I have double-checked the Netlify deployment, and my changes look good)
[ ] Code example added (and I also added the example to all translated languages)
[ ] Improved translation
[ ] Added new translation (and I also added a notice to each document missing translation)

Checklist

[ x ] I have read the contributing document.
[ x ] I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Enhancement

Description

Updated the announcement banner on the Selenium website to reflect the new phase of the conference:
- Changed the banner text to announce that registrations for Selenium Conf 2024 are now open.
- Updated the link to direct attendees to the registration page.

Changes walkthrough 📝

Relevant files

Enhancement

announcement-banner.html

Update Announcement Banner for Selenium Conf 2024

website_and_docs/layouts/partials/announcement-banner.html

Updated the announcement banner text from a call for proposals to
registration opening for Selenium Conf 2024.

Changed the link to direct users to the registration page instead of
the call for proposals page.

+2/-2

💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

netlify[bot] commented 3 months ago

Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name	Link
Latest commit	b9f314c89917046daf0b85ee5ebd54c2e621acb7

codiumai-pr-agent-pro[bot] commented 3 months ago

PR Description updated to latest commit (https://github.com/SeleniumHQ/seleniumhq.github.io/commit/b9f314c89917046daf0b85ee5ebd54c2e621acb7)

[ ] Copy walkthrough table to "Files Changed" Tab

codiumai-pr-agent-pro[bot] commented 3 months ago

PR Review 🔍

⏱️ Estimated effort to review [1-5]	1, because the PR involves a simple text change in an HTML file, which is straightforward and does not require deep code review or understanding of complex logic.
🧪 Relevant tests	No
⚡ Possible issues	No
🔒 Security concerns	No

codiumai-pr-agent-pro[bot] commented 3 months ago

PR Code Suggestions ✨

Category	Suggestion	Score
Security	Add `rel="noopener noreferrer"` to the anchor tag to enhance security ___ It is recommended to use `rel="noopener noreferrer"` in the anchor tag to improve security. This prevents the new page from being able to access the window object of the page that opened it, which can protect against certain types of attacks such as phishing. [website_and_docs/layouts/partials/announcement-banner.html [10]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1727/files#diff-25a772fd1c03cf992c9ac86b7d52f1aa63d362c3bd881d87fefca51451ac3f15R10-R10) ```diff - Register now! + Register now! ``` Suggestion importance[1-10]: 8 Why: Adding `rel="noopener noreferrer"` enhances security by preventing the newly opened page from accessing the window object of the opening page, which is a significant security improvement.	8
Accessibility	Add `aria-label` to the anchor tag to improve accessibility for screen readers ___ Consider using `aria-label` on the anchor tag to improve accessibility. This provides a text alternative that describes the purpose of the link, which is beneficial for screen reader users. [website_and_docs/layouts/partials/announcement-banner.html [10]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1727/files#diff-25a772fd1c03cf992c9ac86b7d52f1aa63d362c3bd881d87fefca51451ac3f15R10-R10) ```diff - Register now! + Register now! ``` Suggestion importance[1-10]: 7 Why: Adding `aria-label` improves accessibility for screen reader users by providing a clear description of the link's purpose, which is a good practice for web accessibility.	7
Enhancement	Improve hyperlink visibility with contrasting color and underline ___ To enhance the visual accessibility, consider adding a contrasting color or underline to the hyperlink to make it stand out more prominently against the background. [website_and_docs/layouts/partials/announcement-banner.html [10]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1727/files#diff-25a772fd1c03cf992c9ac86b7d52f1aa63d362c3bd881d87fefca51451ac3f15R10-R10) ```diff - Register now! + Register now! ``` Suggestion importance[1-10]: 6 Why: Improving hyperlink visibility with contrasting color and underline can significantly enhance visual accessibility, making it easier for users to identify clickable links.	6
Maintainability	Standardize the use of double quotes for HTML attribute values ___ Ensure consistent HTML attribute quoting by using double quotes around all attribute values. This improves the readability and maintainability of the code. [website_and_docs/layouts/partials/announcement-banner.html [10]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1727/files#diff-25a772fd1c03cf992c9ac86b7d52f1aa63d362c3bd881d87fefca51451ac3f15R10-R10) ```diff - Register now! + Register now! ``` Suggestion importance[1-10]: 5 Why: Standardizing the use of double quotes for HTML attributes enhances code readability and maintainability, although it's a relatively minor improvement.	5

SeleniumHQ / seleniumhq.github.io