SeleniumHQ / seleniumhq.github.io

Official Selenium website and documentation
https://selenium.dev
Apache License 2.0
1.07k stars 1.27k forks source link

Post for Multi-Arch Images via Docker Selenium #1736

Closed VietND96 closed 3 months ago

VietND96 commented 3 months ago

User description

Thanks for contributing to the Selenium site and documentation! A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines. Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

Checklist


PR Type

documentation


Description


Changes walkthrough ๐Ÿ“

Relevant files
Documentation
multi-arch-images-via-docker-selenium.md
New blog post on Multi-Arch Images for Selenium Grid Server

website_and_docs/content/blog/2024/multi-arch-images-via-docker-selenium.md
  • Added a new blog post announcing the availability of Multi-Arch Images
    for Selenium Grid Server.
  • Included details on supported architectures and browser binaries.
  • Provided instructions on building, testing, and distributing
    multi-arch images.
  • +92/-0   

    ๐Ÿ’ก PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    netlify[bot] commented 3 months ago

    Deploy Preview for selenium-dev ready!

    Name Link
    Latest commit e9c628810e9e7a589bad50c3d7464f2118feb5e6
    Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/66504cab0caadc000805e56f
    Deploy Preview https://deploy-preview-1736--selenium-dev.netlify.app
    Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    codiumai-pr-agent-pro[bot] commented 3 months ago

    PR Review ๐Ÿ”

    โฑ๏ธ Estimated effort to review [1-5] 2, because the PR is primarily a documentation update with a new blog post. The content is straightforward and doesn't involve complex code changes, making it relatively easy to review.
    ๐Ÿงช Relevant tests No
    โšก Possible issues No
    ๐Ÿ”’ Security concerns No
    codiumai-pr-agent-pro[bot] commented 3 months ago

    PR Code Suggestions โœจ

    CategorySuggestion                                                                                                                                    Score
    Grammar
    Correct the grammar in the introductory sentence for better clarity ___ **The sentence "This blog post to announce the visibility of Multi-Arch Images for Selenium
    Grid Server on official Selenium Docker Hub registry." is grammatically incorrect. It
    should be rephrased for better clarity.** [website_and_docs/content/blog/2024/multi-arch-images-via-docker-selenium.md [9]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1736/files#diff-254f89b0e64df9941a8064e4139a7ca7dcb51ddd5573b0cdec5ac90613dbd83fR9-R9) ```diff -This blog post to announce the visibility of Multi-Arch Images for Selenium Grid Server on official Selenium Docker Hub registry. +This blog post announces the availability of Multi-Arch Images for Selenium Grid Server on the official Selenium Docker Hub registry. ```
    Suggestion importance[1-10]: 8 Why: The suggested correction improves the grammatical structure of the sentence, enhancing the clarity and professionalism of the blog post.
    8
    Correct the grammar in the sentence describing experimental Docker container images ___ **The phrase "For experimental Docker container images, which is able to run on platforms
    such as the Apple M-series or Raspberry Pi," should be rephrased to "For experimental
    Docker container images that are able to run on platforms such as the Apple M-series or
    Raspberry Pi," for grammatical correctness.** [website_and_docs/content/blog/2024/multi-arch-images-via-docker-selenium.md [17]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1736/files#diff-254f89b0e64df9941a8064e4139a7ca7dcb51ddd5573b0cdec5ac90613dbd83fR17-R17) ```diff -For experimental Docker container images, which is able to run on platforms such as the Apple M-series or Raspberry Pi, +For experimental Docker container images that are able to run on platforms such as the Apple M-series or Raspberry Pi, ```
    Suggestion importance[1-10]: 7 Why: The suggestion correctly identifies and fixes a grammatical error, improving the readability of the sentence.
    7
    Correct the grammar in the sentence about Firefox versions for ARM64 and AMD64 ___ **The phrase "the Firefox version in ARM64 image will be different with the AMD64 until the
    stable release is available." should be rephrased to "the Firefox version in the ARM64
    image will be different from the AMD64 version until the stable release is available." for
    grammatical correctness.** [website_and_docs/content/blog/2024/multi-arch-images-via-docker-selenium.md [57]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1736/files#diff-254f89b0e64df9941a8064e4139a7ca7dcb51ddd5573b0cdec5ac90613dbd83fR57-R57) ```diff -The Firefox version in ARM64 image will be different with the AMD64 until the stable release is available. +The Firefox version in the ARM64 image will be different from the AMD64 version until the stable release is available. ```
    Suggestion importance[1-10]: 7 Why: The suggestion improves grammatical accuracy and clarity in describing the differences between Firefox versions on different architectures.
    7
    Readability
    Rephrase the sentence for better readability and clarity ___ **The sentence "We also would like to share something that has been done to keep the
    multi-arch images can be built, tested, and distributed seamlessly." is awkwardly phrased.
    It should be rephrased for better readability.** [website_and_docs/content/blog/2024/multi-arch-images-via-docker-selenium.md [72]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1736/files#diff-254f89b0e64df9941a8064e4139a7ca7dcb51ddd5573b0cdec5ac90613dbd83fR72-R72) ```diff -We also would like to share something that has been done to keep the multi-arch images can be built, tested, and distributed seamlessly. +We would also like to share what has been done to ensure that the multi-arch images can be built, tested, and distributed seamlessly. ```
    Suggestion importance[1-10]: 7 Why: The suggested rephrasing resolves an awkward sentence structure, making the information more accessible and easier to understand.
    7