Closed aguspe closed 3 months ago
Visit the deploys page to approve it
Name | Link |
---|---|
Latest commit | a18c26c78886b1408f6a10de16ce6ab1b91dd015 |
β±οΈ Estimated effort to review [1-5] | 2, because the PR involves adding new test cases and updating documentation, which are generally straightforward to review. The changes are well-documented and localized to specific functionalities. |
π§ͺ Relevant tests | Yes |
β‘ Possible issues | Possible Bug: The `permission` method in `edge_spec.rb` uses an asynchronous script to query permissions but does not handle the asynchronous nature in the test assertions. This might lead to flaky tests if the permissions state is not retrieved in time. |
Hardcoded Sleep: The test 'gets the browser logs' uses `sleep 1` which might lead to non-deterministic behavior and could fail if the page takes longer to load. Consider using explicit waits to ensure the page and logs are fully loaded. | |
π Security concerns | No |
Category | Suggestion | Score |
Best practice |
Use a
___
**To avoid repeatedly initializing the | 8 |
Add an
___
**Ensure the | 8 | |
Performance |
Replace
___
**Replace the | 7 |
Possible issue |
Add error handling for the
___
**Add error handling for the | 6 |
User description
Description
This PR adds extra tests to the edge spec file to add examples of special features in the browser, this PR is similar to #1711 and the related PRs
Motivation and Context
Is important that all of the users and community member have access to examples so they can easily start automating and working with Selenium
Types of changes
Checklist
PR Type
Tests, Documentation
Description
permission
to check permissions in the Edge browser.edge_spec.rb
.Changes walkthrough π
edge_spec.rb
Add tests for special features in Edge browser using Ruby
examples/ruby/spec/browsers/edge_spec.rb
permissions.
permission
to check permissions.edge.en.md
Update Ruby code examples links in Edge documentation (EN)
website_and_docs/content/documentation/webdriver/browsers/edge.en.md
edge_spec.rb
.edge.ja.md
Update Ruby code examples links in Edge documentation (JA)
website_and_docs/content/documentation/webdriver/browsers/edge.ja.md
edge_spec.rb
.edge.pt-br.md
Update Ruby code examples links in Edge documentation (PT-BR)
website_and_docs/content/documentation/webdriver/browsers/edge.pt-br.md
edge_spec.rb
.edge.zh-cn.md
Update Ruby code examples links in Edge documentation (ZH-CN)
website_and_docs/content/documentation/webdriver/browsers/edge.zh-cn.md
edge_spec.rb
.