Closed aguspe closed 2 months ago
Visit the deploys page to approve it
Name | Link |
---|---|
Latest commit | 6257dccbd2865a88739076c1f4e59c76da0a4e9d |
โฑ๏ธ Estimated effort to review [1-5] | 2, because the PR primarily involves updates to test cases and documentation for Internet Explorer in Ruby. The changes are straightforward and well-documented, making the review process less time-consuming. |
๐งช Relevant tests | Yes |
โก Possible issues | No |
๐ Security concerns | No |
Category | Suggestion | Score |
Possible issue |
Verify that the
___
**Ensure that the | 7 |
Verify the correctness of
___
**Ensure that the | 7 | |
Best practice |
Use a
___
**To ensure that the WebDriver instance is properly cleaned up even if an exception occurs, | 7 |
Use a
___
**To ensure that the WebDriver instance is properly cleaned up even if an exception occurs, | 7 | |
Use a
___
**To ensure that the WebDriver instance is properly cleaned up even if an exception occurs, | 7 | |
Use a
___
**To ensure that the WebDriver instance is properly cleaned up even if an exception occurs, | 7 | |
Add a note about version compatibility for the Ruby code examples___ **Consider adding a note or warning if the Ruby code examples require specific versions ofthe Selenium WebDriver or Internet Explorer driver. This can help users avoid compatibility issues.** [website_and_docs/content/documentation/webdriver/browsers/internet_explorer.en.md [117]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1748/files#diff-b887e55fa380db36be93803cc07213e0bfc1b22d72bd64e9716799c59f9970ecR117-R117) ```diff {{< gh-codeblock path="/examples/ruby/spec/browsers/internet_explorer_spec.rb#L22-L24" >}} +{{< note >}} Ensure you are using a compatible version of Selenium WebDriver and Internet Explorer driver. {{< /note >}} ``` Suggestion importance[1-10]: 6Why: Including version compatibility notes is crucial for preventing user confusion and compatibility issues, which enhances the documentation's utility and prevents potential errors during implementation. | 6 | |
Ensure consistent formatting of
___
**Ensure consistency in the formatting of the | 5 | |
Enhancement |
Add context or description around the
___
**Add a brief description or context around the | 6 |
Add context or description around
___
**Add a brief description or context around the | 6 |
@harsha509 I saw some window tests failing should I skip the IE examples I added? It's a bit difficult for me locally to test IE due to my computer being a mac
@harsha509 I saw some window tests failing should I skip the IE examples I added? It's a bit difficult for me locally to test IE due to my computer being a mac
we need to execute tests in chromium edge (IE in edge mode), can you try setting this option attach_to_edge_chrome: true
@harsha509 I saw some window tests failing should I skip the IE examples I added? It's a bit difficult for me locally to test IE due to my computer being a mac
we need to execute tests in chromium edge (IE in edge mode), can you try setting this option
attach_to_edge_chrome: true
Perfect, I will do it tomorrow and update the whole PR
@harsha509 the whole PR is updated, I hope that does the trick :)
I can see that the following 2 tests are failing on windows:
1) Internet Explorer Options adds the silent option Failure/Error: Selenium::WebDriver.for(:ie, options: @options)
Selenium::WebDriver::Error::WebDriverError:
These options are not w3c compliant: {"silent"=>{:silent=>true}}
./spec/browsers/internet_explorer_spec.rb:54:in `block (3 levels) in <top (required)>'
2) Internet Explorer Options launches ie with the create process api Failure/Error: Selenium::WebDriver.for(:ie, options: @options)
Selenium::WebDriver::Error::SessionNotCreatedError:
Unexpected error launching Internet Explorer. Unable to use CreateProcess() API. To use CreateProcess() with Internet Explorer 8 or higher, the value of registry setting in HKEY_CURRENT_USER\Software\Microsoft\Internet Explorer\Main\TabProcGrowth must be '0'.
./spec/browsers/internet_explorer_spec.rb:65:in `block (3 levels) in <top (required)>'
I will try to set up parallels and see if I can reproduce them on my mac
Hi @harsha509 I hope you are doing well, I updated the 2 tests that were failing and hopefully the pipeline will be green this time
Hi @harsha509 I re-merged the trunk, so I hope the tests are ready to run again, after this I will continue updating the ruby docs, thank you so much!
Hi @harsha509 I looked more into it and I found that the ruby library does not support the silent option so I added it on this PR as it is on other bindings such as java and js, once the PR is merged, the test will stop failing:
The PR adding support for the silent capability has been merged https://github.com/SeleniumHQ/selenium/pull/14152, so for now I will skip the silent test until the release of selenium 4.22.0, so everything should work now @harsha509
User description
Description
This PR migrates and adds code examples using ruby for IE
Motivation and Context
It's important to keep the examples and documentation up to date to facilitate usage by all the users
Types of changes
Checklist
PR Type
Enhancement, Documentation
Description
Changes walkthrough ๐
internet_explorer_spec.rb
Add comprehensive test cases for Internet Explorer options in Ruby.
examples/ruby/spec/browsers/internet_explorer_spec.rb
settings, and protected mode settings.
internet_explorer.en.md
Update Ruby code examples in Internet Explorer documentation.
website_and_docs/content/documentation/webdriver/browsers/internet_explorer.en.md
internet_explorer.ja.md
Update Ruby code examples in Japanese Internet Explorer documentation.
website_and_docs/content/documentation/webdriver/browsers/internet_explorer.ja.md
internet_explorer.pt-br.md
Update Ruby code examples in Portuguese Internet Explorer
documentation.
website_and_docs/content/documentation/webdriver/browsers/internet_explorer.pt-br.md
internet_explorer.zh-cn.md
Update Ruby code examples in Chinese Internet Explorer documentation.
website_and_docs/content/documentation/webdriver/browsers/internet_explorer.zh-cn.md