Closed titusfortner closed 1 week ago
โฑ๏ธ Estimated effort to review [1-5] | 2 |
๐งช Relevant tests | No |
๐ Security concerns | No |
โก Key issues to review | None |
Name | Link |
---|---|
Latest commit | 02b3af6c8631fa83680e6e86ff4f8c94eec13abb |
Latest deploy log | https://app.netlify.com/sites/selenium-dev/deploys/668e95b02ca9810008fbe446 |
Deploy Preview | https://deploy-preview-1765--selenium-dev.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Category | Suggestion | Score |
Security |
Verify the integrity hashes for the new package versions___ **Double-check the integrity hashes for the new package versions to ensure they match theexpected values from the package registry. This helps in verifying the integrity and authenticity of the packages.** [examples/javascript/package-lock.json [1018-1020]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1765/files#diff-9e9f1801be0cdd2ca5839a8a8bda05bc37424f1bc94c8f1b196282d65552e5bcR1018-R1020) ```diff +"version": "4.22.0", +"resolved": "https://registry.npmjs.org/selenium-webdriver/-/selenium-webdriver-4.22.0.tgz", +"integrity": "sha512-GNbrkCHmy249ai885wgXqTfqL2lZnclUH/P8pwTDIqzyFxU3YhDiN7p/c9tMFA4NhgRdEBO2QCG+CWmG7xr/Mw==", - ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 8Why: Ensuring the integrity of package versions is crucial for security. The suggestion directly relates to the changes made in the PR and addresses a significant security aspect. | 8 |
Best practice |
Verify compatibility of new package versions with existing packages___ **Ensure that the new package versions are compatible with the existing packages in theproject. Sometimes, updating a package version can introduce breaking changes or incompatibilities with other packages.** [examples/dotnet/SeleniumDocs/SeleniumDocs.csproj [13-14]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1765/files#diff-71ac76d07f5edc5b438e23b53604457edcbd5d884bc745536306fb1356b741a1R13-R14) ```diff + Suggestion importance[1-10]: 7Why: This is a valid suggestion as updating package versions can indeed lead to compatibility issues. However, it does not address a specific issue in the PR, but rather provides a general best practice advice. | 7 |
Run tests to ensure no issues with the new Selenium version___ **After updating the Selenium version, run your test suite to ensure that there are nobreaking changes or issues introduced by the new version.** [examples/python/requirements.txt [1]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1765/files#diff-c233c301c314607d2dfcee9a9ec0d5a7b78a67d2c8927808fd4c9d382bbb4a8eR1-R1) ```diff +selenium==4.22.0 - ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 7Why: Running tests after updating a dependency is a best practice to catch any potential issues early. This suggestion is relevant and practical, though it is a general recommendation rather than addressing a specific issue in the PR. | 7 | |
Review release notes for the new Selenium WebDriver version___ **Check the release notes for the new Selenium WebDriver version to understand any newfeatures, deprecations, or breaking changes that might affect your project.** [examples/ruby/Gemfile [11]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1765/files#diff-050c5bd1b060f5924d57c5aaeedad981932dd1db856e57ddf779dd5e34bd0d97R11-R11) ```diff +gem 'selenium-webdriver', '= 4.22.0' - ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 7Why: Reviewing release notes is important to understand the impact of new versions, including new features or breaking changes. This is a proactive suggestion relevant to the changes made in the PR. | 7 |
**Action:** tests (macos, stable) |
**Failed stage:** [Run tests](https://github.com/SeleniumHQ/seleniumhq.github.io/actions/runs/9875772265/job/27273304892) [โ] |
**Failed test name:** Remote WebDriver starts remotely |
**Failure summary:**
The action failed because multiple tests in the remote_webdriver_spec.rb file encountered a TypeError . Specifically:Selenium::Server.get raised a TypeError indicating "no implicit conversion of String into Integer". - Remote WebDriver starts remotely - Remote WebDriver uploads - Remote WebDriver downloads remote_webdriver_spec.rb file. |
Relevant error logs:```yaml 1: ##[group]Operating System 2: macOS ... 271: timeout_minutes: 20 272: max_attempts: 3 273: command: cd examples/ruby 274: bundle exec rspec 275: 276: retry_wait_seconds: 10 277: polling_interval_seconds: 1 278: warning_on_retry: true 279: continue_on_error: false ... 284: PATH: /Users/runner/.local/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/Users/runner/.cargo/bin:/usr/local/opt/curl/bin:/usr/local/bin:/usr/local/sbin:/Users/runner/bin:/Users/runner/.yarn/bin:/Users/runner/Library/Android/sdk/tools:/Users/runner/Library/Android/sdk/platform-tools:/Library/Frameworks/Python.framework/Versions/Current/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/usr/bin:/bin:/usr/sbin:/sbin:/Users/runner/.dotnet/tools 285: JAVA_HOME: /Users/runner/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.23-9/arm64/Contents/Home 286: JAVA_HOME_11_ARM64: /Users/runner/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.23-9/arm64/Contents/Home 287: ##[endgroup] 288: ......*.........................................................................***...*************...*.....*........*FFF....*********************.................... 289: Pending: (Failures listed here are expected and do not affect your suite's status) 290: 1) Keys copy and paste 291: # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"}; 292: Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!' ... 411: 40) Element Locators with relative locators finds near element 412: # These are reference following the documentation example 413: # ./spec/elements/locators_spec.rb:55 414: 41) Element Locators with relative locators chains relative locators 415: # These are reference following the documentation example 416: # ./spec/elements/locators_spec.rb:59 417: Failures: 418: 1) Remote WebDriver starts remotely 419: Got 0 failures and 2 other errors: 420: 1.1) Failure/Error: 421: Selenium::Server.get(:latest, 422: background: true, 423: args: %w[--selenium-manager true --enable-managed-downloads true]) 424: TypeError: 425: no implicit conversion of String into Integer 426: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in |
Description
Status
Still need to:
Feedback Needed
Everything under here: https://deploy-preview-1765--selenium-dev.netlify.app/documentation/webdriver/bidi/ Including all this: https://deploy-preview-1765--selenium-dev.netlify.app/documentation/webdriver/bidi/cdp/
Motivation and Context
Selenium 4.22!
PR Type
enhancement
Description
Changes walkthrough ๐
SeleniumDocs.csproj
Update .NET Selenium package versions to 4.22.0
examples/dotnet/SeleniumDocs/SeleniumDocs.csproj
Selenium.Support
package version to 4.22.0Selenium.WebDriver
package version to 4.22.0pom.xml
Update Java Selenium version to 4.22.0
examples/java/pom.xml - Updated `selenium.version` property to 4.22.0
package-lock.json
Update JavaScript Selenium package version in package-lock.json to
4.22.0
examples/javascript/package-lock.json - Updated `selenium-webdriver` package version to 4.22.0
package.json
Update JavaScript Selenium package version in package.json to 4.22.0
examples/javascript/package.json - Updated `selenium-webdriver` package version to 4.22.0
pom.xml
Update Kotlin Selenium version to 4.22.0
examples/kotlin/pom.xml - Updated `selenium.version` property to 4.22.0
requirements.txt
Update Python Selenium package version to 4.22.0
examples/python/requirements.txt - Updated `selenium` package version to 4.22.0
Gemfile
Update Ruby Selenium gem version to 4.22.0
examples/ruby/Gemfile - Updated `selenium-webdriver` gem version to 4.22.0