Closed reply2sagar closed 1 week ago
Visit the deploys page to approve it
Name | Link |
---|---|
Latest commit | d82ef8aa8d69255d246998335bf9caef4a14a935 |
β±οΈ Estimated effort to review [1-5] | 2 |
π§ͺ Relevant tests | No |
π Security concerns | No |
β‘ Key issues to review | None |
Category | Suggestion | Score |
Clarity |
Clarify that Maven should be installed before running the
___
**Clarify that Maven should be installed on the user's system before running the | 7 |
Best practice |
Add a note to ensure the JAVA_HOME environment variable is set correctly before running Maven commands___ **Add a note to ensure that the JAVA_HOME environment variable is set correctly beforerunning the Maven commands.** [examples/java/src/test/java/README.md [26]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1776/files#diff-5f72f1262760d1c45cb77a829d4df21e667be670fb08fa726dc536f596164943R26-R26) ```diff +Ensure your JAVA_HOME environment variable is set correctly, then run: mvn test ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 7Why: This suggestion is helpful for ensuring the environment is correctly set up, which is important for successful execution of Maven commands. | 7 |
HI @reply2sagar ,
Thank you for the PR. I have replaced this PR with commit https://github.com/SeleniumHQ/seleniumhq.github.io/commit/acbde0c44a0a9644bbb928eb97efb7384a343b31!
User description
Added README to run Java Example and also updated the first_script.en.md file with instructions to run first Java Example
Description
Added examples\java\src\test\java\README.md to run Java Example and also updated the website_and_docs\content\documentation\webdriver\getting_started\first_script.en.md file with instructions to run first Java Example
Motivation and Context
Documentation to run first Java Example was missing.
Types of changes
Checklist
PR Type
Documentation
Description
examples/java/src/test/java/
with detailed instructions on how to run all Java test examples and the first Java example using Maven.website_and_docs/content/documentation/webdriver/getting_started/first_script.en.md
to link to the new README for running the first Java example.Changes walkthrough π
README.md
Added README with steps to run Java examples using Maven.
examples/java/src/test/java/README.md
first_script.en.md
Updated Java tab with link to new README for running example.
website_and_docs/content/documentation/webdriver/getting_started/first_script.en.md
Java example.