SeleniumHQ / seleniumhq.github.io

Official Selenium website and documentation
https://selenium.dev
Apache License 2.0
1.03k stars 1.23k forks source link

Added README to run Java Examples (#1160) #1776

Closed reply2sagar closed 1 week ago

reply2sagar commented 3 weeks ago

User description

Added README to run Java Example and also updated the first_script.en.md file with instructions to run first Java Example

Description

Added examples\java\src\test\java\README.md to run Java Example and also updated the website_and_docs\content\documentation\webdriver\getting_started\first_script.en.md file with instructions to run first Java Example

Motivation and Context

Documentation to run first Java Example was missing.

Types of changes

Checklist


PR Type

Documentation


Description


Changes walkthrough πŸ“

Relevant files
Documentation
README.md
Added README with steps to run Java examples using Maven.

examples/java/src/test/java/README.md
  • Added instructions to clone the repository.
  • Provided steps to navigate to the Java directory.
  • Included commands to install dependencies and run tests using Maven.
  • Added a specific command to execute the first Java example.
  • +37/-0   
    first_script.en.md
    Updated Java tab with link to new README for running example.

    website_and_docs/content/documentation/webdriver/getting_started/first_script.en.md
  • Updated the Java tab to link to the new README for running the first
    Java example.
  • +1/-1     

    πŸ’‘ PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    netlify[bot] commented 3 weeks ago

    Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    Latest commit d82ef8aa8d69255d246998335bf9caef4a14a935
    CLAassistant commented 3 weeks ago

    CLA assistant check
    All committers have signed the CLA.

    codiumai-pr-agent-pro[bot] commented 3 weeks ago

    PR Reviewer Guide πŸ”

    ⏱️ Estimated effort to review [1-5] 2
    πŸ§ͺ Relevant tests No
    πŸ”’ Security concerns No
    ⚑ Key issues to review None
    codiumai-pr-agent-pro[bot] commented 3 weeks ago

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Clarity
    Clarify that Maven should be installed before running the mvn compile command ___ **Clarify that Maven should be installed on the user's system before running the mvn compile
    command.** [examples/java/src/test/java/README.md [20]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1776/files#diff-5f72f1262760d1c45cb77a829d4df21e667be670fb08fa726dc536f596164943R20-R20) ```diff +Ensure Maven is installed on your system, then run: mvn compile ``` - [ ] **Apply this suggestion**
    Suggestion importance[1-10]: 7 Why: This is a useful suggestion for clarity and ensuring prerequisites are met, although it is not critical for functionality.
    7
    Best practice
    Add a note to ensure the JAVA_HOME environment variable is set correctly before running Maven commands ___ **Add a note to ensure that the JAVA_HOME environment variable is set correctly before
    running the Maven commands.** [examples/java/src/test/java/README.md [26]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1776/files#diff-5f72f1262760d1c45cb77a829d4df21e667be670fb08fa726dc536f596164943R26-R26) ```diff +Ensure your JAVA_HOME environment variable is set correctly, then run: mvn test ``` - [ ] **Apply this suggestion**
    Suggestion importance[1-10]: 7 Why: This suggestion is helpful for ensuring the environment is correctly set up, which is important for successful execution of Maven commands.
    7
    harsha509 commented 1 week ago

    HI @reply2sagar ,

    Thank you for the PR. I have replaced this PR with commit https://github.com/SeleniumHQ/seleniumhq.github.io/commit/acbde0c44a0a9644bbb928eb97efb7384a343b31!