search

SeleniumHQ / seleniumhq.github.io

Official Selenium website and documentation
https://selenium.dev
Apache License 2.0
1.03k stars 1.23k forks source link

Update list.html #1786

Closed alaahong closed 2 weeks ago

alaahong commented 2 weeks ago

User description

Just update the selenium version to 4.22.0

Thanks for contributing to the Selenium site and documentation! A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines. Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

Checklist

PR Type

Enhancement

Description

Changes walkthrough 📝

Relevant files
Enhancement
list.html
Update Selenium version to 4.22.0 in download links           
website_and_docs/layouts/downloads/list.html
  • Updated Selenium version link from 4.21.0 to 4.22.0.
  • Updated NuGet release version and date to 4.22.0 and June 21, 2024.
    		•  +2/-2     

    💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    codiumai-pr-agent-pro[bot] commented 2 weeks ago

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5] 1
    🧪 Relevant tests No
    🔒 Security concerns No
    ⚡ Key issues to review None
    codiumai-pr-agent-pro[bot] commented 2 weeks ago

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Maintainability
    Replace hardcoded version numbers and URLs with dynamically generated ones ___ **Consider using a variable or a template function to generate the version number and
    download link dynamically. This approach will reduce the need for manual updates and
    potential human errors in the future.** [website_and_docs/layouts/downloads/list.html [28]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1786/files#diff-5b8f4ee0a6d0ab6bcc253c176e2f3044b9c6c295e7dadff0468147d18abe54bdR28-R28) ```diff -4.22.0 +4.22.0 ``` - [ ] **Apply this suggestion**
    Suggestion importance[1-10]: 8 Why: This suggestion improves maintainability by reducing the need for manual updates and minimizing potential human errors. It is contextually accurate and relevant to the new code introduced in the PR.
    		8
    Use dynamic content for release dates to avoid manual updates ___ **Update the text to include a dynamic date using server-side scripting or a template system
    to automatically display the correct release date.** [website_and_docs/layouts/downloads/list.html [110]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1786/files#diff-5b8f4ee0a6d0ab6bcc253c176e2f3044b9c6c295e7dadff0468147d18abe54bdR110-R110) ```diff -Nuget latest release is 4.22.0 Released on Jun 21, 2024. +Nuget latest release is 4.22.0 Released on {{ release_date }}. ``` - [ ] **Apply this suggestion**
    Suggestion importance[1-10]: 8 Why: This suggestion enhances maintainability by automating the display of release dates, reducing the risk of outdated information. It is contextually accurate and relevant to the new code introduced in the PR.
    		8
    netlify[bot] commented 2 weeks ago

    Deploy Preview for selenium-dev failed.

    Name Link
    Latest commit 439543a8e65389e1ca4a9b4f27f5233c537277c2
    Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/667eccfc49cc010008482793