SeleniumHQ / seleniumhq.github.io

Official Selenium website and documentation
https://selenium.dev
Apache License 2.0
1.09k stars 1.28k forks source link

Fix The Line of Java Port In the ChromeDriverService Docs #1812

Closed ahma0 closed 2 months ago

ahma0 commented 2 months ago

User description

Thanks for contributing to the Selenium site and documentation! A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines. Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Java codes does not appear in the ChromeDriverService Tutorial

Motivation and Context

Types of changes

Checklist


PR Type

Documentation


Description


Changes walkthrough 📝

Relevant files
Documentation
service.en.md
Fix Java code block reference in English documentation     

website_and_docs/content/documentation/webdriver/drivers/service.en.md - Corrected the line number in the Java code block reference.
+1/-1     
service.ja.md
Fix Java code block reference in Japanese documentation   

website_and_docs/content/documentation/webdriver/drivers/service.ja.md - Corrected the line number in the Java code block reference.
+1/-1     
service.pt-br.md
Fix Java code block reference in Portuguese documentation

website_and_docs/content/documentation/webdriver/drivers/service.pt-br.md - Corrected the line number in the Java code block reference.
+1/-1     
service.zh-cn.md
Fix Java code block reference in Chinese documentation     

website_and_docs/content/documentation/webdriver/drivers/service.zh-cn.md - Corrected the line number in the Java code block reference.
+1/-1     

💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

netlify[bot] commented 2 months ago

Deploy Preview for selenium-dev ready!

Name Link
Latest commit f1729ab0f6845d3e739e132278ecb88012c55752
Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/6696203040d8760008875169
Deploy Preview https://deploy-preview-1812--selenium-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

codiumai-pr-agent-pro[bot] commented 2 months ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review
codiumai-pr-agent-pro[bot] commented 2 months ago

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Possible issue
✅ Verify and correct the line number in the gh-codeblock path to ensure it points to the correct code snippet ___
Suggestion Impact:The suggestion to correct the line number in the gh-codeblock path was implemented. The line number was changed from 32 to 33. code diff: ```diff -{{< gh-codeblock path="examples/java/src/test/java/dev/selenium/drivers/ServiceTest.java#L32" >}} +{{< gh-codeblock path="examples/java/src/test/java/dev/selenium/drivers/ServiceTest.java#L33" >}} ```
___ **Ensure that the updated line number in the gh-codeblock path is correct and points
to the relevant code snippet that demonstrates the configuration of the
ChromeDriverService on a specific port. If the line number is incorrect, it could
lead to confusion or incorrect implementation by users.** [website_and_docs/content/documentation/webdriver/drivers/service.en.md [80]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1812/files#diff-01a28f44f7501b2cdf05e942e7fcb41cefcbed586f37c7489e3644fb2c61b7f9R80-R80) ```diff -{{< gh-codeblock path="examples/java/src/test/java/dev/selenium/drivers/ServiceTest.java#L32" >}} +{{< gh-codeblock path="examples/java/src/test/java/dev/selenium/drivers/ServiceTest.java#LXX" >}} # Replace 'XX' with the correct line number ``` - [ ] **Apply this suggestion**
Suggestion importance[1-10]: 8 Why: Ensuring the line number in the `gh-codeblock` path is correct is crucial for users to find the relevant code snippet, preventing confusion or incorrect implementation.
8