SeleniumHQ / seleniumhq.github.io

Official Selenium website and documentation
https://selenium.dev
Apache License 2.0
1.09k stars 1.28k forks source link

added python execution scripts to Using Selenium #1872

Closed shbenzer closed 3 weeks ago

shbenzer commented 3 weeks ago

User description

added python execution scripts to Organizing and Executing Selenium Code

Description

referenced the right code snippet using_selenium.py added to all translations

Motivation and Context

missing code example

Types of changes

Checklist


PR Type

documentation


Description


Changes walkthrough 📝

Relevant files
Documentation
using_selenium.en.md
Add Python code example reference in English documentation

website_and_docs/content/documentation/webdriver/getting_started/using_selenium.en.md
  • Added a reference to a Python code example.
  • Updated the documentation to include Python execution scripts.
  • +1/-0     
    using_selenium.ja.md
    Add Python code example reference in Japanese documentation

    website_and_docs/content/documentation/webdriver/getting_started/using_selenium.ja.md
  • Added a reference to a Python code example.
  • Updated the documentation to include Python execution scripts.
  • +1/-0     
    using_selenium.pt-br.md
    Add Python code example reference in Portuguese documentation

    website_and_docs/content/documentation/webdriver/getting_started/using_selenium.pt-br.md
  • Added a reference to a Python code example.
  • Updated the documentation to include Python execution scripts.
  • +1/-0     
    using_selenium.zh-cn.md
    Add Python code example reference in Chinese documentation

    website_and_docs/content/documentation/webdriver/getting_started/using_selenium.zh-cn.md
  • Added a reference to a Python code example.
  • Updated the documentation to include Python execution scripts.
  • +1/-0     

    💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    netlify[bot] commented 3 weeks ago

    Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    Latest commit 5a66196056d4ee22bc0ebf82a0d82771f4736212
    codiumai-pr-agent-pro[bot] commented 3 weeks ago

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review
    codiumai-pr-agent-pro[bot] commented 3 weeks ago

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Maintainability
    Add a comment to explain the purpose of the included code block ___ **Consider adding a brief description or comment about what the gh-codeblock shortcode
    does and what content it's including from the specified path. This can help
    maintainers and contributors understand the purpose of this addition.** [website_and_docs/content/documentation/webdriver/getting_started/using_selenium.en.md [234-236]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1872/files#diff-f521d4cd05fea84ac0fd18184a214f8ac2cd023a7f2c1a7e2b43495504b7b9f0R234-R236) ```diff {{% tab header="Python" %}} + {{< gh-codeblock path="examples/python/README.md#L35" >}} {{< badge-code >}} ``` - [ ] **Apply this suggestion**
    Suggestion importance[1-10]: 7 Why: Adding a comment to explain the purpose of the included code block improves maintainability and helps future contributors understand the context, although it is not critical.
    7
    Enhancement
    Consider localizing the included Python script content for the Portuguese (Brazil) documentation ___ **Consider localizing the content of the included Python script for the Portuguese
    (Brazil) version of the documentation, if it contains any language-specific text or
    comments.** [website_and_docs/content/documentation/webdriver/getting_started/using_selenium.pt-br.md [230-232]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1872/files#diff-8f5fb78fbfa0af0e02bb3104813f8d01b21d7f610a48922659d1e26279d40e49R230-R232) ```diff {{% tab header="Python" %}} -{{< gh-codeblock path="examples/python/README.md#L35" >}} +{{< gh-codeblock path="examples/python/README.md#L35" lang="python" >}} + {{< badge-code >}} ``` - [ ] **Apply this suggestion**
    Suggestion importance[1-10]: 6 Why: Localizing content can enhance user experience for non-English speakers, but the suggestion is speculative and depends on the content of the included script.
    6
    Consistency
    Ensure consistency and add appropriate language-specific comments for the Chinese (Simplified) documentation ___ **Ensure consistency across all language versions by adding the same gh-codeblock
    shortcode with the correct path to the Chinese (Simplified) version of the
    documentation.** [website_and_docs/content/documentation/webdriver/getting_started/using_selenium.zh-cn.md [214-216]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1872/files#diff-8e5091b793f41951b3b0b476bf67b2ff5e74a33d494b0b6adfbdc1926f274646R214-R216) ```diff {{% tab header="Python" %}} -{{< gh-codeblock path="examples/python/README.md#L35" >}} +{{< gh-codeblock path="examples/python/README.md#L35" lang="python" >}} + {{< badge-code >}} ``` - [ ] **Apply this suggestion**
    Suggestion importance[1-10]: 6 Why: Ensuring consistency and adding language-specific comments can improve readability and user experience, but the suggestion is not crucial unless there is a specific inconsistency identified.
    6
    Possible issue
    Verify the existence and appropriateness of the referenced Python script for the Japanese documentation ___ **Ensure that the content being referenced by the gh-codeblock shortcode
    (examples/python/README.md#L35) is available and contains the appropriate Python
    execution script for the Japanese version of the documentation.** [website_and_docs/content/documentation/webdriver/getting_started/using_selenium.ja.md [230-232]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1872/files#diff-53fac7bfd25fb50de7731415fedc5ea636bcdaa83166f476b3c9e13a691a6c7cR230-R232) ```diff {{% tab header="Python" %}} -{{< gh-codeblock path="examples/python/README.md#L35" >}} +{{< gh-codeblock path="examples/python/README.md#L35" lang="python" >}} {{< badge-code >}} ``` - [ ] **Apply this suggestion**
    Suggestion importance[1-10]: 5 Why: Verifying the existence and appropriateness of the referenced content is important for accuracy, but the suggestion does not provide a specific improvement to the code itself.
    5
    shbenzer commented 3 weeks ago

    @diemol this should be better