Closed jochen-testingbot closed 3 weeks ago
Name | Link |
---|---|
Latest commit | c984267fd238fa6f5c0db2028d1d0c7b65ae6be7 |
Latest deploy log | https://app.netlify.com/sites/selenium-dev/deploys/66c591a1bb3a0200088ca536 |
Deploy Preview | https://deploy-preview-1877--selenium-dev.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
โฑ๏ธ Estimated effort to review: 1 ๐ตโชโชโชโช |
๐งช No relevant tests |
๐ No security concerns identified |
โก No key issues to review |
Category | Suggestion | Score |
Maintainability |
Reorder sponsor entries to maintain chronological order based on sponsorship start dates___ **Consider reordering the new sponsor entry to maintain chronological order based onsponsorship start dates. This would improve readability and make it easier to manage sponsor listings over time.** [website_and_docs/data/sponsors.yml [97-104]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1877/files#diff-0e0c93f6b304c3a5b08f1b354c7f82b6a1485fb5e26c9782df090a5ed70446f8R97-R104) ```diff +# Sponsorship start date: Jul 12, 2024 +- logo: "/images/sponsors/route4me-logo.png" + url: "https://route4me.com/" + name: "Route Planner and Route Optimizer - Route4Me Inc." # Sponsorship start date: Aug 13, 2024 - logo: "/images/sponsors/testingbot.png" url: "https://testingbot.com/" name: "Selenium Cloud Testing - TestingBot" -# Sponsorship start date: Jul 12, 2024 -- logo: "/images/sponsors/route4me-logo.png" - url: "https://route4me.com/" - name: "Route Planner and Route Optimizer - Route4Me Inc." ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 8Why: Reordering the sponsor entries to maintain chronological order enhances readability and manageability of the sponsor list, making it easier to track and update sponsorships over time. | 8 |
Consistency |
Standardize the format of sponsorship dates and improve consistency in sponsor name presentation___ **Consider using a consistent date format for the sponsorship start date comments. Theexisting format is 'MMM DD, YYYY', but the new entry uses 'Aug 13, 2024'. Align it with the existing format for better readability and consistency.** [website_and_docs/data/sponsors.yml [97-100]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1877/files#diff-0e0c93f6b304c3a5b08f1b354c7f82b6a1485fb5e26c9782df090a5ed70446f8R97-R100) ```diff # Sponsorship start date: Aug 13, 2024 - logo: "/images/sponsors/testingbot.png" url: "https://testingbot.com/" - name: "Selenium Cloud Testing - TestingBot" + name: "TestingBot - Selenium Cloud Testing" ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 7Why: The suggestion to standardize the date format improves readability and consistency, which is beneficial for maintaining the document. However, the suggestion also includes a change to the sponsor name presentation that was not part of the original PR code diff, which slightly reduces its relevance. | 7 |
User description
Description
This PR adds the logo for TestingBot (bronze sponsor) to the sponsor page.
Thank you & keep up the good work!
Checklist
PR Type
enhancement, documentation
Description
sponsors.yml
file.Changes walkthrough ๐
sponsors.yml
Add TestingBot as a bronze sponsor in YAML file
website_and_docs/data/sponsors.yml