Closed shbenzer closed 3 weeks ago
Visit the deploys page to approve it
Name | Link |
---|---|
Latest commit | 75eef14c3a684445f52e682511ff854609d0b391 |
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪ |
🧪 No relevant tests |
🔒 No security concerns identified |
⚡ Key issues to review Incorrect Code Example The code example for CSharp is incorrectly using the Java example path. Incorrect Code Example The code example for CSharp is incorrectly using the Java example path. Incorrect Code Example The code example for CSharp is incorrectly using the Java example path. Incorrect Code Example The code example for CSharp is incorrectly using the Java example path. |
Category | Suggestion | Score |
Bug fix |
Correct the file path for the CSharp code example___ **The code block for CSharp is incorrectly using the Java example path. Replace itwith the correct CSharp example path.** [website_and_docs/content/documentation/webdriver/drivers/_index.en.md [70-73]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1882/files#diff-10ff84d69cea7383c29ebfd0e4934cda8a3d6111bfc937897b1f446c4f4781b5R70-R73) ```diff {{< tab header="CSharp" >}} -{< gh-codeblock path="examples/java/src/test/java/dev/selenium/getting_started/FirstScript.java#L29" >} +{< gh-codeblock path="examples/dotnet/SeleniumDocs/GettingStarted/FirstScriptTest.cs#L29" >} {{< badge-code >}} {{< /tab >}} ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 9Why: The suggestion correctly identifies a bug where the CSharp code block is using a Java example path, which is a significant issue that needs to be fixed for clarity and accuracy. | 9 |
Correct the file path for the CSharp code example in the Japanese translation___ **The code block for CSharp is incorrectly using the Java example path. Replace itwith the correct CSharp example path.** [website_and_docs/content/documentation/webdriver/drivers/_index.ja.md [69-72]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1882/files#diff-bfbaccc3ea80f5b819613809c7324862ee335c163d6e474b07a0d3aa7e48740eR69-R72) ```diff {{< tab header="CSharp" >}} -{< gh-codeblock path="examples/java/src/test/java/dev/selenium/getting_started/FirstScript.java#L29" >} +{< gh-codeblock path="examples/dotnet/SeleniumDocs/GettingStarted/FirstScriptTest.cs#L29" >} {{< badge-code >}} {{< /tab >}} ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 9Why: This suggestion addresses the same critical issue in the Japanese translation, ensuring consistency and correctness across different language versions. | 9 | |
Correct the file path for the CSharp code example in the Portuguese translation___ **The code block for CSharp is incorrectly using the Java example path. Replace itwith the correct CSharp example path.** [website_and_docs/content/documentation/webdriver/drivers/_index.pt-br.md [70-73]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1882/files#diff-86b91e7aed382ec5c668cf7a26e77cc125d1b983696d9fa5962ce8c47c598fc9R70-R73) ```diff {{< tab header="CSharp" >}} -{< gh-codeblock path="examples/java/src/test/java/dev/selenium/getting_started/FirstScript.java#L29" >} +{< gh-codeblock path="examples/dotnet/SeleniumDocs/GettingStarted/FirstScriptTest.cs#L29" >} {{< badge-code >}} {{< /tab >}} ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 9Why: The suggestion fixes the incorrect file path in the Portuguese translation, which is essential for maintaining the accuracy of the documentation. | 9 | |
Correct the file path for the CSharp code example in the Chinese translation___ **The code block for CSharp is incorrectly using the Java example path. Replace itwith the correct CSharp example path.** [website_and_docs/content/documentation/webdriver/drivers/_index.zh-cn.md [70-73]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1882/files#diff-271afe3b24802a1c6427f915a6ded1b3f370a63eda9ee97b38820971149f4563R70-R73) ```diff {{< tab header="CSharp" >}} -{< gh-codeblock path="examples/java/src/test/java/dev/selenium/getting_started/FirstScript.java#L29" >} +{< gh-codeblock path="examples/dotnet/SeleniumDocs/GettingStarted/FirstScriptTest.cs#L29" >} {{< badge-code >}} {{< /tab >}} ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 9Why: Correcting the file path in the Chinese translation is crucial for ensuring that the documentation is accurate and useful for all users. | 9 |
User description
Added code examples for driver.quit in all languages and translations
Description
Added code examples for driver.quit in all languages and translations
Motivation and Context
documentation should be as comprehensive as possible
Types of changes
Checklist
PR Type
Documentation
Description
driver.quit
code examples in multiple languages including Java, CSharp, JavaScript, and Kotlin.Changes walkthrough 📝
_index.en.md
Add `driver.quit` code examples in multiple languages
website_and_docs/content/documentation/webdriver/drivers/_index.en.md
driver.quit
in Java, CSharp, JavaScript,and Kotlin.
_index.ja.md
Add `driver.quit` code examples in Japanese documentation
website_and_docs/content/documentation/webdriver/drivers/_index.ja.md
driver.quit
in Java, CSharp, JavaScript,and Kotlin.
_index.pt-br.md
Add `driver.quit` code examples in Portuguese documentation
website_and_docs/content/documentation/webdriver/drivers/_index.pt-br.md
driver.quit
in Java, CSharp, JavaScript,and Kotlin.
_index.zh-cn.md
Add `driver.quit` code examples in Chinese documentation
website_and_docs/content/documentation/webdriver/drivers/_index.zh-cn.md
driver.quit
in Java, CSharp, JavaScript,and Kotlin.