Closed shbenzer closed 2 weeks ago
Visit the deploys page to approve it
Name | Link |
---|---|
Latest commit | a65b0791f5202c83ff0c5316ab4829e76ead6751 |
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪ |
🧪 No relevant tests |
🔒 No security concerns identified |
⚡ No key issues to review |
Category | Suggestion | Score |
Consistency |
Remove remaining badge-code tag for consistency across language tabs___ **Consider removing the remaining{{< badge-code >}} tag in the CSharp tab, as it seems to be inconsistent with the removal of similar tags in other language tabs.** [website_and_docs/content/documentation/webdriver/getting_started/first_script.en.md [238-239]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1888/files#diff-0757312e3d52b8201ca35b35c4bdad191db3e0978681a45c0cad1bebeb49fd3cR238-R239) ```diff {{< tab header="CSharp" >}} -{{< badge-code >}} ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 9Why: The suggestion correctly identifies an inconsistency in the documentation by pointing out the remaining `{{< badge-code >}}` tag in the CSharp tab, which should be removed for consistency with other language tabs. | 9 |
Remove leftover badge-code tag for consistency in documentation___ **Remove the remaining{{< badge-code >}} tag in the CSharp tab to maintain consistency with the changes made in other language tabs and files.** [website_and_docs/content/documentation/webdriver/getting_started/first_script.ja.md [241-242]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1888/files#diff-5fd0f788adbc59da5e0c8a7571a85dece3d2bf1f9512ac6b6840281ef1e356e6R241-R242) ```diff {{< tab header="CSharp" >}} -{{< badge-code >}} ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 9Why: This suggestion highlights the need to remove the `{{< badge-code >}}` tag in the CSharp tab, aligning with similar changes in other language tabs, ensuring consistency across the documentation. | 9 | |
Remove unnecessary badge-code tag for documentation consistency___ **Remove the{{< badge-code >}} tag in the CSharp tab to align with the changes made in other language tabs and maintain consistency across the documentation.** [website_and_docs/content/documentation/webdriver/getting_started/first_script.pt-br.md [240-241]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1888/files#diff-bb86d4dbc22fd54aaff9425d57d478e845bae69eff3b13010c0d6f34aed183c0R240-R241) ```diff {{< tab header="CSharp" >}} -{{< badge-code >}} ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 9Why: The suggestion is valid as it addresses the inconsistency by recommending the removal of the `{{< badge-code >}}` tag in the CSharp tab, which aligns with the changes made in other language tabs. | 9 | |
Remove redundant badge-code tag for uniform documentation structure___ **Remove the{{< badge-code >}} tag in the CSharp tab to ensure consistency with the changes made in other language tabs and across different localized versions of the documentation.** [website_and_docs/content/documentation/webdriver/getting_started/first_script.zh-cn.md [253-254]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1888/files#diff-9410091994b973ef73f08c08ee361a79d99eea7e91ff75b69d70fa7acba71cadR253-R254) ```diff {{< tab header="CSharp" >}} -{{< badge-code >}} ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 9Why: This suggestion correctly identifies the need to remove the `{{< badge-code >}}` tag in the CSharp tab to maintain consistency with other language tabs, ensuring a uniform documentation structure. | 9 |
User description
Removed a bunch of badge codes that were left over after people added code examples
Description
Removed leftover badge codes from the following files in all translations:
Motivation and Context
cleans up site
Types of changes
Checklist
PR Type
documentation
Description
{{< badge-code >}}
tags from various documentation files across multiple translations.Changes walkthrough 📝
16 files
selenium_manager.en.md
Remove erroneous badge-code tag from selenium_manager.en.md
website_and_docs/content/documentation/selenium_manager.en.md - Removed erroneous `{{< badge-code >}}` tag.
selenium_manager.ja.md
Remove erroneous badge-code tag from selenium_manager.ja.md
website_and_docs/content/documentation/selenium_manager.ja.md - Removed erroneous `{{< badge-code >}}` tag.
selenium_manager.pt-br.md
Remove erroneous badge-code tag from selenium_manager.pt-br.md
website_and_docs/content/documentation/selenium_manager.pt-br.md - Removed erroneous `{{< badge-code >}}` tag.
selenium_manager.zh-cn.md
Remove erroneous badge-code tag from selenium_manager.zh-cn.md
website_and_docs/content/documentation/selenium_manager.zh-cn.md - Removed erroneous `{{< badge-code >}}` tag.
_index.en.md
Remove erroneous badge-code tags from drivers index.en.md
website_and_docs/content/documentation/webdriver/drivers/_index.en.md - Removed erroneous `{{< badge-code >}}` tags from multiple code tabs.
_index.ja.md
Remove erroneous badge-code tags from drivers index.ja.md
website_and_docs/content/documentation/webdriver/drivers/_index.ja.md - Removed erroneous `{{< badge-code >}}` tags from multiple code tabs.
_index.pt-br.md
Remove erroneous badge-code tags from drivers index.pt-br.md
website_and_docs/content/documentation/webdriver/drivers/_index.pt-br.md - Removed erroneous `{{< badge-code >}}` tags from multiple code tabs.
_index.zh-cn.md
Remove erroneous badge-code tags from drivers index.zh-cn.md
website_and_docs/content/documentation/webdriver/drivers/_index.zh-cn.md - Removed erroneous `{{< badge-code >}}` tags from multiple code tabs.
first_script.en.md
Remove erroneous badge-code tag from first_script.en.md
website_and_docs/content/documentation/webdriver/getting_started/first_script.en.md - Removed erroneous `{{< badge-code >}}` tag from Python tab.
first_script.ja.md
Remove erroneous badge-code tag from first_script.ja.md
website_and_docs/content/documentation/webdriver/getting_started/first_script.ja.md - Removed erroneous `{{< badge-code >}}` tag from Python tab.
first_script.pt-br.md
Remove erroneous badge-code tag from first_script.pt-br.md
website_and_docs/content/documentation/webdriver/getting_started/first_script.pt-br.md - Removed erroneous `{{< badge-code >}}` tag from Python tab.
first_script.zh-cn.md
Remove erroneous badge-code tag from first_script.zh-cn.md
website_and_docs/content/documentation/webdriver/getting_started/first_script.zh-cn.md - Removed erroneous `{{< badge-code >}}` tag from Python tab.
using_selenium.en.md
Remove erroneous badge-code tag from using_selenium.en.md
website_and_docs/content/documentation/webdriver/getting_started/using_selenium.en.md - Removed erroneous `{{< badge-code >}}` tag from Python tab.
using_selenium.ja.md
Remove erroneous badge-code tag from using_selenium.ja.md
website_and_docs/content/documentation/webdriver/getting_started/using_selenium.ja.md - Removed erroneous `{{< badge-code >}}` tag from Python tab.
using_selenium.pt-br.md
Remove erroneous badge-code tag from using_selenium.pt-br.md
website_and_docs/content/documentation/webdriver/getting_started/using_selenium.pt-br.md - Removed erroneous `{{< badge-code >}}` tag from Python tab.
using_selenium.zh-cn.md
Remove erroneous badge-code tag from using_selenium.zh-cn.md
website_and_docs/content/documentation/webdriver/getting_started/using_selenium.zh-cn.md - Removed erroneous `{{< badge-code >}}` tag from Python tab.