Closed shbenzer closed 2 weeks ago
Visit the deploys page to approve it
Name | Link |
---|---|
Latest commit | d99cbbfc9e257d6284f0b54dd0375c1d99960d39 |
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪ |
🧪 No relevant tests |
🔒 No security concerns identified |
⚡ No key issues to review |
Category | Suggestion | Score |
Best practice |
Use Markdown's native line break syntax instead of HTML tags___ **Instead of using tags for line breaks, consider using Markdown's native line break syntax. In Markdown, you can create a line break by adding two spaces at the end of a line or by using a blank line between content.** [website_and_docs/content/documentation/webdriver/getting_started/install_library.en.md [46-49]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1892/files#diff-88bbee02050826ca33f144b5588980e9b9f824bbf0d0215ff75de6d4028fa68aR46-R49) ```diff ```shell pip install selenium ``` - ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 8Why: The suggestion correctly identifies the use of HTML `` tags in a Markdown document and recommends using Markdown's native line break syntax for better readability and adherence to Markdown standards. | 8 |
Consistency |
Maintain consistency in line break syntax across all language versions___ **For consistency across all language versions of the documentation, consider usingthe same line break approach as suggested for the English version. Replace tags with Markdown's native line break syntax.** [website_and_docs/content/documentation/webdriver/getting_started/install_library.ja.md [44-47]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1892/files#diff-2ce6683412ee6db6821c0bcd53f789cfe39be4fa4a981b2486a15ed50e8d4cecR44-R47) ```diff ```shell pip install selenium ``` - ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 8Why: This suggestion promotes consistency across different language versions of the documentation by recommending the use of Markdown's native line break syntax, which is a best practice. | 8 |
Standardize line break syntax across all language versions of the documentation___ **To maintain consistency and follow Markdown best practices, replace the tags with Markdown's native line break syntax, as suggested for the English and Japanese versions.** [website_and_docs/content/documentation/webdriver/getting_started/install_library.pt-br.md [46-49]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1892/files#diff-e9b279344f8d2e5794747fd53c96d55dbc175ab21d018bb01afb6c1dd01376ddR46-R49) ```diff ```shell pip install selenium ``` - ``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 8Why: The suggestion is valid as it encourages the use of Markdown's native line break syntax, ensuring consistency and adherence to best practices across multiple language versions. | 8 | |
Align line break syntax with other language versions and Markdown standards___ **For consistency with other language versions and to adhere to Markdown bestpractices, replace the tags with Markdown's native line break syntax.**
[website_and_docs/content/documentation/webdriver/getting_started/install_library.zh-cn.md [44-47]](https://github.com/SeleniumHQ/seleniumhq.github.io/pull/1892/files#diff-23e25357b1fa69b927ae6def863091e7d861394c4224d3f22cca020bad368f6eR44-R47)
```diff
```shell
pip install selenium
```
-``` - [ ] **Apply this suggestion** Suggestion importance[1-10]: 8Why: This suggestion is appropriate as it aligns with the goal of maintaining consistency and following Markdown best practices by replacing HTML `` tags with Markdown's native line break syntax. | 8 |
User description
Installing Selenium's code examples had the section squished together; I added breakpoints b/w squished sections
Description
added breakpoints in coding examples of install_library.mds of each language
Motivation and Context
Increases readability
Types of changes
Checklist
PR Type
documentation
Description
<br>
) between code examples in the installation documentation for Selenium.Changes walkthrough 📝
install_library.en.md
Add HTML breakpoints for better readability in English doc
website_and_docs/content/documentation/webdriver/getting_started/install_library.en.md
) between code examples.install_library.ja.md
Add HTML breakpoints for better readability in Japanese doc
website_and_docs/content/documentation/webdriver/getting_started/install_library.ja.md
) between code examples.install_library.pt-br.md
Add HTML breakpoints for better readability in Portuguese doc
website_and_docs/content/documentation/webdriver/getting_started/install_library.pt-br.md
) between code examples.instructions.
install_library.zh-cn.md
Add HTML breakpoints for better readability in Chinese doc
website_and_docs/content/documentation/webdriver/getting_started/install_library.zh-cn.md
) between code examples.