search

Self-Evident / OneFileCMS

A single file cms - all in one file!
http://onefilecms.com/
166 stars 58 forks source link

File Upload Broken #16

Closed BenjaminEHowe closed 12 years ago

BenjaminEHowe commented 12 years ago

Google Chrome browser, PHP v5.2.6.

BenjaminEHowe commented 12 years ago

Just tested on PHP v5.3.10 - it works. I don't know if you want/need to support 2 versions old of PHP, but I suspect many other shared hosts haven't updated (I had to add a line to my .htaccess to switch up).

Self-Evident commented 12 years ago

Thanks for the info. The oldest version of PHP I currently have for testing is 5.2.8, so I hadn't noticed the issue.  Time to spend some time with Google...

----- Original Message ----- From: benzeman Sent: 11/10/12 04:06 PM To: Self-Evident/OneFileCMS Subject: Re: [OneFileCMS] File Upload Broken (#16)

Just tested on PHP v5.3.10 - it works. I don't know if you want/need to support 2 versions old of PHP, but I suspect many other shared hosts haven't updated (I had to add a line to my .htaccess to switch up). —

Self-Evident commented 12 years ago

Fixed. The issue was with a check on the Upload Page for ini_get('max_file_uploads'), but max_file_uploads wasn't introduced until PHP v 5.2.12. Added an if(){} statement to skip the check for older versions.

BenjaminEHowe commented 12 years ago

Thanks for fixing this so fast! :)

Is there any chance of implementing a plugin system, so a WYSIWYG editor can be installed if you want it, by simply adding a file. However, if you don't want WYSIWYG then you simply don't download WYSIWYG.php (or whatever), and it's still one file.

Many thanks, Ben

Self-Evident commented 12 years ago

Hmmm, I guess that sounds like an interesting idea.  As long as it could be made to work as a simple file include, with minimal additional code support in OneFile.  Is there a specific wysiwyg editor you use/would like to use. I've haven't looked at this type of idea yea.  

(and sorry for the delayed response - I am unable to check email every day) (and I don't get into smart-phones - I'm not smart enough...)

----- Original Message ----- From: benzeman Sent: 11/12/12 05:53 PM To: Self-Evident/OneFileCMS Subject: Re: [OneFileCMS] File Upload Broken (#16)

Many thanks :)

Is there any chance of implementing a plugin system, so a WYSIWYG editor can be installed I'd you want it, by simply adding a file. However, if you don't want WYSIWYG then you simply don't download WYSIWYG.php (or whatever), and it's still one file.

Many thanks, Ben

BenjaminEHowe commented 12 years ago

Ahh don't worry about response time, it's free software / support so don't worry about it... :)

Yeah, some sort of includes system, perhaps scanning a plugins directory (if it exists), and including all PHP files.

Regarding editors, I'd go for TinyMCE.

Self-Evident commented 11 years ago

Just a note that I added a wysiwyg plugin option.  There were a few minor adjustments I had to make, but it wasn't as difficult as I thought.  If you try it out, I would appreciate it if you would let me know if there are any issues (Generally, I'm my only beta tester, so I don't always (ever?)  catch everything.

In anycase, I hope it works for you, and thanks for the interest.

David

----- Original Message ----- From: benzeman Sent: 11/12/12 05:53 PM To: Self-Evident/OneFileCMS Subject: Re: [OneFileCMS] File Upload Broken (#16)

Many thanks :)

Is there any chance of implementing a plugin system, so a WYSIWYG editor can be installed I'd you want it, by simply adding a file. However, if you don't want WYSIWYG then you simply don't download WYSIWYG.php (or whatever), and it's still one file.

Many thanks, Ben