Upgrade web3 library to latest v1

SelfKeyFoundation / Identity-Wallet

Code for the SelfKey Identity Wallet

MIT License

58 stars 26 forks source link

Closed andregoncalves closed 4 years ago

andregoncalves commented 5 years ago

@sk91 this is something we should do, right?

sk91 commented 4 years ago

For QA: need to test all blockchain interactions and communication with KYCC using private key/trezor/ledger

rhdelima commented 4 years ago

@sk91 @andregoncalves Please see initial list of issues. Currently, I'm unable to test bank account.

SelfKey Profile

Setup your SelfKey Identity screen is no longer displayed. It directly opens SelfKey Profile if user clicks on profile avatar on upper right or click on My Profile on the left navigation. http://recordit.co/Wsqdv5CcuU

Ledger:

TREZOR

sk91 commented 4 years ago

FOR QA:

trezor issue should be fixed
please confirm if the issue occurs on mac for ledger, if it's only on windows, please open a separate bug for it, otherwise fail this one, I could not reproduce this on mac
selfkey profile is issue does not reproduce, if you see it again, please open a separate issue

sk91 commented 4 years ago

andregoncalves commented 4 years ago

Great work

rhdelima commented 4 years ago

Still failed on my end. Ledger works with Ledger Live but not with SK wallet.

andregoncalves commented 4 years ago

@rhdelima @sk91 this is fixed now, right?

rhdelima commented 4 years ago

yep. This is good now. Closing...