SelfKeyFoundation / Identity-Wallet

Code for the SelfKey Identity Wallet
https://selfkeyfoundation.github.io/Identity-Wallet/
MIT License
57 stars 26 forks source link

Possible Identity mix-up bug - v1.3.0 #1712

Closed andregoncalves closed 4 years ago

andregoncalves commented 4 years ago

"I found a bug in the SK desktop wallet. If you have more than one wallet than you opened and closed on the same PC, when you open one of them it retains the ID of the previous one opened

So if I opened John's wallet, then open Bill's wallet, John's ID appears in top right hand corner where it says 'Personal Profile'.

It's really confusing because at first I thought I'd opened using another user's private key but I hadn't. In fact, the wallet retains all of the previous user's data

It's a real mess actually. I just found out it even keeps the coin labels of coins in other wallets.

This didn't happen in the previous version."

andregoncalves commented 4 years ago

@rhdelima I did a few tests but was unable to reproduce the issue. Can you try and see if you can reproduce it?

rhdelima commented 4 years ago

@andregoncalves I can't replicate the issue. I did saw the tokens displayed (from other wallet) but disappeared for few seconds. See recording - http://recordit.co/ANE1GTVhhm

sk91 commented 4 years ago

Migration failure caused deletion of all wallets, but not connected tables.

So next time a wallet is created it would be connected to previous information

sk91 commented 4 years ago

For QA:

Test1

Test2

rhdelima commented 4 years ago

@sk91 Please see results below: Test 1 - Fail

Test 2 - Pass