Closed oanamangiurea closed 5 years ago
I have added scroll to modal screen with this https://github.com/SelfKeyFoundation/Identity-Wallet/blob/dev/src/renderer/selfkey-id/main/components/selfkey-id-create-form.jsx#L58
So we might be able to add it to the Selfkey-ui theme MuiModal so all the modals in the wallet will scroll. Cheers
@designhorf would you mind taking this one? cheers
@rodrigopavezi sure!
@oanamangiurea How can I test it on macbook pro with 1366x768 resolution? Opened dev tool and set this resolution but couldn't reproduce the menu breaking.
@designhorf for the menu alone, you don't even need to change resolution. Just open the dev tools, so the window of the wallet becomes small in height, the menu will break then anyway - here is how it looks if I don't go full screen with the app https://gyazo.com/9de66c9a3ffaed855b540e1c324b8588
Menu Issue will be fixed later
Menu issue is fixed here -> https://github.com/SelfKeyFoundation/Identity-Wallet/pull/878
Tested, all good
Same for using Ledger
Fix: Make it scrollable in the unlock wallet/use existing wallet screens
Dashboard doesn't look good, layout breaks https://gyazo.com/14b2abceff544809d1f2dc312959105e
About Selfkey ID modal (after you create a profile id for the first time) - make it scrollable
Menu breaks into 2 parts and has horizontal scroll - https://gyazo.com/f285df6447e514a5dd66c4cc4413f1dc