search

SelfLender / react-native-biometrics

React Native module for iOS and Android biometrics
MIT License
661 stars 225 forks source link

App crashes on certain devices #24

Closed andreifilip123 closed 4 years ago

andreifilip123 commented 5 years ago

Hello,

This package causes the app to crash on certain devices. I'll put the list below. Thanks 😄

Samsung Galaxy J4+ (SM-J415FN) Samsung Galaxy J3 2017 (SM-J330FN) Samsung A3 2015 (SM-A300FU)

NappyPirate commented 5 years ago

Unfortunately, I have not been able to test with these devices. Can you please provide the versions of react, react-native, and react-native-biometrics that you are using as well as the OS versions? Also, can you provide the stack trace or error message that you are receiving?

Also, is this issue related to #22?

andreifilip123 commented 5 years ago

I don't have the exact stack trace.. I fixed the problem by putting the Biometrics detection inside a try catch and if it fails, I set the biometric type to 'none'.

andreifilip123 commented 5 years ago

I'm not sure if it's related to #22 . It fails in the same place but I think it's not related since I can guarantee that all those devices are not rooted. Also, I heard that rooted devices can't use fingerprint since they have some kind of flag.

NappyPirate commented 4 years ago

Closing this issue since the Android implementation has been refactored to use the new BiometricPrompt API in version 2.0.0 and should hopefully resolve these errors. We can re-open this issue if the problems persist.