SelfhostedPro / selfhosted_templates

Portainer templates for selfhosted services
GNU General Public License v3.0
1.23k stars 238 forks source link

Please create new config file for arm devices #195

Closed orhanar closed 3 years ago

orhanar commented 3 years ago

Some services does not work on arm devices like pi. Please create different config file that is tested on such devices so we know it works on devices like Pi. Thanks.

pingywon commented 3 years ago

Been working on one here: https://github.com/SelfhostedPro/selfhosted_templates/tree/pingywon-yacht-arm

All these apps have been tested with a Raspberry Pi 4. The docker image was either changed for ARM or if no arm version existed the app was removed.

Waiting on some formatting changes but then you will be able to just load the ARM template.

I always looking for more ARM apps to add too btw.

orhanar commented 3 years ago

Been working on one here:

https://github.com/SelfhostedPro/selfhosted_templates/tree/pingywon-yacht-arm

All these apps have been tested with a Raspberry Pi 4. The docker image was either changed for ARM or if no arm version existed the app was removed.

Waiting on some formatting changes but then you will be able to just load the ARM template.

I always looking for more ARM apps to add too btw.

I'll check this out, thanks.

orhanar commented 3 years ago

Been working on one here: https://github.com/SelfhostedPro/selfhosted_templates/tree/pingywon-yacht-arm

All these apps have been tested with a Raspberry Pi 4. The docker image was either changed for ARM or if no arm version existed the app was removed.

Waiting on some formatting changes but then you will be able to just load the ARM template.

I always looking for more ARM apps to add too btw.

Hi coudnt find your email. When is this gone be available you reckon? I imported the list but nothing is getting displayed so i guess it hasnt been verified yet?

pingywon commented 3 years ago

Hey sorry! I thought this was all resolved. @SelfhostedPro can you help?

kylo252 commented 3 years ago

I just tested the Arm template and all I can see is the last entry, that would be SWAG in this case:

You can see it here: https://github.com/SelfhostedPro/selfhosted_templates/blob/412780d44b71e821314b864739f92508488eeb1e/Template/template.yml#L2158-L2160

I then tested using a modified template with SWAG removed, and sure enough it's only Papermerge now showing up.


I can see that https://github.com/SelfhostedPro/Yacht/pull/75 has been merged for a while now, but something must've mocked it up. From a quick glance over the code, I think that the problem is here:

https://github.com/SelfhostedPro/Yacht/blob/master/backend/api/db/crud/templates.py#L56

I think we should be using yaml.load_all() instead as per the docs

If a string or a file contains several documents, you may load them all with the yaml.load_all function.

I can't test the code unfortunately since I'm having issues with mysql_config dependecies on both my Linux and Win10 machines. It might be somethig simple tho since my experience with Python is pretty limited.

@SelfhostedPro, Let me know if you require more info. Hopefully this has been helpful to someone :)

SelfhostedPro commented 3 years ago

yaml.load_all() is unsafe which is why I'm using the safeload. The correct arm branch to use is this one: https://raw.githubusercontent.com/SelfhostedPro/selfhosted_templates/yacht-arm/Template/template.yml

As the one you're trying has errors and is not valid yaml.

kylo252 commented 3 years ago

Thank you! It's indeed working correctly.


The correct arm branch to use is this one: https://raw.githubusercontent.com/SelfhostedPro/selfhosted_templates/yacht-arm/Template/template.yml

I think it might be a good idea to point it out in the README somewhere. And on a related note, maybe link the new https://yacht.sh/docs/ in Yacht's repo description :)

SelfhostedPro commented 3 years ago

I'll definitely add the info there. I'm looking at changing around how the repo is laid out so there may be a different URL that's recommended in the future. I'll make sure whatever I wind up doing, that it's in the documentation.