search

SelinaDev / Godot-Roguelike-Tutorial

Yet Another Roguelike Tutorial in Godot
MIT License
102 stars 11 forks source link

Part 2: "You should now be able to run the project and see two characters at the center of the screen" (you can't) #16

Closed rosskarchner closed 9 months ago

rosskarchner commented 9 months ago

Hello! I'm enjoying the tutorial so far.

Unless I've missed something, when you hit the statement "You should now be able to run the project and see two characters at the center of the screen", you actually can't yet, because _process hasn't been updated or replaced yet, and still contains references to the now-deleted player_grid_pos.

rosskarchner commented 9 months ago

Taking another look, and I think the problem is that when you say "Modify the top of the script to read as follows", I didn't occur to me that I should remove _process, since I was just "modifying the top".

So, maybe a reading comprehension issue on my part, but it might be clearer to just say "replace the contents of game.gd with this"

SelinaDev commented 9 months ago

Thank you for catching this. I do have to admit that I writing the code and writing the tutorial happens separately, so I am usually mostly guessing/remembering the state of the projecht throughout the tutorial parts. Also I do indeed use the language you mentioned to mostly indicate additions, so I should be more explicit about deletions like in this case. I'll update it as soon as possible.

rosskarchner commented 9 months ago

I got to the end of part 2, and there I found the section discussing replacing _process with _physics_process-- the changes you make to address this issue, might effect that part as well.

I don't know if you want a new issue for each thing I find, but when I ran the game at this point, I couldn't see the player or npc. I figured out that this was because of the order of the nodes, I needed to move the "Entities" node to be below the "Map" node, so they'd be drawn above the map instead of under it.

SelinaDev commented 9 months ago

I updated part 2 of the tutorial now, according to your recommendations. I mentioned removing the _process() function, and added a few sentences explaining Godot's render order. I have something like this in a later tutorial, where a similar problem was common, but I didn't realize this could be a problem in part 2 as well. I think this explanation should provide valuable context. Thank you again.