search

Selleo / design-system

Design System
https://designsystem.selleo.com
4 stars 1 forks source link

feat: Add Avatars components #16

Closed DawidHaratyk closed 1 year ago

DawidHaratyk commented 1 year ago

closes #51

netlify[bot] commented 1 year ago

Deploy Preview for selleo-designsystem ready!

Name Link
Latest commit 67453fee92475162bc2b99af921b679afc516722
Latest deploy log https://app.netlify.com/sites/selleo-designsystem/deploys/6405c9e0858d050008ee8ad8
Deploy Preview https://deploy-preview-16--selleo-designsystem.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

michalgren commented 1 year ago

@DawidHaratyk there are a few inconsistencies with the design versus what has been implemented:

  1. The gap between AvatarImage and the user name should be 8px
  2. There should be 2 sizes of avatars "24" and "32"
  3. "24" size UserName should be regular, font size is 12px, AvatarImage should have 24px width and height, bg color - white, font size = 10px, without letter spacing, and line height = 100%
  4. "32" size UserName should be regular, font size is 14px, AvatarImage should have 32px width and height, bg color - white, font size = 14px, without letter spacing, and line height = 100% Design here
DawidHaratyk commented 1 year ago

@DawidHaratyk there are a few inconsistencies with the design versus what has been implemented:

  1. The gap between AvatarImage and the user name should be 8px
  2. There should be 2 sizes of avatars "24" and "32"
  3. "24" size UserName should be regular, font size is 12px, AvatarImage should have 24px width and height, bg color - white, font size = 10px, without letter spacing, and line height = 100%
  4. "32" size UserName should be regular, font size is 14px, AvatarImage should have 32px width and height, bg color - white, font size = 14px, without letter spacing, and line height = 100% Design here

Yes, you're right, I've implemented these styles now

k1eu commented 1 year ago

Those local branches should be rebased to avoid those build errors, and before merging commits should be meaningful without unnecessary ones

PoslinskiNet commented 1 year ago

2 approves -> merge

PoslinskiNet commented 1 year ago

@k1eu can we have an automatic workflow for this running (via GitHub repo setting)? There was some discussion around this here.