search

Selleo / design-system

Design System
https://designsystem.selleo.com
4 stars 1 forks source link

feat: add search input component and page for it #77

Closed DawidHaratyk closed 1 year ago

DawidHaratyk commented 1 year ago

Overview:

closes #19

Added search input page and SearchInput component with variants with label and without label as well

Preview

image

netlify[bot] commented 1 year ago

Deploy Preview for selleo-designsystem ready!

Name Link
Latest commit f456f7a360365a6dae3deb7d342524085115a6f4
Latest deploy log https://app.netlify.com/sites/selleo-designsystem/deploys/64103bc8bf17120008849f3c
Deploy Preview https://deploy-preview-77--selleo-designsystem.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

PoslinskiNet commented 1 year ago

My first guess - it is a variation of the input - so I would go for merging those two into one (input). Another remark - this implementation already impacted generic input as well - please check it.

k1eu commented 1 year ago

@DawidHaratyk as @PoslinskiNet said we can merge it into one item on the sidebar Input since basically it's what search is - Text input. Please look into possibilities of integrating existing input code for it, also just as the input it can be full width for now

PoslinskiNet commented 1 year ago

@DawidHaratyk is it ready for review?

DawidHaratyk commented 1 year ago

@DawidHaratyk is it ready for review?

Yes, it is, I've merged the search input component into "input" page

DawidHaratyk commented 1 year ago

Thanks! While u in the context can you try to fix the focus outlines on other inputs? I'll create a task for you Visual representation of issue image

Yes ofc :), can you create a task to fix that as you said?