Selleo / design-system

Design System
https://designsystem.selleo.com
4 stars 1 forks source link

feat: remove more section and move mode switcher to the app header #91

Closed DawidHaratyk closed 1 year ago

DawidHaratyk commented 1 year ago

Overview:

closes #90

Short description and worth mentioning decision made.

Preview

image
netlify[bot] commented 1 year ago

Deploy Preview for selleo-designsystem ready!

Name Link
Latest commit 7d3b4127dbca2e039805e7c35fa3283a87c3f5f3
Latest deploy log https://app.netlify.com/sites/selleo-designsystem/deploys/64257e212768f10008a5dcbb
Deploy Preview https://deploy-preview-91--selleo-designsystem.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

PoslinskiNet commented 1 year ago

@DawidHaratyk I think we could use the remaining space that was previously occupied by the right sidebar for the content purpose (for instance in the components preview it could be helpful, but I guess everywhere we will get extra space for free.

DawidHaratyk commented 1 year ago

I see the header is now locked in a around 1300px container and centered where the page content is not. Please unify it by applying the same container pattern to the Page body and footer

I've added that but about footer, I don't think need to unify that as well, do we?