search

Sellorio / mega-macro

A World of Warcraft AddOn that replaces the built in macro functionality allowing more and bigger macros.
20 stars 13 forks source link

Support for localized classes in WoW #153

Closed fmiglianico closed 2 years ago

fmiglianico commented 2 years ago

In french, classes are different for Male/Female characters. This means macros are not shared between male and female characters of the same class. Example : Druid (M) is Druide Druid (F) is Druidesse

Same for almost all the others classes.

This PR fixes that. Based on https://wowwiki-archive.fandom.com/wiki/API_UnitClass.

Sellorio commented 2 years ago

Thanks for this :) If it's no inconvenience, I might hold off for release until 9.3 where I will anyway need to version bump the addon and make a new release.

fmiglianico commented 2 years ago

No problem. One thing I didn't know how to handle is the migration between this version and the previous one, because the class names in the file with the macros need to be english and capitalized. I started from nothing so I didn't have this problem, but if someone with all of it configured downloads this version all of his macros will disappear in the UI... But they will still be in the file with the wrong class (Druid needs to become DRUID).

Le mar. 28 juin 2022 à 01:42, Sellorio @.***> a écrit :

Thanks for this :)

— Reply to this email directly, view it on GitHub https://github.com/Sellorio/mega-macro/pull/153#issuecomment-1168041124, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLV2CREBGXMOJN4JHRRH3DVRI4AFANCNFSM5Z6PTWIA . You are receiving this because you authored the thread.Message ID: @.***>

sellorio2 commented 2 years ago

Yeah I'm not too fussed about it. There's no harm it in being there.

fmiglianico commented 2 years ago

Alright, anyway thanks for the addon, super helpful !

Le mar. 28 juin 2022 à 10:16, Sea Millo @.***> a écrit :

Yeah I'm not too fussed about it. There's no harm it in being there.

— Reply to this email directly, view it on GitHub https://github.com/Sellorio/mega-macro/pull/153#issuecomment-1168390040, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLV2CURCQNLMQRYWA6WLX3VRKYD7ANCNFSM5Z6PTWIA . You are receiving this because you authored the thread.Message ID: @.***>

sellorio2 commented 2 years ago

Thank you for your contribution. If only anyone who found bugs could do the same :P