search

Sellorio / mega-macro

A World of Warcraft AddOn that replaces the built in macro functionality allowing more and bigger macros.
20 stars 13 forks source link

Fixes to window icons and click event #162

Closed aurelion314 closed 1 year ago

aurelion314 commented 1 year ago

@Sellorio

This gets it working for Dragonflight.

Changes include:

@Dannez83, I've made this under a new fork because yours had altered line endings that made viewing the diff very difficult. I'm not sure how to correct that so I just started over.

Related Issue: #158

*Edit: Fixed the shift click issue and a scrollbar error. Should be fully usable now.

ghost commented 1 year ago

Hey

"revert a caching feature that seemed to break the non global macro pages"

This is related to #156 and will fix this. The problem behind is that it changed the way how macros are stored so old macros will be gone. The old ones are stored behind a localized class name and with this fix every marcro is stored under the english classname in capital letters.

Sellorio commented 1 year ago

Looks like it's really close. I might hold off until a few of the uncertainties are resolved or if that looks to be taking a bit I'll merge in and create a prerelease version to help less-tech-savy players.

aurelion314 commented 1 year ago

SpellButton_OnModifiedClick has been replaced with a mixin.

This was a good find but I think the mixin acts as a template and by hooking the mixin, it's not hooking the thing that actually gets called.

"SpellButton_OnModifiedClick" used to be listed in here, so I've checked the new file for something that replaces it but didn't find anything.

I'm a bit stumped at the moment, and unfortunately have to work on other things for a while.

aurelion314 commented 1 year ago

Hey @Sellorio, I think its good to go now.

I fixed the shift click issue. I also fixed the window.lua double load error that I noticed you mention in the comments ;) (It was already loading in the xml file, so it didn't need to be in the toc file) I haven't heard anything else about the 'LeftButton' revert today, so I think it was a temporary issue on Blizzards side.

Hopefully my hacks to make it work aren't too hacky :)

Also, I didn't modify the readme like you mentioned, but if you want to throw @Dannez83 and my name in somewhere that's cool (I go by Cubelicious in game). Not a big a deal though.

Cheers

Sellorio commented 1 year ago

Hey @Sellorio, I think its good to go now.

I fixed the shift click issue. I also fixed the window.lua double load error that I noticed you mention in the comments ;) (It was already loading in the xml file, so it didn't need to be in the toc file) I haven't heard anything else about the 'LeftButton' revert today, so I think it was a temporary issue on Blizzards side.

Hopefully my hacks to make it work aren't too hacky :)

Also, I didn't modify the readme like you mentioned, but if you want to throw @Dannez83 and my name in somewhere that's cool (I go by Cubelicious in game). Not a big a deal though.

Cheers

Is that everything?

wing5wong commented 1 year ago

Il test the reverted code tonight or can feedback to you after a release if you want to push ahead anyway.

Seems strange that 2 different group of people have different results - had this been confirmed with anyone else to be working that previously had the issue?

Regards, Sean Anderson

On 28/10/2022, at 2:10 PM, Mike @.***> wrote:



Hey @Selloriohttps://github.com/Sellorio, I think its good to go now.

I fixed the shift click issue. I also fixed the window.lua double load error that I noticed you mention in the comments ;) (It was already loading in the xml file, so it didn't need to be in the toc file) I haven't heard anything else about the 'LeftButton' revert today, so I think it was a temporary issue on Blizzards side.

Hopefully my hacks to make it work aren't too hacky :)

Also, I didn't modify the readme like you mentioned, but if you want to throw @Dannez83https://github.com/Dannez83 and my name in somewhere that's cool (I go by Cubelicious in game). Not a big a deal though.

Cheers

— Reply to this email directly, view it on GitHubhttps://github.com/Sellorio/mega-macro/pull/162#issuecomment-1294287517, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABBT5UOQOFNFGHZ3WRWDF6TWFMRWZANCNFSM6AAAAAARPWLDLU. You are receiving this because you commented.Message ID: @.***>

aurelion314 commented 1 year ago

Ok I figured it out. For some reason it depends on the value of the CVar "ActionButtonUseKeyDown". I'm pretty sure this is a bug on blizzards side, but I added a fix that checks the value of that and changes the click text based on it. Should work for everyone now.

@Sellorio @wing5wong

wing5wong commented 1 year ago

Confirming its working my end with this change

Thanks

From: @.> Sent: Friday, 28 October 2022 4:58 pm To: @.> Cc: Sean @.>; @.> Subject: Re: [Sellorio/mega-macro] Fixes to window icons and click event (PR #162)

Ok I figured it out. For some reason it depends on the value of the CVar "ActionButtonUseKeyDown". I'm pretty sure this is a bug on blizzards side, but I added a fix that checks the value of that and changes the click text based on it. Should work for everyone now.

@Selloriohttps://github.com/Sellorio @wing5wonghttps://github.com/wing5wong

— Reply to this email directly, view it on GitHubhttps://github.com/Sellorio/mega-macro/pull/162#issuecomment-1294419741, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABBT5UKI2O726K2IEWYWIHTWFNFMVANCNFSM6AAAAAARPWLDLU. You are receiving this because you were mentioned.Message ID: @.***>

Dannez83 commented 1 year ago

Ok I figured it out. For some reason it depends on the value of the CVar "ActionButtonUseKeyDown". I'm pretty sure this is a bug on blizzards side, but I added a fix that checks the value of that and changes the click text based on it. Should work for everyone now.

@Sellorio @wing5wong

Nice one @aurelion314, and on those other fixes too