Sellorio / mega-macro

A World of Warcraft AddOn that replaces the built in macro functionality allowing more and bigger macros.
17 stars 13 forks source link

Mega Macro Blocked by Blizzard UI #179

Open Magustar opened 1 year ago

Magustar commented 1 year ago

I've not seen anything in Bug Grabber but it seems like every time I hit a loading screen I have to /reload ui or face the following popup;

image

I see errors from EditModeSystemTemplates

image

It seems like this may be an error in Blizzards new UI but is there any workaround we can do make MegaMacros more stable?

Dannez83 commented 1 year ago

mega-macro-action-bar-engine.zip

try replacing the above in MegaMacro\src\engine

Backup the old file first in case you need to revert for any reason

Magustar commented 1 year ago

Dannez83,

Thanks that helped the stability greatly I've not seen any hard crashes but I'm noticing some quirks. Timers on buttons using #showtooltip [mod:ctrl] or [mod:shift] show the timer of the spell without mod not their own timers. While I haven't seen any hard crashes I do get bug catcher errors and once I see those my trinkets placed in other action bars are unresponsive without a reload ui

Magustar commented 1 year ago

And no sooner did I post this I did get a hard crash, but it does seem to be much less frequent.

aurelion314 commented 1 year ago

Hey @Magustar, Are you still getting these errors? I haven't had them myself, but I created some options that might fix it. They limit some functionality, but might beat having to reload frequently. Version is here. I'm trying to get feedback on if the features are worth it before requesting a merge. You have to go to the config tab and enable the options before it does anything different.

Magustar commented 1 year ago

Hi @aurelion314 , Yeah I seem to notice some patterns here. I notice it's much worse when the bars change ie. druids changing form or rogues going in and out of stealth. If that helps in narrowing down the issue. I'll check out your link though and let you know.

southpaw168 commented 1 year ago

Hi guys. I get the blizzard block aswell. I'm playing druid and as Magustar said. It's mainly when i shift or the spell has to change stance. If I can contribute more details let me know

Magustar commented 1 year ago

@aurelion314 so tried the branch you linked and didn't see any change.

aurelion314 commented 1 year ago

@Magustar did you enable the options in the config tab? They are not enabled by default, but it should start using default blizzard icons/macro once enabled (reload may be required). If it still errors with that, that's quite interesting..

JoeLatte88 commented 1 year ago

@aurelion314 , I took the code from your fork and I don't seem to be getting actions blocks anymore. Used to happen every couple minutes, but now doesn't occur after 30 minutes of constant combat/dragonriding..... I'll keep testing, but looks good so far.

Magustar commented 1 year ago

@aurelion314 Hmm maybe that's what I'm missing? How do I enable the config tab? I don't see any options in game.

aurelion314 commented 1 year ago

It should simply appear as another tab: image

Magustar commented 1 year ago

HAH! You're absolutely right. I was looking in the addon folder and in the files. Thanks.

Dannez83 commented 1 year ago

@aurelion314 Do the config settings reintroduce the blizzard limit on the number of macros per character, or just the character limit of the macros?

aurelion314 commented 1 year ago

@aurelion314 Do the config settings reintroduce the blizzard limit on the number of macros per character, or just the character limit of the macros?

Just the character limit. You'll still have the spec/class tabs and it doesn't affect the saved Macro data. So if you have a 1000 character macro, it will still be there if you switch back to Mega Macro style. It is simply truncated while using Bliz style.

I now realize that 'Blizzard Style' may be poor word choice, since it might sound as if it will revert entirely to blizzard UI and everything. However it only changes how the macros are bound behind the scenes.

Dannez83 commented 1 year ago

@aurelion314 Do the config settings reintroduce the blizzard limit on the number of macros per character, or just the character limit of the macros?

Just the character limit. You'll still have the spec/class tabs and it doesn't affect the saved Macro data. So if you have a 1000 character macro, it will still be there if you switch back to Mega Macro style. It is simply truncated while using Bliz style.

I now realize that 'Blizzard Style' may be poor word choice, since it might sound as if it will revert entirely to blizzard UI and everything. However it only changes how the macros are bound behind the scenes.

ok cheers. I have a lot of macros on but they are all quite short, so I will give this a go and report back

durandal42 commented 1 year ago

I'm trying to get feedback on if the features are worth it before requesting a merge.

For me the only critical feature of MegaMacro is macro sharing between characters in excess of the default limit on global macros, so I'll definitely give this a try.

YetAnotherDevWannabe commented 1 year ago

Thanks for the the option @aurelion314. So in the end we still have no clue what is creating the problem and how to solve it ?

aurelion314 commented 1 year ago

Thanks for the the option @aurelion314. So in the end we still have no clue what is creating the problem and how to solve it ?

It seems related to the icon engine, but I've never had the issue myself, so I can't help debug it much. Dannez83 seemed to reduce it with his own modifications, but apparently it still happened. I suspect blizzard has changed some features of the macro buttons to be protected even out of combat, but I think someone who experiences the problem will need to figure it out.

YetAnotherDevWannabe commented 1 year ago

Even with your edits I keep having the issue, but it's way more rare. It seems to be linked to grouping, but not sure.

Syhlo commented 1 year ago

My brother was having this issue. He was running the stock UI. I had him test a few things, one of which was installing Bartender 4, and that seemed to resolve the issue for him.. so it's likely something to do with the stock UI.

gillouche commented 1 year ago

hi @aurelion314, your branch completely fixed all my issue with Mega Macro. Would it be possible to have it merged in the main repo? Thanks!

Magustar commented 1 year ago

Just updated and issues are back. How can I get the old version you offered?

Sydafex commented 1 year ago

As Magustar mentioned, this issue is quite common again- any updates on this?

durandal42 commented 7 months ago

Apparently I've been running @aurelion314's version for quite some months now, and so the latest update broke me again.

Can we get aurelion's fixes merged into the master branch?

aurelion314 commented 7 months ago

@durandal42 do you use long macros or rely on Mega Macro's icon engine? I've been debating whether a highly stripped down version of Mega Macro that just does the macro organization might be worthwhile. I have ideas of how to avoid overwriting existing macros too. I just returned this season and could use Mega Macro again so I've been thinking about it.

durandal42 commented 7 months ago

@aurelion314 The only load-bearing feature, for me, is the organization. Specifically, I really like being able to share macros across different characters with the same class, without running into the limit on account-level macros.

aurelion314 commented 7 months ago

Ok same thing for me. If I can find the time I'll see about isolating just that part.

aurelion314 commented 7 months ago

@durandal42 If you want to try it out, I'm working on some changes here: https://github.com/aurelion314/mega-macro/tree/Engine-Rework

Note that it isn't polished just yet. Could be some bugs, and since I did rework some import logic, might be best to back up WTF folder first... Unlikely to be necessary, but good to be safe ;)