search

Sellorio / mega-macro

A World of Warcraft AddOn that replaces the built in macro functionality allowing more and bigger macros.
20 stars 13 forks source link

Updated for 11.0 The War Within #219

Closed bpapuni closed 3 months ago

bpapuni commented 3 months ago

With The War Within Blizzard have made some changes to how macros work.

The length of macros executable by "macrotext" is being restricted to 255 characters, and all macros (both real and "macrotext" based ones) are being restricted to remove the ability to chain macros. This means that one macro cannot "/click" a button that itself would execute another macro. https://github.com/Stanzilla/WoWUIBugs/issues/552#issuecomment-2192109095

This pull request changes several constants to handle this change. Additionally, it moves refactors several functions into the appropriate namespaces Blizzard has introduced.

Sellorio commented 3 months ago

Is there nothing that can be done about the 255 character limit? So ratty of blizzard to do this.

Sellorio commented 3 months ago

When users edit a macro over 255 characters (i.e. they update to this version and they have an old macro that was larger), will it still show the full macro and let them edit it down to size or will it just clip it off?

bpapuni commented 3 months ago

Is there nothing that can be done about the 255 character limit? So ratty of blizzard to do this.

Unfortunately not.

When users edit a macro over 255 characters (i.e. they update to this version and they have an old macro that was larger), will it still show the full macro and let them edit it down to size or will it just clip it off?

I actually hadn't considered this. In it's current state it'll just clip it off. I'll rework the behavior tonight when I get home from work to show the full macro and allow the user to edit it down.