Sellorio / mega-macro

A World of Warcraft AddOn that replaces the built in macro functionality allowing more and bigger macros.
18 stars 13 forks source link

Macro doesnt work above 250 characters #224

Open wing5wong opened 1 month ago

wing5wong commented 1 month ago

i have the following macro (253 characters). it does not function

#showtooltip
/cancelform [form:1/2/3/4]
/cancelaura soulshape
/leavevehicle [canexitvehicle]
/use [mod:shift] Grand Expedition Yak
/stopmacro [mod:shift]
/use [advflyable] Cliffside Wylderdrake
#/use Eve's Ghastly rider
/run C_MountJournal.SummonByID(0)

the macro functions once it is 250 characters. for example, if i remove 3 characters from the #/use Eve's Ghastly rider line, the macro works as expected

#showtooltip
/cancelform [form:1/2/3/4]
/cancelaura soulshape
/leavevehicle [canexitvehicle]
/use [mod:shift] Grand Expedition Yak
/stopmacro [mod:shift]
/use [advflyable] Cliffside Wylderdrake
#/use Eve's Ghastly ri
/run C_MountJournal.SummonByID(0)
bpapuni commented 1 month ago

The addon reserves five characters for assigning Id's to the macros. Blizzard has removed the ability to have 1023 characters in a macro like we're used to, so now we are limited by the native 255 characters (minus the five MegaMacro reserves).

As a workaround, to save characters can you just use /cancelform without the conditional? You want to leave form regardless of what form you're in right?

wing5wong commented 1 month ago

This particular macro can definitely be optimised, but the issue will still exist for others.

I’d suggest in this case if 5 chars are reserved, the macro length should be shown as X/250 instead of 255 available

Konungrr commented 1 month ago

Having longer than 255 characters is the entire reason for the addon in the first place. So is this addon just outright dead?

wing5wong commented 1 month ago

Unless there are other macro addons to group by class/spec etc this is still useful for me

Sellorio commented 1 month ago

Yup exactly. The primary feature was always the macro swapping capability. It sucks that blizzard has removed this additional pillar but it is what it is.

The last thing I see as a pillar feature is the improved ui and editing capabilities.

wing5wong commented 1 month ago

Hi Sellorio I still think this issue should remain open as the ui is giving misleading info. 255 available as opposed to 250 due to the 5 reserved for the macro id

Sellorio commented 1 month ago

Fair enough